[jira] [Commented] (SLING-2835) Addition of OSGi-aware javax.activation bundle

2013-04-22 Thread Felix Meschberger (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637993#comment-13637993
 ] 

Felix Meschberger commented on SLING-2835:
--

Thanks for the patch.

I have a comment on formatting: We generally use Sun's original Java formatting 
guidelines. Particularly we format all blocks as regular brace-encapsulated 
blocks even if the block has a single-statement only.

May I ask you to fix ? Thanks.

 Addition of OSGi-aware javax.activation bundle
 --

 Key: SLING-2835
 URL: https://issues.apache.org/jira/browse/SLING-2835
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Robert Munteanu
 Attachments: org.apache.sling.javax.activation.zip


 Currently Sling exposes the javax.activation package using a system framework 
 extension. This works well for some use cases. However, it does not work well 
 with the official javax.mail bundle. The javax.mail bundle is now OSGi-aware, 
 but the classloading problems between javax.mail and javax.activation 
 persist. javax.activation tries to read a /META-INF/mailcap file from the 
 javamail jar and loads DataContentHandler classes from the javamail jar.
 To prevent this problem from occuring I have created a javax.activation 
 bundle which provides a custom CommandMap implementation. This implementation 
 uses the foreign bundle's classloader ( e.g. javax.mail classloader ) to load 
 classes. This solves the classloading conflict between javax.mail and 
 javax.activation.
 I will attach a zip archive of the maven project to the bundle as a 
 contribution. The file is named org.apache.sling.javax.activation.zip and has 
 the sha1sum  cd4ad4279b5673a070d919a118d9aca571656f91 , md5sum 
 68487bdca46ba47bce9947087bd659ea .

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (SLING-2835) Addition of OSGi-aware javax.activation bundle

2013-04-22 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638013#comment-13638013
 ] 

Robert Munteanu commented on SLING-2835:


I've reformatted the code to use braces for single-line statements. The new 
checksums are 36d15b31af430d0769c54eb03c33ccf0a0b527ce ( SHA1 ) and 
9c4c797b8bc520dd248344877be5ea66 (MD5).



 Addition of OSGi-aware javax.activation bundle
 --

 Key: SLING-2835
 URL: https://issues.apache.org/jira/browse/SLING-2835
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Robert Munteanu
 Attachments: org.apache.sling.javax.activation.zip, 
 org.apache.sling.javax.activation.zip


 Currently Sling exposes the javax.activation package using a system framework 
 extension. This works well for some use cases. However, it does not work well 
 with the official javax.mail bundle. The javax.mail bundle is now OSGi-aware, 
 but the classloading problems between javax.mail and javax.activation 
 persist. javax.activation tries to read a /META-INF/mailcap file from the 
 javamail jar and loads DataContentHandler classes from the javamail jar.
 To prevent this problem from occuring I have created a javax.activation 
 bundle which provides a custom CommandMap implementation. This implementation 
 uses the foreign bundle's classloader ( e.g. javax.mail classloader ) to load 
 classes. This solves the classloading conflict between javax.mail and 
 javax.activation.
 I will attach a zip archive of the maven project to the bundle as a 
 contribution. The file is named org.apache.sling.javax.activation.zip and has 
 the sha1sum  cd4ad4279b5673a070d919a118d9aca571656f91 , md5sum 
 68487bdca46ba47bce9947087bd659ea .

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira