[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731801#comment-13731801 ] Felix Meschberger commented on SLING-2997: -- I agree. Java 5 is dead and new code should IMHO be free to required Java 6 -- if only for the @Override annotation which IMHO is a big plus in code stability by supporting the compiler with its static code analysis. ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730855#comment-13730855 ] Carsten Ziegeler commented on SLING-2997: - Do we really want to require java 6 just because of an annotation? I think we should rather not use the annotation and stick to java 5 unless there are good reasons ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730881#comment-13730881 ] Justin Edelson commented on SLING-2997: --- I personally like having the @Override annotation for interfaces, so I'd consider this a good reason :) But I didn't write this code, so I can't speak to why it was used there. Another option would be to separate out the source vs. target version in the parent POM. Right now, there is one property which controls both. ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730884#comment-13730884 ] Carsten Ziegeler commented on SLING-2997: - So could we simply set source fixed to 1.6 (for now), and by default target is 1.5 and can be changed to 1.6? ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730956#comment-13730956 ] Justin Edelson commented on SLING-2997: --- I think so, but right now the parent pom only lets you specify them with one property. And retaining Java 5 for this (new, never released) bundle doesn't really seem worth it. ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
