[ https://issues.apache.org/jira/browse/SLING-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194616#comment-14194616 ]
Bertrand Delacretaz commented on SLING-4114: -------------------------------------------- Thanks, I like this variant - the date/time is not really useful in the RPT messages anyway as the log message itself does have a timestamp, and the RPT output includes elapsed time since the request started. I have applied your patch in http://svn.apache.org/r1636373, thanks for your contribution! FWIW here's an example output with the compact format active {code} 03.11.2014 16:12:56.236 *DEBUG* [0:0:0:0:0:0:0:1 [1415027576194] GET /.explorer.node.html HTTP/1.1] org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter 0 TIMER_START{Request Processing} 0 COMMENT timer_end format is {<elapsed msec>,<timer name>} <optional message> 0 LOG Method=GET, PathInfo=/.explorer.node.html 0 TIMER_START{ResourceResolution} 0 TIMER_END{0,ResourceResolution} URI=/.explorer.node.html resolves to Resource=JcrNodeResource, type=sling:redirect, superType=null, path=/ 0 LOG Resource Path Info: SlingRequestPathInfo: path='/', selectorString='explorer.node', extension='html', suffix='null' 0 TIMER_START{ServletResolution} 0 TIMER_START{resolveServlet(JcrNodeResource, type=sling:redirect, superType=null, path=/)} 2 TIMER_END{2,resolveServlet(JcrNodeResource, type=sling:redirect, superType=null, path=/)} Using servlet /libs/sling/servlet/default/explorer/node.esp 2 TIMER_END{2,ServletResolution} URI=/.explorer.node.html handled by Servlet=/libs/sling/servlet/default/explorer/node.esp 2 LOG Applying Requestfilters 2 LOG Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter 2 LOG Applying Componentfilters 2 TIMER_START{/libs/sling/servlet/default/explorer/node.esp#0} 36 TIMER_START{resolveIncludedResource(/.explorer.edit.sling_redirect.html)} 37 TIMER_END{0,resolveIncludedResource(/.explorer.edit.sling_redirect.html)} path=/.explorer.edit.sling_redirect.html resolves to Resource=JcrNodeResource, type=sling:redirect, superType=null, path=/ 37 LOG Including resource JcrNodeResource, type=sling:redirect, superType=null, path=/ (SlingRequestPathInfo: path='/', selectorString='explorer.edit.sling_redirect', extension='html', suffix='null') 37 TIMER_START{resolveServlet(JcrNodeResource, type=sling:redirect, superType=null, path=/)} 38 TIMER_END{1,resolveServlet(JcrNodeResource, type=sling:redirect, superType=null, path=/)} Using servlet /libs/sling/servlet/default/explorer/edit/sling_redirect.esp 38 LOG Applying Includefilters 38 TIMER_START{/libs/sling/servlet/default/explorer/edit/sling_redirect.esp#1} 40 TIMER_END{2,/libs/sling/servlet/default/explorer/edit/sling_redirect.esp#1} 41 TIMER_END{39,/libs/sling/servlet/default/explorer/node.esp#0} 41 TIMER_END{41,Request Processing} Request Processing {code} > Compact and more specific logs from RequestProgressTrackerLogFilter > -------------------------------------------------------------------- > > Key: SLING-4114 > URL: https://issues.apache.org/jira/browse/SLING-4114 > Project: Sling > Issue Type: Improvement > Components: Engine > Affects Versions: Engine 2.3.6 > Reporter: Julian Sedding > Attachments: SLING-4114-jsedding-v2.patch, SLING-4114-jsedding.patch > > > The RequestProgressTracker currently logs each RPT message as a separate log > entry. Considering the potentially large number of log entries this can add > significantly to the size of log files and the I/O involved. > By logging all RPT messages as a single log entry, the overhead can be > reduced. In addition, filtering by extension and request duration (min/max) > can further reduce the log size (and simplify analysis). -- This message was sent by Atlassian JIRA (v6.3.4#6332)