[jira] [Commented] (SLING-4547) JcrResourceBundle does not support multiple base names

2017-03-29 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947134#comment-15947134
 ] 

Konrad Windszus commented on SLING-4547:


Fixed in [r1789363|https://svn.apache.org/r1789363].

> JcrResourceBundle does not support multiple base names
> --
>
> Key: SLING-4547
> URL: https://issues.apache.org/jira/browse/SLING-4547
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Andrei Pilets
>Assignee: Konrad Windszus
> Fix For: i18n 2.5.10
>
>
> The sling:basename property may be multi-valued, that is the messages of a 
> mix:language nodes may belong to multiple base names and thus ResourceBundle 
> instances, as stated at 
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
>  
> The latest codebase does not work in that way.
> JcrResourceBundle#loadPotentialLanguageRoots():
> if (baseName == null || baseName.equals(properties.get(PROP_BASENAME, ""))) {
>  paths.add(bundle.getPath());
> }
> In case if property sling:basename have multiple values, only the first base 
> name is considered, others are skipped.
> The correct implementation would be to use properties.get(PROP_BASENAME) - 
> method version without default value parameter, which would return array. You 
> would need to iterate over its items and check equality.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-4547) JcrResourceBundle does not support multiple base names

2017-03-27 Thread Alexandre Lloret (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943567#comment-15943567
 ] 

Alexandre Lloret commented on SLING-4547:
-

Hi,

We have the same issue any news about the problem ?

Kinds Regards

> JcrResourceBundle does not support multiple base names
> --
>
> Key: SLING-4547
> URL: https://issues.apache.org/jira/browse/SLING-4547
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Reporter: Andrei Pilets
>
> The sling:basename property may be multi-valued, that is the messages of a 
> mix:language nodes may belong to multiple base names and thus ResourceBundle 
> instances, as stated at 
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
>  
> The latest codebase does not work in that way.
> JcrResourceBundle#loadPotentialLanguageRoots():
> if (baseName == null || baseName.equals(properties.get(PROP_BASENAME, ""))) {
>  paths.add(bundle.getPath());
> }
> In case if property sling:basename have multiple values, only the first base 
> name is considered, others are skipped.
> The correct implementation would be to use properties.get(PROP_BASENAME) - 
> method version without default value parameter, which would return array. You 
> would need to iterate over its items and check equality.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)