[jira] [Commented] (SLING-6031) Teleporter: Wait for Services not ready yet on startup

2016-09-02 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458547#comment-15458547
 ] 

Stefan Seifert commented on SLING-6031:
---

what would be the best way:
# just move this class to a util java package in the teleporter project
# add an optional "waitfor" flag to the existing getService() methods of the 
junit rule, or an alternative method call getServiceWaitFor
# some other semantics?

> Teleporter: Wait for Services not ready yet on startup
> --
>
> Key: SLING-6031
> URL: https://issues.apache.org/jira/browse/SLING-6031
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Stefan Seifert
> Fix For: JUnit Tests Teleporter 1.0.8
>
>
> the JUnit TeleporterRule provides a getService method to get OSGi services 
> for the test run. this may return null for services that are not yet started.
> as a workaround some integration tests implement their own "WaitFor" pattern
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/repoinit/it/src/test/java/org/apache/sling/repoinit/it/WaitFor.java
> it should be supported by the teleporter rule directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6031) Teleporter: Wait for Services not ready yet on startup

2016-09-02 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458543#comment-15458543
 ] 

Stefan Seifert commented on SLING-6031:
---

once we have this feature existing integration tests should be migrated:
* repoinit integration tests
* context-aware configuration integration tests

> Teleporter: Wait for Services not ready yet on startup
> --
>
> Key: SLING-6031
> URL: https://issues.apache.org/jira/browse/SLING-6031
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Stefan Seifert
> Fix For: JUnit Tests Teleporter 1.0.8
>
>
> the JUnit TeleporterRule provides a getService method to get OSGi services 
> for the test run. this may return null for services that are not yet started.
> as a workaround some integration tests implement their own "WaitFor" pattern
> https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/repoinit/it/src/test/java/org/apache/sling/repoinit/it/WaitFor.java
> it should be supported by the teleporter rule directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)