[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632285#comment-15632285 ] Robert Munteanu commented on SLING-6112: Changes look good to me, thanks! > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.2.0 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632117#comment-15632117 ] Konrad Windszus commented on SLING-6112: Fixed 2. with [r1767841|https://svn.apache.org/r1767841]. I contributed the new page to the wiki with all information about the incremental build: http://sling.apache.org/documentation/development/ide-tooling/ide-tooling-incremental-build.html. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629496#comment-15629496 ] Konrad Windszus commented on SLING-6112: 1. Agreed and committed with [r1767717|htps://svn.apache.org/r1767717]. 2. Makes sense. We should probably only provide two quickfixes then: a) install m2e-tycho, b) configure plugins accordingly. For b) we should only link to that dedicated subpage explaining how that works for maven-bundle-plugin and bnd-maven-plugin (with according links). I will create an according paragraph in the troubleshooting section (https://sling.apache.org/documentation/development/ide-tooling.html#troubleshooting). > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629268#comment-15629268 ] Robert Munteanu commented on SLING-6112: I've added an integration test for the error marker ( [https://svn.apache.org/r1767696|r1767696], [https://svn.apache.org/r1767697|1767697], [https://svn.apache.org/r1767698|1767698], [https://svn.apache.org/r1767700|1767700] ). I like the way the quick fixes present the option and the documentation links. The only thing I'd tweak a bit is how we present the information to the user. # when the error is presented, it's not immediately discoverable ( at least to me ) that quick fixes are present. Could we maybe add an instruction to launch the quick fix? # I think we may want to add more information in the future to the 'quick fixes' that actually instruct the user to make a manual change. I think we should like to a documentation page where the issues are explained in more detail, together with the references you put up. Not sure if these should be the main IDE tooling page or a sub-page created especially for troubleshooting [~kwin] - WDYT? > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601706#comment-15601706
]
Konrad Windszus commented on SLING-6112:
Since there is no solution available from m2e, we must make sure that our
project configurators call the build action. For that I restricted the project
configurator for the {{maven-bundle-plugin}} to goal {{bundle}} only (and
always leaving the goal {{manifest}}) to the lifecycle mapping of the plugin
itself. For the {{bnd-maven-plugin}} I made sure that our project configurator
always calls the underlying action for incremental builds.
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch,
> SLING-6112-v03.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584776#comment-15584776 ] Robert Munteanu commented on SLING-6112: I tried to find the time but I'm pretty swamped this week and the next. I see no reason to block this change so if you think this is ready just commit it and we can work out the details later :-) > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574870#comment-15574870 ] Konrad Windszus commented on SLING-6112: There is an error marker in each pom.xml which is not setup correctly. This is probably the best way of doing it and Eclipse user's should be familiar with looking at the Problems view and searching for quick fixes in case there are any errors exposed. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574865#comment-15574865 ] Robert Munteanu commented on SLING-6112: OK, let me take a look and see how obvious this is. My worry is that after upgrading and things stop working no one will be looking for the quick fix. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574834#comment-15574834 ] Konrad Windszus commented on SLING-6112: This is exactly what I implemented in the patch v03. There are two quick fixes when such a condition is detected: # Install m2e-tycho through Maven Discovery # Expose a dialog where it is explained how to configure "maven-bundle-plugin" correctly. The patch attached to SLING-6129 will additionally add a 3rd quickfix which explains how to configure "bnd-maven-plugin". > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574818#comment-15574818 ] Robert Munteanu commented on SLING-6112: In my opinion the right thing to do would be to rely on the bnd-maven-plugin and not install the tycho-m2e feature at all. We're stuck with an old version unfortunately. This however comes with the drawback that - we no longer support older versions of the maven-bundle-plugin - we require users to configure newer versions of the maven-bundle-plugin for correct execution which is IMO a blocker at the moment. Not even the Sling project has moved to the bnd-maven-plugin, and we are quite quick to adopt new stuff. So in my opinion what would be good to have is to have this tycho-m2e feature opt-in, rather than mandatory, so that it can be disabled/uninstalled by those who don't want it, but it still works for those who (like me initially) have no idea about old vs new maven-bundle-plugin and why the bnd-maven-plugin is good to go. Not to mention those that can't migrate. Thoughts? > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch, > SLING-6112-v03.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564681#comment-15564681 ] Konrad Windszus commented on SLING-6112: This is indeed expected. With m-b-p 3.2.0 it only works if explicitly configured (http://felix.apache.org/documentation/faqs/apache-felix-bundle-plugin-faq.html#use-scr-metadata-generated-by-bnd-in-unit-tests). For me it is important that m2e-tycho is not necessarily required for Sling IDE (but rather maybe a helpful addition when using m-b-p < 3.2.0, therefore you can always install the extension through Maven Discovery). Also if you use https://github.com/bndtools/bnd/tree/master/maven/bnd-maven-plugin it should work without any problems. We can think about providing an additional warning in case when a configuration is detected which does not automatically generate the MANIFEST.MF, but this is probably a bit tricky to do correctly. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563489#comment-15563489
]
Robert Munteanu commented on SLING-6112:
I've done a quick test of the patch and for me the META-INF/MANIFEST.MF file is
not generated anymore. Here's what I did:
* downloaded Eclipse Neon.1 for Java EE developers
* set up a clean workspace
* installed the locally built Sling IDE Tooling
* created a bundle using the 'Sling Bundle Project' creation wizard . I picked
sling-bundle-archetype version 1.0.4
With the default pom.xml - this includes {{maven-bundle-plugin}} 3.0.0, no
MANIFEST.MF is generated under target. I've also tried updating to
{{maven-bundle-plugin}} 3.2.0, but the problem remains.
Is this expected? If not, can you upload a minimal project which works with
your patch?
I am not sure how
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563478#comment-15563478 ] Robert Munteanu commented on SLING-6112: Ah, I see. I also use it to create a minimal HTML welcome page, so I prefer keeping it when the patch is applied. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563316#comment-15563316
]
Konrad Windszus commented on SLING-6112:
This was initially added with
http://svn.apache.org/viewvc/sling/trunk/tooling/ide/p2update/pom.xml?r1=1506951&r2=1597782&pathrev=1597782
in the context of SLING-3608. I was assuming you are mainly leveraging that
plugin for the {{associateSites}} feature
(https://github.com/jbosstools/jbosstools-maven-plugins/wiki). Since that is no
longer necessary we probably no longer need to rely on that plugin at all. Feel
free to readd that plugin if you want to actively want to leverage some of its
other features.
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563272#comment-15563272 ] Robert Munteanu commented on SLING-6112: Quick question: why did you remove the generate-faced execution from tooling/ide/p2update/pom.xml ? > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1098#comment-1098 ] Konrad Windszus commented on SLING-6112: No problem, just test with the new patch. It turns out it was me, who introduced the dependency to m2e-tycho back in 2014 (https://issues.apache.org/jira/browse/SLING-3612) > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1065#comment-1065 ] Robert Munteanu commented on SLING-6112: I'll be test this early next week, so if you're not in a rush it should wait until them. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1059#comment-1059
]
Konrad Windszus commented on SLING-6112:
There seems to be a bug in
https://github.com/apache/sling/blob/trunk/tooling/ide/eclipse-m2e-ui/plugin.xml#L54
in the {{secondaryTo}} attribute. This is supposed to refer to another
configurator id. But the configurator with id {{maven-bundle-plugin}} does just
not exist (neither in m2e nor in m2e-tycho).
What was meant is probably
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/JavaProjectConfigurator.java
(with id="org.eclipse.m2e.jdt.javaConfigurator",
http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.jdt/plugin.xml#n42).
The only question is whether we should stick to the deprecated {{secondaryTo}}
logic or rely on the new {{runsAfter}} being introduced with m2e 1.6
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=449495)?
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Attachments: SLING-6112-v01.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
