[jira] [Commented] (SLING-6328) JSP concurrent compiling issue
[ https://issues.apache.org/jira/browse/SLING-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811129#comment-15811129 ] Carsten Ziegeler commented on SLING-6328: - [~jsedding] Patch itself looks fine, can't tell whether it solves the problem :) > JSP concurrent compiling issue > -- > > Key: SLING-6328 > URL: https://issues.apache.org/jira/browse/SLING-6328 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.1.6 >Reporter: Sameer Charles >Priority: Critical > Attachments: SLING-6328-backported-changes-jsedding.patch > > > At times JSP fails to compile due to duplicate variable error (Duplicate > local variable _jspx_temp0). > This is suppose to be fixed in jasper (within Tomcat) but not in Sling impl. > See https://bz.apache.org/bugzilla/show_bug.cgi?id=45691 > This seems to be the culprit (see line 623) but there might be other issues. > https://github.com/apache/sling/blob/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/compiler/JspUtil.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6328) JSP concurrent compiling issue
[ https://issues.apache.org/jira/browse/SLING-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804944#comment-15804944 ] Julian Sedding commented on SLING-6328: --- I did some research on this issue. For the record: it seems Sling JSP is a fork of Jasper 6.0.14 (as indicated by other dependencies of the module with the same version). The commit to fix the above mentioned [bugzilla issue #45691|https://bz.apache.org/bugzilla/show_bug.cgi?id=45691] is [r707745|http://svn.apache.org/r707745], which was first released with Jasper 6.0.19 and should thus be fairly close to our fork. > JSP concurrent compiling issue > -- > > Key: SLING-6328 > URL: https://issues.apache.org/jira/browse/SLING-6328 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.1.6 >Reporter: Sameer Charles >Priority: Critical > > At times JSP fails to compile due to duplicate variable error (Duplicate > local variable _jspx_temp0). > This is suppose to be fixed in jasper (within Tomcat) but not in Sling impl. > See https://bz.apache.org/bugzilla/show_bug.cgi?id=45691 > This seems to be the culprit (see line 623) but there might be other issues. > https://github.com/apache/sling/blob/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/compiler/JspUtil.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6328) JSP concurrent compiling issue
[ https://issues.apache.org/jira/browse/SLING-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695278#comment-15695278 ] Felix Meschberger commented on SLING-6328: -- [~rombert] According to the bug referenced this is a concurrency issue which should be pretty easy to analyse statically. > JSP concurrent compiling issue > -- > > Key: SLING-6328 > URL: https://issues.apache.org/jira/browse/SLING-6328 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.1.6 >Reporter: Sameer Charles >Priority: Critical > > At times JSP fails to compile due to duplicate variable error (Duplicate > local variable _jspx_temp0). > This is suppose to be fixed in jasper (within Tomcat) but not in Sling impl. > See https://bz.apache.org/bugzilla/show_bug.cgi?id=45691 > This seems to be the culprit (see line 623) but there might be other issues. > https://github.com/apache/sling/blob/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/compiler/JspUtil.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6328) JSP concurrent compiling issue
[ https://issues.apache.org/jira/browse/SLING-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695219#comment-15695219 ] Robert Munteanu commented on SLING-6328: Thanks for the report. This isn't my area of expertise, but I'm sure whoever picks this up would like to know more about the steps to reproduce. > JSP concurrent compiling issue > -- > > Key: SLING-6328 > URL: https://issues.apache.org/jira/browse/SLING-6328 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.1.6 >Reporter: Sameer Charles >Priority: Critical > > At times JSP fails to compile due to duplicate variable error (Duplicate > local variable _jspx_temp0). > This is suppose to be fixed in jasper (within Tomcat) but not in Sling impl. > See https://bz.apache.org/bugzilla/show_bug.cgi?id=45691 > This seems to be the culprit (see line 623) but there might be other issues. > https://github.com/apache/sling/blob/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/compiler/JspUtil.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
