[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818508#comment-15818508 ] Julian Reschke commented on SLING-6352: --- FWIW, Sling should now switch to Jackrabbit 2.14.0 throughout. (ping [~cziegeler]) > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754165#comment-15754165 ] Carsten Ziegeler commented on SLING-6352: - Or in other words, jcr.davex needs these packages: org.apache.jackrabbit.server org.apache.jackrabbit.server.remoting.davex org.apache.jackrabbit.webdav.util and jcr.webdav: org.apache.jackrabbit.server org.apache.jackrabbit.server.io org.apache.jackrabbit.webdav org.apache.jackrabbit.webdav.property org.apache.jackrabbit.webdav.simple org.apache.jackrabbit.util > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753947#comment-15753947 ] Carsten Ziegeler commented on SLING-6352: - I think I started the whole thing wrong, it's not that important what is embedded it's more important to look at what is directly used. So jcr.davex is importing: import org.apache.jackrabbit.server.SessionProvider; import org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet; import org.apache.jackrabbit.webdav.util.CSRFUtil; and jcr.webdav is importing: import org.apache.jackrabbit.server.SessionProvider; import org.apache.jackrabbit.server.io.CopyMoveContext; import org.apache.jackrabbit.server.io.CopyMoveHandler; import org.apache.jackrabbit.server.io.CopyMoveManager; import org.apache.jackrabbit.server.io.CopyMoveManagerImpl; import org.apache.jackrabbit.server.io.DefaultHandler; import org.apache.jackrabbit.server.io.DeleteContext; import org.apache.jackrabbit.server.io.DeleteHandler; import org.apache.jackrabbit.server.io.DeleteManager; import org.apache.jackrabbit.server.io.DeleteManagerImpl; import org.apache.jackrabbit.server.io.DirListingExportHandler; import org.apache.jackrabbit.server.io.ExportContext; import org.apache.jackrabbit.server.io.IOHandler; import org.apache.jackrabbit.server.io.IOManager; import org.apache.jackrabbit.server.io.IOManagerImpl; import org.apache.jackrabbit.server.io.ImportContext; import org.apache.jackrabbit.server.io.PropertyHandler; import org.apache.jackrabbit.server.io.PropertyHandler; import org.apache.jackrabbit.server.io.PropertyManager; import org.apache.jackrabbit.server.io.PropertyManagerImpl; import org.apache.jackrabbit.server.io.PropertyExportContext; import org.apache.jackrabbit.server.io.PropertyHandler; import org.apache.jackrabbit.server.io.PropertyImportContext; import org.apache.jackrabbit.webdav.DavException; import org.apache.jackrabbit.webdav.DavLocatorFactory; import org.apache.jackrabbit.webdav.DavResource; import org.apache.jackrabbit.webdav.DavResourceLocator; import org.apache.jackrabbit.webdav.WebdavRequest; import org.apache.jackrabbit.webdav.WebdavResponse; import org.apache.jackrabbit.webdav.property.PropEntry; import org.apache.jackrabbit.webdav.simple.DefaultItemFilter; import org.apache.jackrabbit.webdav.simple.ItemFilter; import org.apache.jackrabbit.webdav.simple.ResourceConfig; import org.apache.jackrabbit.webdav.simple.SimpleWebdavServlet; import org.apache.jackrabbit.util.Text; > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751780#comment-15751780 ] Carsten Ziegeler commented on SLING-6352: - [~julian.resc...@gmx.de] Well it might be that there is an artifact that exports those packages, but looking at Sling's launchpad or AEM's quickstart, this bundle is not deployed there. So the repository implementation seems to embedd this stuff as well > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[
https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751752#comment-15751752
]
Julian Reschke commented on SLING-6352:
---
Let's do this step-by-step :-).
{noformat}
jackrabbit-jcr-server/target/jackrabbit-jcr-server-2.13.7-SNAPSHOT.jar
Bundle-Version: 2.13.7.SNAPSHOT
org.apache.jackrabbit.server;version="1.0";uses:="javax.jcr,javax.servlet,javax.servlet.http"
{noformat}
So org.apache.jackrabbit.server *is* exported, but
org.apache.jackrabbit.server.jcr,
org.apache.jackrabbit.server.remoting.davex and
org.apache.jackrabbit.server.util are not.
Would it be possible to stop embedding org.apache.jackrabbit.server right now,
or is that pointless as long as sub-packages are not exported? [~anchela]: any
idea why those are not supported?
> do not use unstable Jackrabbit releases
> ---
>
> Key: SLING-6352
> URL: https://issues.apache.org/jira/browse/SLING-6352
> Project: Sling
> Issue Type: Task
> Components: JCR
>Reporter: Julian Reschke
>
> bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test
> release from an unstable branch.
> Please either change this to the latest stable release (2.12.*), or wait for
> 2.14 to be released (track using JCR-4071).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751719#comment-15751719 ] Carsten Ziegeler commented on SLING-6352: - [~fmeschbe] afaik, the jackrabbit bundles are not exporting these packages > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751637#comment-15751637 ] Julian Reschke commented on SLING-6352: --- cc [~anchela] If this is just for historic reasons (we never got to it), then we should improve things so it's not necessary anymore in Sling (because that clearly causes additional work every time we change something, in particular when related to security fixes). If there is a good reason for *not* doing this, then at least document it here... > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751551#comment-15751551 ] Felix Meschberger commented on SLING-6352: -- To be honest, I don't exactly remember why we chose embedding. It may be that when we began with these bundles, the Jackrabbit libraries have not been proper bundles. There may have been other/more reasons. If now the Jackrabbit libraries are proper bundles with usable package exports, it might be worth a try to not embed any more. > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6352) do not use unstable Jackrabbit releases
[ https://issues.apache.org/jira/browse/SLING-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751534#comment-15751534 ] Carsten Ziegeler commented on SLING-6352: - JCR Davex is embedding the following packages from jackrabbit: org.apache.jackrabbit.server, org.apache.jackrabbit.server.jcr, org.apache.jackrabbit.server.remoting.davex, org.apache.jackrabbit.server.util, org.apache.jackrabbit.webdav.jcr.* These are not exported by any jackrabbit bundle Similar Sling's JCR Webdav embedds org.apache.jackrabbit.server, org.apache.jackrabbit.webdav.simple, org.apache.jackrabbit.webdav.jcr I assume these are not exported as they are not intended for the public The question is whether we can do anything about this? It would be great if we could avoid embedding. [~fmeschbe], [~julian.resc...@gmx.de] Any ideas/opinions? > do not use unstable Jackrabbit releases > --- > > Key: SLING-6352 > URL: https://issues.apache.org/jira/browse/SLING-6352 > Project: Sling > Issue Type: Task > Components: JCR >Reporter: Julian Reschke > > bundles/jcr/webdav currently references jackrabbit 2.13.1. This is a test > release from an unstable branch. > Please either change this to the latest stable release (2.12.*), or wait for > 2.14 to be released (track using JCR-4071). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
