[jira] [Commented] (SLING-6727) Align accessors in API

2017-03-29 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946948#comment-15946948
 ] 

Konrad Windszus commented on SLING-6727:


Makes sense, fixed in [r1789339|https://svn.apache.org/r1789339].

> Align accessors in API
> --
>
> Key: SLING-6727
> URL: https://issues.apache.org/jira/browse/SLING-6727
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>Assignee: Konrad Windszus
> Fix For: Validation 1.0.0
>
>
> We currently have {{getValidationModel(...)}} and 
> {{getModel(...)}}/{{getModels(...)}}, but should use one or the other.
> Also we should remove _Validated_ from 
> {{ValidationModel#getValidatedResourceType()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6727) Align accessors in API

2017-03-29 Thread Oliver Lietz (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946826#comment-15946826
 ] 

Oliver Lietz commented on SLING-6727:
-

[~kwin], it's the tense which irritates. How about 
{{getValidatingResourceType()}}?

> Align accessors in API
> --
>
> Key: SLING-6727
> URL: https://issues.apache.org/jira/browse/SLING-6727
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>Assignee: Konrad Windszus
> Fix For: Validation 1.0.0
>
>
> We currently have {{getValidationModel(...)}} and 
> {{getModel(...)}}/{{getModels(...)}}, but should use one or the other.
> Also we should remove _Validated_ from 
> {{ValidationModel#getValidatedResourceType()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6727) Align accessors in API

2017-03-29 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946807#comment-15946807
 ] 

Konrad Windszus commented on SLING-6727:


I consistently use now the term validationModel (always with prefix 
{{validation}}) to prevent any mixing up with Sling Models in 
[r1789304|https://svn.apache.org/r1789304].

Regarding {{ValidationModel#getValidatedResourceType()}} I am in favour of 
leaving it like that. IMHO it is clearer that way that this is referring to the 
resource type of the resource to be validated rather than to the resource type 
of the underlying (resource-based) validation model. Also this is in line with 
the property name described for resource-based validation models in 
http://sling.apache.org/documentation/bundles/validation.html#validation-model-resources.

> Align accessors in API
> --
>
> Key: SLING-6727
> URL: https://issues.apache.org/jira/browse/SLING-6727
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, Validation
>Reporter: Oliver Lietz
>Assignee: Konrad Windszus
> Fix For: Validation 1.0.0
>
>
> We currently have {{getValidationModel(...)}} and 
> {{getModel(...)}}/{{getModels(...)}}, but should use one or the other.
> Also we should remove _Validated_ from 
> {{ValidationModel#getValidatedResourceType()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)