[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947047#comment-15947047 ] Carsten Ziegeler commented on SLING-6746: - We should not use the Felix SCR bnd plugin - we should really move away from the Felix SCR annotations. If a project is using these, it can stay with the existing older versions of the parent pom. We should migrate all projects, it really takes not a lot to migrate a project. +1 for banning the scr plugin > Additional execution of maven-bundle-plugin:manifest is blanking out > resources generated by maven-scr-plugin > > > Key: SLING-6746 > URL: https://issues.apache.org/jira/browse/SLING-6746 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 30 >Reporter: Konrad Windszus >Priority: Critical > > The additional execution of maven-bundle-plugin:manifest being added with > SLING-6572 is basically overwriting the service descriptors and metatype > resources which are written with maven-scr-plugin with empty files. Those > empty files finally end up in the bundle. This affects all modules still > leveraging the maven-scr-plugin for generating the service > descriptors/metatype resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947020#comment-15947020 ] Konrad Windszus commented on SLING-6746: Agreed, can you make the according changes in parent? The enforcer rule sounds useful in addition, I would just adjust the message so that it says something like: "maven-scr-plugin is incompatible with the manifest goal of the maven-bundle-plugin. Please either remove Felix SCR annotations completely (and migrate to OSGi annotations which are processed by the maven-bundle-plugin itself) or use the SCR bnd plugin from http://felix.apache.org/documentation/subprojects/apache-felix-maven-scr-plugin/apache-felix-scr-bndtools-use.html; > Additional execution of maven-bundle-plugin:manifest is blanking out > resources generated by maven-scr-plugin > > > Key: SLING-6746 > URL: https://issues.apache.org/jira/browse/SLING-6746 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 30 >Reporter: Konrad Windszus >Priority: Critical > > The additional execution of maven-bundle-plugin:manifest being added with > SLING-6572 is basically overwriting the service descriptors and metatype > resources which are written with maven-scr-plugin with empty files. Those > empty files finally end up in the bundle. This affects all modules still > leveraging the maven-scr-plugin for generating the service > descriptors/metatype resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947012#comment-15947012 ] Stefan Seifert commented on SLING-6746: --- yes, we should remove maven-scr-plugin from parent - and it is not worth investing any effort in making it play together because the is doing all that maven-scr-plugin was doing before. we may even use maven enforcer to ban the maven-scr-plugin from projects updating to this parent pom - example: https://github.com/wcm-io/wcm-io-tooling/blob/develop/maven/aem-global-parent/pom.xml#L158 > Additional execution of maven-bundle-plugin:manifest is blanking out > resources generated by maven-scr-plugin > > > Key: SLING-6746 > URL: https://issues.apache.org/jira/browse/SLING-6746 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 30 >Reporter: Konrad Windszus >Priority: Critical > > The additional execution of maven-bundle-plugin:manifest being added with > SLING-6572 is basically overwriting the service descriptors and metatype > resources which are written with maven-scr-plugin with empty files. Those > empty files finally end up in the bundle. This affects all modules still > leveraging the maven-scr-plugin for generating the service > descriptors/metatype resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947004#comment-15947004 ] Konrad Windszus commented on SLING-6746: This was kind of unexpected. Then we should IMHO completely remove the maven-scr-plugin from the parent if it is now incompatible with other plugin executions. That does not sound like a smooth migration path, therefore I would rather propose to make the maven-bundle-plugin behave more reluctant before it overwrites/blanks out those resources. Do you think this could be done in the maven-bundle-plugin, or does it require a fix from bnd? > Additional execution of maven-bundle-plugin:manifest is blanking out > resources generated by maven-scr-plugin > > > Key: SLING-6746 > URL: https://issues.apache.org/jira/browse/SLING-6746 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 30 >Reporter: Konrad Windszus >Priority: Critical > > The additional execution of maven-bundle-plugin:manifest being added with > SLING-6572 is basically overwriting the service descriptors and metatype > resources which are written with maven-scr-plugin with empty files. Those > empty files finally end up in the bundle. This affects all modules still > leveraging the maven-scr-plugin for generating the service > descriptors/metatype resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[
https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947000#comment-15947000
]
Stefan Seifert commented on SLING-6746:
---
the solution should be to completely remove the maven-scr-plugin and instead
add this bnd plugin to maven bundle plugin:
{noformat}
<_plugin>org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=${project.build.outputDirectory}
{noformat}
and
{code:xml}
org.apache.felix
org.apache.felix.scr.bnd
1.7.2
{code}
as discussed in SLING-6649 this should not go into sling parent, but has to be
defined for those project poms still using scr annotations until they migrate
to osgi annotations (or stick with an older version of sling parent).
> Additional execution of maven-bundle-plugin:manifest is blanking out
> resources generated by maven-scr-plugin
>
>
> Key: SLING-6746
> URL: https://issues.apache.org/jira/browse/SLING-6746
> Project: Sling
> Issue Type: Bug
> Components: General
>Affects Versions: Parent 30
>Reporter: Konrad Windszus
>Priority: Critical
>
> The additional execution of maven-bundle-plugin:manifest being added with
> SLING-6572 is basically overwriting the service descriptors and metatype
> resources which are written with maven-scr-plugin with empty files. Those
> empty files finally end up in the bundle. This affects all modules still
> leveraging the maven-scr-plugin for generating the service
> descriptors/metatype resources.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6746) Additional execution of maven-bundle-plugin:manifest is blanking out resources generated by maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946990#comment-15946990 ] Konrad Windszus commented on SLING-6746: [~sseif...@pro-vision.de] Can you have a look, since you introduced this regression in SLING-6572? > Additional execution of maven-bundle-plugin:manifest is blanking out > resources generated by maven-scr-plugin > > > Key: SLING-6746 > URL: https://issues.apache.org/jira/browse/SLING-6746 > Project: Sling > Issue Type: Bug > Components: General >Affects Versions: Parent 30 >Reporter: Konrad Windszus >Priority: Critical > > The additional execution of maven-bundle-plugin:manifest being added with > SLING-6572 is basically overwriting the service descriptors and metatype > resources which are written with maven-scr-plugin with empty files. Those > empty files finally end up in the bundle. This affects all modules still > leveraging the maven-scr-plugin for generating the service > descriptors/metatype resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
