[jira] [Commented] (SLING-7037) Scheduler does not retain provided name
[ https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119826#comment-16119826 ] Carsten Ziegeler commented on SLING-7037: - Changed in rev 1804510 > Scheduler does not retain provided name > --- > > Key: SLING-7037 > URL: https://issues.apache.org/jira/browse/SLING-7037 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Scheduler 2.6.0 >Reporter: Marcel Reutegger >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: Commons Scheduler 2.6.4 > > Attachments: SLING-7037-test.patch > > > The scheduler does not retain the provided name for the job as introduced in > SLING-5387. > The value returned by the JobDataMap is a generated name that include the > service id. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7037) Scheduler does not retain provided name
[ https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119821#comment-16119821 ] Carsten Ziegeler commented on SLING-7037: - That's a good question - and I was asking myself the same question. I left it there because it has always been like this :) But thinking about it, I guess this is a mistake - and the name should really be used as is. > Scheduler does not retain provided name > --- > > Key: SLING-7037 > URL: https://issues.apache.org/jira/browse/SLING-7037 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Scheduler 2.6.0 >Reporter: Marcel Reutegger >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: Commons Scheduler 2.6.4 > > Attachments: SLING-7037-test.patch > > > The scheduler does not retain the provided name for the job as introduced in > SLING-5387. > The value returned by the JobDataMap is a generated name that include the > service id. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7037) Scheduler does not retain provided name
[ https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119511#comment-16119511 ] Marcel Reutegger commented on SLING-7037: - bq. for whiteboard registered jobs: if a name is part of the properties, this name is used as is for the provided name; the name itself is still made unique using the service id. Why is it made unique with the service id? I understand the service id may not always be the same across cluster nodes, which can result in a situation where a registered job with 'runOn:single' on multiple cluster nodes does not run at all. If I provide a name, shouldn't the scheduler use it as is? > Scheduler does not retain provided name > --- > > Key: SLING-7037 > URL: https://issues.apache.org/jira/browse/SLING-7037 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Scheduler 2.6.0 >Reporter: Marcel Reutegger >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: Commons Scheduler 2.6.4 > > Attachments: SLING-7037-test.patch > > > The scheduler does not retain the provided name for the job as introduced in > SLING-5387. > The value returned by the JobDataMap is a generated name that include the > service id. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7037) Scheduler does not retain provided name
[ https://issues.apache.org/jira/browse/SLING-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118478#comment-16118478 ] Carsten Ziegeler commented on SLING-7037: - Thanks for reporting and your tests [~mreutegg] I've committed a potential solution in rev 1804434 together with your test case and some test cases. The idea is: - for whiteboard registered jobs: if a name is part of the properties, this name is used as is for the provided name; the name itself is still made unique using the service id. - for whiteboard registered jobs: if no name is part of the properties, provided name is null and name will get a generated one (including the service id). - for jobs registered using the api: if a name is provided, this is used as is for the provided name - for jobs registered using the api: if no name is provided, a name is generated and provided name is null > Scheduler does not retain provided name > --- > > Key: SLING-7037 > URL: https://issues.apache.org/jira/browse/SLING-7037 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Scheduler 2.6.0 >Reporter: Marcel Reutegger >Assignee: Carsten Ziegeler >Priority: Minor > Fix For: Commons Scheduler 2.6.4 > > Attachments: SLING-7037-test.patch > > > The scheduler does not retain the provided name for the job as introduced in > SLING-5387. > The value returned by the JobDataMap is a generated name that include the > service id. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
