[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041286#comment-17041286 ] Konrad Windszus commented on SLING-7344: Just for the record: The according Jetty fix is in https://github.com/eclipse/jetty.project/issues/2280. > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361229#comment-16361229 ] Julian Reschke commented on SLING-7344: --- [~justinedelson] - absolutely. Is there already a ticket related to that for Jetty? > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[
https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361002#comment-16361002
]
Justin Edelson commented on SLING-7344:
---
{quote}FWIW, there is no "right" approach for text/json, as that media type is
undefined.
{quote}
Please explain this to the Jetty team.
> Jackson Sling Model Exporter needs correct character encoding
> -
>
> Key: SLING-7344
> URL: https://issues.apache.org/jira/browse/SLING-7344
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Reporter: Chris Millar
>Assignee: Justin Edelson
>Priority: Major
> Fix For: Sling Models Impl 1.4.8
>
> Attachments: observe-1.png, observe-2.png, observe-3.png
>
>
> This is a formal ticket of what [~justinedelson] and I discussed earlier in
> December 2017.
> The Jackson Sling Model Exporter needs to correctly set the character
> encoding so content can be correctly handled. It currently defaults out to
> ISO-8859-1 which makes displaying localized content impossible.
> I have put together a sample project here:
> https://github.com/auniverseaway/sling-exporter-sample
> This will show how the default JSON get servlet correctly handles the
> content, but the Jackson exporter does not. I have also attached screenshots
> of the behaviors to this ticket.
> It sounded like Justin had ideas on where to solve this, so I will defer to
> him on where it should be done. If I can help implement a solution in the
> place you want, let me know. Internally, we cannot use the Jackson Exporter
> until this is fixed, so it's pretty high priority for me to contribute back
> if I can.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358880#comment-16358880 ] Julian Reschke commented on SLING-7344: --- FWIW, there is no "right" approach for text/json, as that media type is undefined. > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358605#comment-16358605 ] Justin Edelson commented on SLING-7344: --- Jetty does the right thing for the text/json content type, just not application/json which is what is used in Sling (and mandated by the RFC). > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358465#comment-16358465 ] Julian Reschke commented on SLING-7344: --- AFAICT, this happens when you feed Strings characters into the servlet API. Does the same happen when writing bytes to the ServletOutputStream? > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358395#comment-16358395 ] Konrad Windszus commented on SLING-7344: IMHO Servlet spec mandates ISO-8859-1 as default charset. > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358369#comment-16358369 ] Justin Edelson commented on SLING-7344: --- [~reschke] the problem is that unless we set the charset in the servlet, Jetty automatically sets the charset to ISO-8859-1. I think (as I said on linked the mailing list thread and above) this is clearly a bug in Jetty which we are just working around here (and in the default GET servlet). > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding
[ https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358007#comment-16358007 ] Julian Reschke commented on SLING-7344: --- FWIW, there is no charset parameter on application/json. Sending it is meaningless. And as of the current JSON spec, JSON labeled as application/json has to be sent as UTF-8 (https://www.greenbytes.de/tech/webdav/rfc8259.html#rfc.section.A) > Jackson Sling Model Exporter needs correct character encoding > - > > Key: SLING-7344 > URL: https://issues.apache.org/jira/browse/SLING-7344 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Chris Millar >Assignee: Justin Edelson >Priority: Major > Fix For: Sling Models Impl 1.4.8 > > Attachments: observe-1.png, observe-2.png, observe-3.png > > > This is a formal ticket of what [~justinedelson] and I discussed earlier in > December 2017. > The Jackson Sling Model Exporter needs to correctly set the character > encoding so content can be correctly handled. It currently defaults out to > ISO-8859-1 which makes displaying localized content impossible. > I have put together a sample project here: > https://github.com/auniverseaway/sling-exporter-sample > This will show how the default JSON get servlet correctly handles the > content, but the Jackson exporter does not. I have also attached screenshots > of the behaviors to this ticket. > It sounded like Justin had ideas on where to solve this, so I will defer to > him on where it should be done. If I can help implement a solution in the > place you want, let me know. Internally, we cannot use the Jackson Exporter > until this is fixed, so it's pretty high priority for me to contribute back > if I can. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
