[jira] [Commented] (SLING-7724) Change scope to QueryServlet dependencies

2018-06-13 Thread Andrei Dulvac (JIRA) 


[ 
https://issues.apache.org/jira/browse/SLING-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510690#comment-16510690
 ] 

Andrei Dulvac commented on SLING-7724:
--

Thanks for the PR! 

> Change scope to QueryServlet dependencies
> -
>
> Key: SLING-7724
> URL: https://issues.apache.org/jira/browse/SLING-7724
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Valentin Olteanu
>Assignee: Andrei Dulvac
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.2.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, all the server-side dependencies for {{QueryServlet}} are listed 
> with {{provided}} in the pom. 
> These dependencies get lost in test bundles that have a dependency to 
> sling.testing.clients, so {{TinyBundles}} fails to create a bundle with 
> {{QueryServlet}}. 
> The dependencies need to be compile-scoped to keep them in the resulting jar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7724) Change scope to QueryServlet dependencies

2018-06-12 Thread Valentin Olteanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/SLING-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509595#comment-16509595
 ] 

Valentin Olteanu commented on SLING-7724:
-

Thanks [~andrei.dulvac] for merging the PR. Could you please also close the 
issue?

> Change scope to QueryServlet dependencies
> -
>
> Key: SLING-7724
> URL: https://issues.apache.org/jira/browse/SLING-7724
> Project: Sling
>  Issue Type: Bug
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.2.0
>Reporter: Valentin Olteanu
>Priority: Major
> Fix For: Apache Sling Testing Clients 1.2.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, all the server-side dependencies for {{QueryServlet}} are listed 
> with {{provided}} in the pom. 
> These dependencies get lost in test bundles that have a dependency to 
> sling.testing.clients, so {{TinyBundles}} fails to create a bundle with 
> {{QueryServlet}}. 
> The dependencies need to be compile-scoped to keep them in the resulting jar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)