[jira] [Commented] (SLING-8110) Take "extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053299#comment-17053299 ] Oliver Lietz commented on SLING-8110: - [~kwin], agree. Thanks, [~bdelacretaz], [~kwin]! > Take "extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.6.0 > > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take "extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053269#comment-17053269 ] Konrad Windszus commented on SLING-8110: The fix version is IMHO not about advertising/marketing. It should just reflect reality. IIUC the only code changes for servlet resource resolver have been done in 2.6.0, therefore the fix version should indicate that. The other changes don't belong to the servlet resolver module itself, but you can easily add additional fix versions e.g. for the servlets annotations once that is done. If 2.6.0 is not mentioned as fix version, it is quite hard to do debugging. > Take "extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.6.6 > > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take "extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053261#comment-17053261 ] Bertrand Delacretaz commented on SLING-8110: I have adjusted the fix version. The status is unchanged from my last comment above, the core of this is implemented in this module but not really usable without the above changes so I suggest not "advertising" it for now. > Take "extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.6.6 > > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take "extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053204#comment-17053204 ] Oliver Lietz commented on SLING-8110: - [~bdelacretaz], [~radu], Can you set the proper status, resolution and fix version? > Take "extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.6.0 > > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take "extensions" service property into account for path-mounted servlets
[
https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031736#comment-17031736
]
Bertrand Delacretaz commented on SLING-8110:
At [commit
cab578f13|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/cab578f13c9c7c2e9479baf7d4bac691e10ace70]
the core of this is implemented.
To finalize this feature I need to also implement the SLING-9055
{{SlingServletPathsStrict}} along with the corresponding OSGi capabilities
changes so that code that uses that annotation requires the appropriate version
of the {{o.a.s.servlets.resolver}} bundle.
> Take "extensions" service property into account for path-mounted servlets
> -
>
> Key: SLING-8110
> URL: https://issues.apache.org/jira/browse/SLING-8110
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> If a Sling Servlet has both _paths_ and _extensions_ service properties,
> currently the _paths_ take over and the _extensions_ are ignored.
> This has caused confusion with users who have set both properties on a
> servlet - my initial thought was to reject such illegal combinations, but a
> colleague rightly notes that it would make sense to honor the _extensions_
> property as well, and only route requests to that servlet if there's a match
> on the extension.
> This requires more analysis, for now I'm just creating this ticket to remind
> us to have another look.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[
https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1747#comment-1747
]
Bertrand Delacretaz commented on SLING-8110:
The discussion is at [1] and my takeaways are:
* Add a module config flag for a default value of the {{strict}} resolver option
* Increase the {{org.apache.sling.servlets.resolver / Version="1.1"}}
capability of this module to {{1.2}} to signal the new, backwards-compatible
behavior.
* Update the Sling OSGi Annotations so to include this new parameter _and_
require that {{1.2 Version}} capability if it is used. This will prevent OSGi
bundles which require this capability from starting
I also created SLING-8936 to improve the test coverage before implementing
this, as the code I need to change is not covered this module's tests.
[1]
https://lists.apache.org/thread.html/202c695070feaacd47c972adee04ae07346dfe33b40a8f00bb0831d7%40%3Cdev.sling.apache.org%3E
> Take *extensions" service property into account for path-mounted servlets
> -
>
> Key: SLING-8110
> URL: https://issues.apache.org/jira/browse/SLING-8110
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> If a Sling Servlet has both _paths_ and _extensions_ service properties,
> currently the _paths_ take over and the _extensions_ are ignored.
> This has caused confusion with users who have set both properties on a
> servlet - my initial thought was to reject such illegal combinations, but a
> colleague rightly notes that it would make sense to honor the _extensions_
> property as well, and only route requests to that servlet if there's a match
> on the extension.
> This requires more analysis, for now I'm just creating this ticket to remind
> us to have another look.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[
https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986974#comment-16986974
]
Bertrand Delacretaz commented on SLING-8110:
I have suggested on our dev list using a new {{sling.servlet.resolution =
strict}} service property to activate the "extensions" and "methods" properties
when resolving path-mounted servlets, to keep backwards compatibility while
enabling the stricter behavior.
I don't think taking "selectors" into account is really useful but that's a
detail, my key concern at this point is how to manage backwards compatibility.
Let's see what people think.
> Take *extensions" service property into account for path-mounted servlets
> -
>
> Key: SLING-8110
> URL: https://issues.apache.org/jira/browse/SLING-8110
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> If a Sling Servlet has both _paths_ and _extensions_ service properties,
> currently the _paths_ take over and the _extensions_ are ignored.
> This has caused confusion with users who have set both properties on a
> servlet - my initial thought was to reject such illegal combinations, but a
> colleague rightly notes that it would make sense to honor the _extensions_
> property as well, and only route requests to that servlet if there's a match
> on the extension.
> This requires more analysis, for now I'm just creating this ticket to remind
> us to have another look.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688089#comment-16688089 ] Konrad Windszus commented on SLING-8110: You can no longer wrongly configure this with the new servlet annotations: https://sling.apache.org/documentation/the-sling-engine/servlets.html#registering-a-servlet-using-java-annotations and https://github.com/apache/sling-org-apache-sling-servlets-annotations. > Take *extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Priority: Minor > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688077#comment-16688077 ] Alex COLLIGNON commented on SLING-8110: --- While I understand the conservative approach and agree it is documented, I recommend logging some warnings (yes, I mean warning log level) when such a configuration is encountered during the servlet registration process. > Take *extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Priority: Minor > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687978#comment-16687978 ] Konrad Windszus commented on SLING-8110: This limitation is clearly mentioned in http://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration and also affects "selectors" and "methods". All those are not taken into account for path based registration of servlets! > Take *extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Priority: Minor > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8110) Take *extensions" service property into account for path-mounted servlets
[ https://issues.apache.org/jira/browse/SLING-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687983#comment-16687983 ] Carsten Ziegeler commented on SLING-8110: - And we should probably leave it like this; it's well documented and if we change this now it might have unwanted side effects > Take *extensions" service property into account for path-mounted servlets > - > > Key: SLING-8110 > URL: https://issues.apache.org/jira/browse/SLING-8110 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Bertrand Delacretaz >Priority: Minor > > If a Sling Servlet has both _paths_ and _extensions_ service properties, > currently the _paths_ take over and the _extensions_ are ignored. > This has caused confusion with users who have set both properties on a > servlet - my initial thought was to reject such illegal combinations, but a > colleague rightly notes that it would make sense to honor the _extensions_ > property as well, and only route requests to that servlet if there's a match > on the extension. > This requires more analysis, for now I'm just creating this ticket to remind > us to have another look. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
