[
https://issues.apache.org/jira/browse/SLING-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908837#comment-16908837
]
Carsten Ziegeler commented on SLING-8640:
-
Thanks [~schaefa] . That's a nice addition.
I already commented on the PR but repeat the comment here:
When it comes to feature selection, I think this mojo should support the same
options as all the other mojos: you can either select a file, a maven
dependency, classifiers etc.
As a parameter you can simply use a FeatureSelectionConfig and inherit from
AbstractIncludingFeatureMojo to get most of the logic you need for this.
This way we maintain a consistent way of configuring the mojos.
We could also think about making it possible to launch several instances,
probably based on different features. In that case a configuration style like
the analyser or aggregate mojo use is more appropriate. But again, that's based
on a subclass of FeatureSelectionConfig and extending
AbstractIncludingFeatureMojo as well
In addition, we should probably make it possible to configure the launcher
version. Otherwise we have to release the slingfeature plugin with every
launcher release
> Add a Feature Launcher Mojo to Sling Feature Maven Plugin
> -
>
> Key: SLING-8640
> URL: https://issues.apache.org/jira/browse/SLING-8640
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.8
>
>
> The final step of creating a Feature Model is to launch it. As this is part
> of that process the launching should be added to this plugin so that a
> project can be launched from a profile or so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
