[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126866#comment-17126866 ] Carsten Ziegeler commented on SLING-9489: - As all of that is metadata, you could add a (boolean) configuration flag for comparing metadata But I would think that by default this should be off > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126859#comment-17126859 ] A. J. David Bosschaert commented on SLING-9489: --- What about Artifact Metadata, aliases and start order? Should these match in the comparison? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123707#comment-17123707 ] A. J. David Bosschaert commented on SLING-9489: --- Thank for the ideas, [~cziegeler] - I'll dive a little deeper into it :) > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120317#comment-17120317 ] Carsten Ziegeler commented on SLING-9489: - Thinking about this a little bit more, I can see some value in an analyser which compares artifacts (I assume the use case is about that): - By default, the analyser compares the bundles, it can be configured with the name of an extension, to compare the artifacts in that extension - if the specified extension does not exist -> error; if the specified extension is not of type artifacts -> error - the analyser can be configured to fail if the artifacts are the same, or if the artifacts differ - not sure what the default should be. This configuration is probably a MODE (instead of a boolean) with the values: - SAME : Passes if the artifacts are the same, including version - SIMILAR : Passes if the artifacts are the same, ignoring version - DIFFER : Passes if the artifacts are different (an artifact with different versions is considered to be different) WDYT? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120233#comment-17120233 ] Carsten Ziegeler commented on SLING-9489: - [~davidb] Yes, an analyser sounds much better; but :) I'm wondering whether this is of general interest or a very special one > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119923#comment-17119923 ] A. J. David Bosschaert commented on SLING-9489: --- [~cziegeler] do you think this functionality would fit as a feature model analyzer? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119725#comment-17119725 ] Carsten Ziegeler commented on SLING-9489: - This sounds like a strange feature for a maven plugin Can't the part which generates code simply call the diff functionality (which is a separate module) and then do whatever is appropriate? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119718#comment-17119718 ] A. J. David Bosschaert commented on SLING-9489: --- The use-case is that sometimes optimizations can be made when certain parts of a feature model are the same. Think of for example processing of an extension. If the extension is the same between 2 feature models you can sometimes save time during the build by only processing it once. Or for example when code is generated from an extension. If 2 extensions are the same between 2 feature models then the same generated code can be shared between them. I looked at the FeaturesDiff mojo and it doesn't seem to fit very well for this use-case. That mojo takes a number of feature models and compares them with older versions of the same feature models. Then it produces a diff feature model for each, i.e. a model that can be applied to the older feature model to get the newer feature model. For the use-case that this issue is about we need to: * compare different feature models (not older versions of the same) * compare only parts, not the whole * generate a build error if there is a difference, no need to generate a diff model I looked at refactoring the FeaturesDiff mojo, but because the use-cases are so different I think it would be cleaner to create a new, separate mojo for this issue here. > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119712#comment-17119712 ] Carsten Ziegeler commented on SLING-9489: - What is the use case? We also already have a diff mojo, maybe this can be extended? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)