[jira] [Commented] (SLING-9512) InternalRequest helper
[
https://issues.apache.org/jira/browse/SLING-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133113#comment-17133113
]
Bertrand Delacretaz commented on SLING-9512:
Thank you for your feedback! I won't address the streaming or multipart aspects
for now as I don't need them for my use cases, but contributions are very
welcome.
I have re-added a {{checkStatus(int ...values)}} method and did some cleanup,
from my point of view I think this is ready for a first release and
streaming/multipart improvements can come later.
> InternalRequest helper
> --
>
> Key: SLING-9512
> URL: https://issues.apache.org/jira/browse/SLING-9512
> Project: Sling
> Issue Type: New Feature
> Components: Servlets
>Affects Versions: Servlet Helpers 1.3.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlet Helpers 1.4.2
>
>
> I'm using internal requests in the GraphQL core and example modules, and
> having a simpler way to set them up would be useful.
> I have created a first version that I will commit soon - feedback is welcome
> as usual.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9512) InternalRequest helper
[ https://issues.apache.org/jira/browse/SLING-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132636#comment-17132636 ] Andreas Schaefer commented on SLING-9512: - Works for me. There are a few things to consider: * streaming the response to a caller instead to reduce memory overhead on big files or images in the response * check multiple status codes * support multipart forms (like for uploads). I had a requirement for that but now solved it otherwise > InternalRequest helper > -- > > Key: SLING-9512 > URL: https://issues.apache.org/jira/browse/SLING-9512 > Project: Sling > Issue Type: New Feature > Components: Servlets >Affects Versions: Servlet Helpers 1.3.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlet Helpers 1.4.2 > > > I'm using internal requests in the GraphQL core and example modules, and > having a simpler way to set them up would be useful. > I have created a first version that I will commit soon - feedback is welcome > as usual. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9512) InternalRequest helper
[ https://issues.apache.org/jira/browse/SLING-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130705#comment-17130705 ] Bertrand Delacretaz commented on SLING-9512: I have implemented a first version in commit 3aa681e - see the [tests|https://github.com/apache/sling-org-apache-sling-servlet-helpers/blob/master/src/test/java/org/apache/sling/servlethelpers/internalrequests/ServletInternalRequestTest.java] for usage examples. > InternalRequest helper > -- > > Key: SLING-9512 > URL: https://issues.apache.org/jira/browse/SLING-9512 > Project: Sling > Issue Type: New Feature > Components: Servlets >Affects Versions: Servlet Helpers 1.3.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlet Helpers 1.4.2 > > > I'm using internal requests in the GraphQL core and example modules, and > having a simpler way to set them up would be useful. > I have created a first version that I will commit soon - feedback is welcome > as usual. -- This message was sent by Atlassian Jira (v8.3.4#803005)
