[ 
https://issues.apache.org/jira/browse/SLING-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2836.
-------------------------------------

    Resolution: Fixed

Thanks for your patch. I've applied it.

While the @Activate annotation is not really necessary as that method is using 
the default method name + signature, @Deactive is required. However, for 
claritiy I added both annotations
                
> Missing @(De)Activate annotations in ReferrerFilter#(de)activate() methods 
> cause Sling Referrer Filter Tab clones
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-2836
>                 URL: https://issues.apache.org/jira/browse/SLING-2836
>             Project: Sling
>          Issue Type: Bug
>          Components: Console
>    Affects Versions: Security 1.0.2
>            Reporter: Simone Tripodi
>            Assignee: Carsten Ziegeler
>             Fix For: Security 1.0.4
>
>         Attachments: SLING-2836.patch
>
>
> As per subject, {{ReferrerFilter#activate()}} and 
> {{ReferrerFilter#deactivate()}} methods are not annotated with {{@Activate}} 
> and {{@Deactivate}} annotations, that causes the _Sling Referrer Filter_ tab 
> in the _Configuration Status_ is cloned.
> I'd assume that it is because the {{ReferrerFilter}} is never deactivated so 
> multiple {{ReferrerFilter}} instances exist.
> Patch is following!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to