[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-4544:
--
Attachment: SLING-4544.patch
Attached is a patch to do the call to {{MessageFormat.format()}} lazily. This
way the cost should only be incurred, if RPT.getMessages() is called, i.e. only
when some logging is done.
[~joelrich], could you test this patch and confirm whether it provides the
expected speedup? Thanks.
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where 1-5% of the rendering time is spent in
MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-4544:
--
Attachment: (was: SLING-4544.patch)
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where 1-5% of the rendering time is spent in
MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-4544:
--
Attachment: SLING-4544.patch
Updated patch to flatten the arguments array to Strings for all complex
objects.
[~fmeschbe] would that address your concerns regarding keeping references to
objects?
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where 1-5% of the rendering time is spent in
MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-4544:
--
Attachment: SLING-4544.patch
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where 1-5% of the rendering time is spent in
MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-4544:
--
Attachment: (was: SLING-4544.patch)
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where 1-5% of the rendering time is spent in
MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Richard updated SLING-4544:
Attachment: Screen Shot 2015-03-25 at 10.42.05.png
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
Attachments: Screen Shot 2015-03-25 at 10.42.05.png
I am profiling an application where up to 5% of the rendering time is spent
in MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
[
https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Richard updated SLING-4544:
Description: I am profiling an application where up to 5% of the rendering
time is spent in MessageFormat.format for SlingRequestProgressTracker.log (see
attached screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster. (was: I am profiling an application where up
to 5% of the rendering time is spent in MessageFormat.format for
SlingRequestProgressTracker.log (see attached screenshot). Since the advanced
capabilities of MessageFormat are not required here, it should be rather easy
to implement a utility which supports {x} as well but is much faster.)
Performance: MessageFormat shouldn't be used for logging in
SlingRequestProgressTracker
---
Key: SLING-4544
URL: https://issues.apache.org/jira/browse/SLING-4544
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.4.0
Reporter: Joel Richard
Labels: performance
I am profiling an application where up to 5% of the rendering time is spent
in MessageFormat.format for SlingRequestProgressTracker.log (see attached
screenshot). Since the advanced capabilities of MessageFormat are not
required here, it should be rather easy to implement a utility which supports
\{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
