[jira] [Updated] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-6112:
---
Attachment: SLING-6112-v03.patch
Attached is a third version of the fix which
# adds markers and according quick fixes in case incremental build is not
correctly set up (with a suggestion to either download m2e-tycho or use
maven-bundle-plugin 3.2.0 with correct configuration)
# fixes a minor glitch with the secondaryTo field
# fixes SLING-6128
# only removes the {{associateSites}} configuration from the
{{generate-repository-facade}} goal of {{repository-utils}}
[~rombert] Please try again and let me know what you think of this patch
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.1.2
>
> Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch,
> SLING-6112-v03.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-6112: --- Attachment: SLING-6112-v02.patch The new version of the patch relies on the default java configurator to be executed before the sling bundle project configurator is being executed. Hopefully this was really the last reference to the m2e-tycho extension which was now removed. > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch, SLING-6112-v02.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6112) Make Sling IDE independent of m2e-tycho
[ https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6112: --- Fix Version/s: Sling Eclipse IDE 1.1.2 > Make Sling IDE independent of m2e-tycho > --- > > Key: SLING-6112 > URL: https://issues.apache.org/jira/browse/SLING-6112 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Sling Eclipse IDE 1.1.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Sling Eclipse IDE 1.1.2 > > Attachments: SLING-6112-v01.patch > > > Currently Sling IDE requires the installation of m2e-tycho. This was being > added in https://issues.apache.org/jira/browse/SLING-3608. Now that the > maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get > rid of that dependency. > This is also important since newer versions of the maven-bundle-plugin > conflict with that extension > (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263). > See also the discussion at > http://www.mail-archive.com/dev@sling.apache.org/msg60112.html. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-6112) Make Sling IDE independent of m2e-tycho
[
https://issues.apache.org/jira/browse/SLING-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-6112:
---
Attachment: SLING-6112-v01.patch
Attached is a patch which removes the dependency of m2e-tycho, removes that
plugin from the target definition and makes sure that "bundle" projects are
setup with the default JDT lifecycle.
The only thing missing is the potentially useful
https://github.com/tesla/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/felix/internal/MavenBundlePluginConfigurator.java
which regenerates the Manifest whenever something changes (does not work
reliably though). This has anyhow been incorporated to
https://issues.apache.org/jira/browse/FELIX-4009 (for goal {{manifest}} and
needs to be explicitly enabled). Therefore I would say, we don't loose much, so
I wouldn't display a warning either here but just rely on full builds for the
Manifest to be generated correctly.
[~rombert] Could you have a look?
> Make Sling IDE independent of m2e-tycho
> ---
>
> Key: SLING-6112
> URL: https://issues.apache.org/jira/browse/SLING-6112
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Attachments: SLING-6112-v01.patch
>
>
> Currently Sling IDE requires the installation of m2e-tycho. This was being
> added in https://issues.apache.org/jira/browse/SLING-3608. Now that the
> maven-bundle-plugin ships with m2e support OOTB (FELIX-4009) we should get
> rid of that dependency.
> This is also important since newer versions of the maven-bundle-plugin
> conflict with that extension
> (https://issues.apache.org/jira/browse/FELIX-4009?focusedCommentId=15192263=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15192263).
> See also the discussion at
> http://www.mail-archive.com/dev@sling.apache.org/msg60112.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
