RE: JcrResourceListenerTest.testDefaultWorkspace failures
And now it works for me as well, thanks!
> -Original Message-
> From: Carsten Ziegeler [mailto:cziege...@apache.org]
> Sent: Friday, August 24, 2012 12:48 PM
> To: dev@sling.apache.org
> Subject: Re: JcrResourceListenerTest.testDefaultWorkspace failures
>
> D'oh - sure, you're absolutely right. I'll fix that :)
>
> Thanks
> Carsten
>
> 2012/8/24 Robert Munteanu :
> > Hi Carsten,
> >
> > I see that the tests on Jenkins pass, but they still fail for me. I
> _think_ that setUp and tearDown are mixed up in the test, shouldn't the
> node types be registered on setUp()?
> >
> > Robert
> >
> > Index:
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/intern
> al/JcrResourceListenerTest.java
> > ===
> > ---
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/intern
> al/JcrResourceListenerTest.java (revision 1376867)
> > +++
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/intern
> al/JcrResourceListenerTest.java (working copy)
> > @@ -50,8 +50,8 @@
> > private String pathToModify;
> >
> > @Override
> > -protected void tearDown() throws Exception {
> > -super.tearDown();
> > +protected void setUp() throws Exception {
> > +super.setUp();
> > RepositoryUtil.startRepository();
> > final Session adminSession =
> RepositoryUtil.getRepository().loginAdministrative(null);
> > RepositoryUtil.registerSlingNodeTypes(adminSession);
> > @@ -59,8 +59,8 @@
> > }
> >
> > @Override
> > -protected void setUp() throws Exception {
> > -super.setUp();
> > +protected void tearDown() throws Exception {
> > +super.tearDown();
> > RepositoryUtil.stopRepository();
> > }
> >
> >> -Original Message-
> >> From: Carsten Ziegeler [mailto:cziege...@apache.org]
> >> Sent: Friday, August 24, 2012 11:46 AM
> >> To: dev@sling.apache.org
> >> Subject: Re: JcrResourceListenerTest.testDefaultWorkspace failures
> >>
> >> Hi Robert,
> >>
> >> thanks for reporting - funnily I've seen this as well and commited
> the
> >> such changes earlier; hopefully I did the right thing.
> >>
> >> Regards
> >> Carsten
> >>
> >> 2012/8/24 Robert Munteanu :
> >> > Hi,
> >> >
> >> > The mentioned test fails on both Jenkins[1] and when trying to run
> it
> >> locally.
> >> >
> >> > Since Jira is down I thought I'd just mention this and also that
> it
> >> can be fixed by simply adding a call to
> >> >
> >> > RepositoryUtil.registerSlingNodeTypes(getSession());
> >> >
> >> > in the test.
> >> >
> >> > Robert
> >> >
> >> > [1]: https://builds.apache.org/job/sling-trunk-
> >>
> 1.5/org.apache.sling$org.apache.sling.jcr.resource/1763/testReport/juni
> >>
> t/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/testDe
> >> faultWorkspace/
> >>
> >>
> >>
> >> --
> >> Carsten Ziegeler
> >> cziege...@apache.org
>
>
>
> --
> Carsten Ziegeler
> cziege...@apache.org
Re: JcrResourceListenerTest.testDefaultWorkspace failures
D'oh - sure, you're absolutely right. I'll fix that :)
Thanks
Carsten
2012/8/24 Robert Munteanu :
> Hi Carsten,
>
> I see that the tests on Jenkins pass, but they still fail for me. I _think_
> that setUp and tearDown are mixed up in the test, shouldn't the node types be
> registered on setUp()?
>
> Robert
>
> Index:
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
> ===
> ---
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
> (revision 1376867)
> +++
> bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
> (working copy)
> @@ -50,8 +50,8 @@
> private String pathToModify;
>
> @Override
> -protected void tearDown() throws Exception {
> -super.tearDown();
> +protected void setUp() throws Exception {
> +super.setUp();
> RepositoryUtil.startRepository();
> final Session adminSession =
> RepositoryUtil.getRepository().loginAdministrative(null);
> RepositoryUtil.registerSlingNodeTypes(adminSession);
> @@ -59,8 +59,8 @@
> }
>
> @Override
> -protected void setUp() throws Exception {
> -super.setUp();
> +protected void tearDown() throws Exception {
> +super.tearDown();
> RepositoryUtil.stopRepository();
> }
>
>> -Original Message-----
>> From: Carsten Ziegeler [mailto:cziege...@apache.org]
>> Sent: Friday, August 24, 2012 11:46 AM
>> To: dev@sling.apache.org
>> Subject: Re: JcrResourceListenerTest.testDefaultWorkspace failures
>>
>> Hi Robert,
>>
>> thanks for reporting - funnily I've seen this as well and commited the
>> such changes earlier; hopefully I did the right thing.
>>
>> Regards
>> Carsten
>>
>> 2012/8/24 Robert Munteanu :
>> > Hi,
>> >
>> > The mentioned test fails on both Jenkins[1] and when trying to run it
>> locally.
>> >
>> > Since Jira is down I thought I'd just mention this and also that it
>> can be fixed by simply adding a call to
>> >
>> > RepositoryUtil.registerSlingNodeTypes(getSession());
>> >
>> > in the test.
>> >
>> > Robert
>> >
>> > [1]: https://builds.apache.org/job/sling-trunk-
>> 1.5/org.apache.sling$org.apache.sling.jcr.resource/1763/testReport/juni
>> t/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/testDe
>> faultWorkspace/
>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziege...@apache.org
--
Carsten Ziegeler
cziege...@apache.org
RE: JcrResourceListenerTest.testDefaultWorkspace failures
Hi Carsten,
I see that the tests on Jenkins pass, but they still fail for me. I _think_
that setUp and tearDown are mixed up in the test, shouldn't the node types be
registered on setUp()?
Robert
Index:
bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
===
---
bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
(revision 1376867)
+++
bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java
(working copy)
@@ -50,8 +50,8 @@
private String pathToModify;
@Override
-protected void tearDown() throws Exception {
-super.tearDown();
+protected void setUp() throws Exception {
+super.setUp();
RepositoryUtil.startRepository();
final Session adminSession =
RepositoryUtil.getRepository().loginAdministrative(null);
RepositoryUtil.registerSlingNodeTypes(adminSession);
@@ -59,8 +59,8 @@
}
@Override
-protected void setUp() throws Exception {
-super.setUp();
+protected void tearDown() throws Exception {
+super.tearDown();
RepositoryUtil.stopRepository();
}
> -Original Message-
> From: Carsten Ziegeler [mailto:cziege...@apache.org]
> Sent: Friday, August 24, 2012 11:46 AM
> To: dev@sling.apache.org
> Subject: Re: JcrResourceListenerTest.testDefaultWorkspace failures
>
> Hi Robert,
>
> thanks for reporting - funnily I've seen this as well and commited the
> such changes earlier; hopefully I did the right thing.
>
> Regards
> Carsten
>
> 2012/8/24 Robert Munteanu :
> > Hi,
> >
> > The mentioned test fails on both Jenkins[1] and when trying to run it
> locally.
> >
> > Since Jira is down I thought I'd just mention this and also that it
> can be fixed by simply adding a call to
> >
> > RepositoryUtil.registerSlingNodeTypes(getSession());
> >
> > in the test.
> >
> > Robert
> >
> > [1]: https://builds.apache.org/job/sling-trunk-
> 1.5/org.apache.sling$org.apache.sling.jcr.resource/1763/testReport/juni
> t/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/testDe
> faultWorkspace/
>
>
>
> --
> Carsten Ziegeler
> cziege...@apache.org
Re: JcrResourceListenerTest.testDefaultWorkspace failures
Hi Robert, thanks for reporting - funnily I've seen this as well and commited the such changes earlier; hopefully I did the right thing. Regards Carsten 2012/8/24 Robert Munteanu : > Hi, > > The mentioned test fails on both Jenkins[1] and when trying to run it locally. > > Since Jira is down I thought I'd just mention this and also that it can be > fixed by simply adding a call to > > RepositoryUtil.registerSlingNodeTypes(getSession()); > > in the test. > > Robert > > [1]: > https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1763/testReport/junit/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/testDefaultWorkspace/ -- Carsten Ziegeler cziege...@apache.org
