Re: svn commit: r1764891 - /sling/trunk/launchpad/builder/set-sling-snapshots.sh

2016-10-14 Thread Bertrand Delacretaz
On Fri, Oct 14, 2016 at 4:12 PM, Robert Munteanu  wrote:
> ...Seems the rat plugin is being pedantic and looking for a license header..

Ah sorry about that, fixed now!

-Bertrand


Re: svn commit: r1764891 - /sling/trunk/launchpad/builder/set-sling-snapshots.sh

2016-10-14 Thread Robert Munteanu
Hi Bertrand,

On Fri, 2016-10-14 at 13:28 +, bdelacre...@apache.org wrote:
> +#!/bin/bash
> +#
> +# EXPERIMENTAL script to remove versions from the
> +# provisioning model lines of Sling artifacts.
> +#

Seems the rat plugin is being pedantic and looking for a license header
:-)

I'm not 100% sure one is required here, but you may want to either add
one or exclude this script from the rat checks.

Robert


Re: svn commit: r1764891 - /sling/trunk/launchpad/builder/set-sling-snapshots.sh

2016-10-14 Thread Carsten Ziegeler
Thanks for taking this up!

I'm just wondering if this wouldn't be something we do in the slingstart
maven plugin instead?
But if the script works, that's fine as well

Regards
Carsten

Bertrand Delacretaz wrote
> Author: bdelacretaz
> Date: Fri Oct 14 13:28:51 2016
> New Revision: 1764891
> 
> URL: http://svn.apache.org/viewvc?rev=1764891=rev
> Log:
> Experimental script to generate an all-snapshots launchpad, for integration 
> tests
> 
> Added:
> sling/trunk/launchpad/builder/set-sling-snapshots.sh   (with props)
> 
> Added: sling/trunk/launchpad/builder/set-sling-snapshots.sh
> URL: 
> http://svn.apache.org/viewvc/sling/trunk/launchpad/builder/set-sling-snapshots.sh?rev=1764891=auto
> ==
> --- sling/trunk/launchpad/builder/set-sling-snapshots.sh (added)
> +++ sling/trunk/launchpad/builder/set-sling-snapshots.sh Fri Oct 14 13:28:51 
> 2016
> @@ -0,0 +1,41 @@
> +#!/bin/bash
> +#
> +# EXPERIMENTAL script to remove versions from the
> +# provisioning model lines of Sling artifacts.
> +#
> +# Meant to create an alternate version of the Sling
> +# launchpad using all the latest snapshots, for 
> +# integration testing in parallel with a stable
> +# versions that uses releases.
> +#
> +# This script modifies provisioning model files under
> +# src/main/provisioning, the changes are NOT
> +# meant to be committed, just meant to build and
> +# deploy an "all snapshots" launchpad jar meant to
> +# be used by the launchpad/testing module.
> +#
> +# To verify the results use
> +# mvn dependency:resolve | grep org.apache.sling
> +#
> +# For some reason currently two modules are not resolved
> +# to snapshots although their versions are correctly removed
> +# in the provisioning model:
> +#
> +# mvn dependency:resolve | grep org.apache.sling | grep -v SNAPSHOT
> +# [INFO] --- maven-dependency-plugin:2.10:resolve (default-cli) @ 
> org.apache.sling.launchpad ---
> +# [INFO]
> org.apache.sling:org.apache.sling.resourceresolver:jar:1.4.18:provided
> +# [INFO]org.apache.sling:org.apache.sling.i18n:jar:2.5.4:provided
> +#
> +
> +function removeSlingVersions() {
> + sed 
> 's/\(org.apache.sling\)\/\(org.apache.sling.*\)\/.*/org.apache.sling\/\2/g' < 
> $1
> +}
> +
> +SRC="src/main/provisioning/*.txt"
> +echo "Removing Sling versions from provisioning model files under $SRC..."
> +for i in $SRC
> +do
> + TMP=/tmp/$ME_$$
> + removeSlingVersions $i > $TMP
> + mv $TMP $i
> +done
> \ No newline at end of file
> 
> Propchange: sling/trunk/launchpad/builder/set-sling-snapshots.sh
> --
> svn:executable = *
> 
> 
> 


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org