Re: requirements for including Sightly into Sling Launchpad

2015-04-06 Thread Oliver Lietz
On Sunday 05 April 2015 21:55:31 Radu Cotescu wrote:
 Hi Robert,

Hi,

 I'm definitely not in favour of snapshot dependencies in the launchpad, so
 we're on the same page here.
 
 What do you mean by tangled dependencies? I know that the launchpad usually
 doesn't contain bundles from contrib so I was thinking about what you're
 suggesting but I just wanted somebody from the PMC to say it.

_contrib_ came to my mind after sending my last mail. What are the plans for 
Sling Start/Launchpad regarding artifacts from contrib? Do we want Sling 
Start/Launchpad to only contain artifacts from bundles onwards and users 
should build their own distributions? Shouldn't be too hard with the new Sling 
Start.

Regards,
O.

 Cheers,
 Radu
 
 On Mon 6 Apr 2015 at 00:46 Robert Munteanu rob...@lmn.ro wrote:
  On Sat, Apr 4, 2015 at 7:19 PM, Radu Cotescu r...@apache.org wrote:
   Hi,
   
   Given the recent improvements of the Sightly implementation from Sling I
   think that having this scripting engine in the launchpad would be a nice
   feature.
  
  Sounds OK to me, as long as we don't introduce SNAPSHOT dependencies,
  as they will not be buildable in the same reactor.
  
  Wouldn't it be clearer though to move sightly and all its dependencies
  to /bundles/? I have a documented uneasy feeling about tangled
  dependencies between our reactor builds.
  
  Cheers,
  
  Robert
  
   What are the requirements for including Sightly into the launchpad? The
   following would be the list of bundles that need to be added
   to launchpad/slingstart/src/main/provisioning/sling.txt:
   
   # xss
   javax.mail/mail/1.4.7
   org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
   # i18n
   org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
   # jcr compiler
   org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 #
  
  contrib/jcr/compiler
  
   # sightly
   org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
   #contrib/scripting/sightly
   org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
   #contrib/scripting/sightly
   org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
   #contrib/scripting/sightly
   
   Cheers,
   Radu
  
  --
  Sent from my (old) computer



Re: requirements for including Sightly into Sling Launchpad

2015-04-06 Thread Robert Munteanu
On Mon, Apr 6, 2015 at 12:55 AM, Radu Cotescu r...@apache.org wrote:

 I'm definitely not in favour of snapshot dependencies in the launchpad, so
 we're on the same page here.

 What do you mean by tangled dependencies? I know that the launchpad usually
 doesn't contain bundles from contrib so I was thinking about what you're
 suggesting but I just wanted somebody from the PMC to say it.

Tangled is probably not the best word, but for now I'd like to avoid
dependencies from contrib in the main build.

I think it's best if we kept 'Sling-internal' dependencies in the same
reactor and SNAPSHOT if needed, as it's the fastest way to get an
up-to-date launchpad and also to run the integration tests.

I've started a different thread about this, my reply to Oliver's email.

Cheers,

Robert


Re: requirements for including Sightly into Sling Launchpad

2015-04-06 Thread Robert Munteanu
On Mon, Apr 6, 2015 at 10:58 AM, Oliver Lietz apa...@oliverlietz.de wrote:
 On Sunday 05 April 2015 21:55:31 Radu Cotescu wrote:
 Hi Robert,

 Hi,

 I'm definitely not in favour of snapshot dependencies in the launchpad, so
 we're on the same page here.

 What do you mean by tangled dependencies? I know that the launchpad usually
 doesn't contain bundles from contrib so I was thinking about what you're
 suggesting but I just wanted somebody from the PMC to say it.

 _contrib_ came to my mind after sending my last mail. What are the plans for
 Sling Start/Launchpad regarding artifacts from contrib? Do we want Sling
 Start/Launchpad to only contain artifacts from bundles onwards and users
 should build their own distributions? Shouldn't be too hard with the new Sling
 Start.

I've started another discussion thread for this, see

/ and /contrib, what goes where and when is stuff 'promoted' and 'demoted' [1]

Robert

[1]: http://sling-dev.markmail.org/thread/74ode3yei62cugxv


Re: requirements for including Sightly into Sling Launchpad

2015-04-05 Thread Robert Munteanu
On Sat, Apr 4, 2015 at 7:19 PM, Radu Cotescu r...@apache.org wrote:
 Hi,

 Given the recent improvements of the Sightly implementation from Sling I
 think that having this scripting engine in the launchpad would be a nice
 feature.

Sounds OK to me, as long as we don't introduce SNAPSHOT dependencies,
as they will not be buildable in the same reactor.

Wouldn't it be clearer though to move sightly and all its dependencies
to /bundles/? I have a documented uneasy feeling about tangled
dependencies between our reactor builds.

Cheers,

Robert


 What are the requirements for including Sightly into the launchpad? The
 following would be the list of bundles that need to be added
 to launchpad/slingstart/src/main/provisioning/sling.txt:

 # xss
 javax.mail/mail/1.4.7
 org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
 # i18n
 org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
 # jcr compiler
 org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 # contrib/jcr/compiler
 # sightly
 org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
 #contrib/scripting/sightly

 Cheers,
 Radu



-- 
Sent from my (old) computer


Re: requirements for including Sightly into Sling Launchpad

2015-04-05 Thread Radu Cotescu
Hi Robert,

I'm definitely not in favour of snapshot dependencies in the launchpad, so
we're on the same page here.

What do you mean by tangled dependencies? I know that the launchpad usually
doesn't contain bundles from contrib so I was thinking about what you're
suggesting but I just wanted somebody from the PMC to say it.

Cheers,
Radu
On Mon 6 Apr 2015 at 00:46 Robert Munteanu rob...@lmn.ro wrote:

 On Sat, Apr 4, 2015 at 7:19 PM, Radu Cotescu r...@apache.org wrote:
  Hi,
 
  Given the recent improvements of the Sightly implementation from Sling I
  think that having this scripting engine in the launchpad would be a nice
  feature.

 Sounds OK to me, as long as we don't introduce SNAPSHOT dependencies,
 as they will not be buildable in the same reactor.

 Wouldn't it be clearer though to move sightly and all its dependencies
 to /bundles/? I have a documented uneasy feeling about tangled
 dependencies between our reactor builds.

 Cheers,

 Robert

 
  What are the requirements for including Sightly into the launchpad? The
  following would be the list of bundles that need to be added
  to launchpad/slingstart/src/main/provisioning/sling.txt:
 
  # xss
  javax.mail/mail/1.4.7
  org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
  # i18n
  org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
  # jcr compiler
  org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 #
 contrib/jcr/compiler
  # sightly
  org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
  #contrib/scripting/sightly
  org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
  #contrib/scripting/sightly
  org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
  #contrib/scripting/sightly
 
  Cheers,
  Radu



 --
 Sent from my (old) computer



requirements for including Sightly into Sling Launchpad

2015-04-04 Thread Radu Cotescu
Hi,

Given the recent improvements of the Sightly implementation from Sling I
think that having this scripting engine in the launchpad would be a nice
feature.

What are the requirements for including Sightly into the launchpad? The
following would be the list of bundles that need to be added
to launchpad/slingstart/src/main/provisioning/sling.txt:

# xss
javax.mail/mail/1.4.7
org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
# i18n
org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
# jcr compiler
org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 # contrib/jcr/compiler
# sightly
org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
#contrib/scripting/sightly
org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
#contrib/scripting/sightly
org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
#contrib/scripting/sightly

Cheers,
Radu


Re: requirements for including Sightly into Sling Launchpad

2015-04-04 Thread Justin Edelson
Hi Radu,
I think you can just go ahead and make this change. As long as there is an
associated JIRA, there has not been a vote required in the past to add
bundles to the launchpad.

Regards,
Justin

On Sat, Apr 4, 2015 at 12:19 PM Radu Cotescu r...@apache.org wrote:

 Hi,

 Given the recent improvements of the Sightly implementation from Sling I
 think that having this scripting engine in the launchpad would be a nice
 feature.

 What are the requirements for including Sightly into the launchpad? The
 following would be the list of bundles that need to be added
 to launchpad/slingstart/src/main/provisioning/sling.txt:

 # xss
 javax.mail/mail/1.4.7
 org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
 # i18n
 org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
 # jcr compiler
 org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 #
 contrib/jcr/compiler
 # sightly
 org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
 #contrib/scripting/sightly

 Cheers,
 Radu



Re: requirements for including Sightly into Sling Launchpad

2015-04-04 Thread Oliver Lietz
On Saturday 04 April 2015 16:19:48 Radu Cotescu wrote:
 Hi,

Hi Radu,

 Given the recent improvements of the Sightly implementation from Sling I
 think that having this scripting engine in the launchpad would be a nice
 feature.
 
 What are the requirements for including Sightly into the launchpad? The
 following would be the list of bundles that need to be added
 to launchpad/slingstart/src/main/provisioning/sling.txt:
 
 # xss
 javax.mail/mail/1.4.7
 org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
 # i18n
 org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
 # jcr compiler
 org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 # contrib/jcr/compiler
 # sightly
 org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
 #contrib/scripting/sightly
 org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
 #contrib/scripting/sightly

as Justin says, go ahead. I had to add the Rhino bundle for the Sightly 
feature also, see SLING-4573. Are you using JavaScript from bundle Scripting 
JavaScript?

Regards,
O.

 Cheers,
 Radu