[VOTE RESULT] Release Apache Sling Resource Resolver 1.5.10

[Carsten Ziegeler]

The vote passed with four binding +1 votes

 Thanks

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Closed] (SLING-6441) NPE while processing mapping events

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6441.
---

> NPE while processing mapping events
> ---
>
> Key: SLING-6441
> URL: https://issues.apache.org/jira/browse/SLING-6441
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.5.10
>
>
> java.lang.NullPointerException: null
>   at 
> java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.doUpdateAlias(MapEntries.java:485)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.updateResource(MapEntries.java:306)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.onChange(MapEntries.java:730)
>   at 
> org.apache.sling.resourceresolver.impl.observation.BasicObservationReporter.reportChanges(BasicObservationReporter.java:210)
>   at 
> org.apache.sling.jcr.resource.internal.JcrResourceListener.onEvent(JcrResourceListener.java:155)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6432) Avoid path parameter parsing with paths containing a dot

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6432.
---

> Avoid path parameter parsing with paths containing a dot
> 
>
> Key: SLING-6432
> URL: https://issues.apache.org/jira/browse/SLING-6432
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.5.10
>
>
> Currently parameter parsing (PathParser) takes place if the path does neither 
> contain a dot nor a semi-colon. However, a path only contains a parameter if 
> there is a semi-colon, so we can reduce the check to just check for a 
> semi-colon and skip parsing regardless whether the path contains a dot or not.
> This is a minor optimization



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6447) Move info about resource providers to bottom of page

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6447.
---

> Move info about resource providers to bottom of page
> 
>
> Key: SLING-6447
> URL: https://issues.apache.org/jira/browse/SLING-6447
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Resource Resolver 1.5.10
>
>
> The form for testing the resource resolution and the mapping is at the top, 
> followed by the list of resource providers and then the mapping information.
> We should move the mapping info on top of the resource providers as they more 
> match the intents of the form



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-6446) Service user not used for web console plugin and mapping

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6446.
---

> Service user not used for web console plugin and mapping
> 
>
> Key: SLING-6446
> URL: https://issues.apache.org/jira/browse/SLING-6446
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Resource Resolver 1.5.10
>
>
> With the switch to use service users for the web console and the mapping, a 
> bug was introduced. Due to this, not the service user's session but an 
> anonymous session is used



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

RE: [VOTE] Release Apache Sling Tenant version 1.1.0

[Stefan Seifert]

+1

[jira] [Created] (SLING-6457) MergedResource's toString does not display properly merged resources' paths

[Krystian Nowak (JIRA)]

Krystian Nowak created SLING-6457:
-

 Summary: MergedResource's toString does not display properly 
merged resources' paths
 Key: SLING-6457
 URL: https://issues.apache.org/jira/browse/SLING-6457
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Resource Merger 1.3.0
Reporter: Krystian Nowak
Priority: Minor


Paths of merged resources are kept in a String array which is accessed by 
_toString_ via _ResourceMetadata metadata_ field which is in fact a String to 
Object map.
Therefore _toString_ method prints 
_this.metadata.get(MergedResourceConstants.METADATA_RESOURCES)_ directly which 
results in an output similar to this:
{noformat}
MergedResource [path=/merged, resources=[Ljava.lang.String;@51920d25]
{noformat}
instead of e.g.:
{noformat}
MergedResource [path=/merged, resources=[/a, /b, /c]]
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6457) MergedResource's toString does not display properly merged resources' paths

[Krystian Nowak (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krystian Nowak updated SLING-6457:
--
Attachment: SLING-6457-krystian.patch

Patch with a proposed fix attached

> MergedResource's toString does not display properly merged resources' paths
> ---
>
> Key: SLING-6457
> URL: https://issues.apache.org/jira/browse/SLING-6457
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.3.0
>Reporter: Krystian Nowak
>Priority: Minor
> Attachments: SLING-6457-krystian.patch
>
>
> Paths of merged resources are kept in a String array which is accessed by 
> _toString_ via _ResourceMetadata metadata_ field which is in fact a String to 
> Object map.
> Therefore _toString_ method prints 
> _this.metadata.get(MergedResourceConstants.METADATA_RESOURCES)_ directly 
> which results in an output similar to this:
> {noformat}
> MergedResource [path=/merged, resources=[Ljava.lang.String;@51920d25]
> {noformat}
> instead of e.g.:
> {noformat}
> MergedResource [path=/merged, resources=[/a, /b, /c]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6223) Impossible to create HTL resource type that starts with a number inside the foldername

[Radu Cotescu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821565#comment-15821565
 ] 

Radu Cotescu commented on SLING-6223:
-

The JSP scripting engine is a totally different scripting engine than the HTL 
one. Furthermore, this issue was addressed by SLING-5787, SLING-6094 and 
SLING-6146.

> Impossible to create HTL resource type that starts with a number inside the 
> foldername
> --
>
> Key: SLING-6223
> URL: https://issues.apache.org/jira/browse/SLING-6223
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.2
>Reporter: Roy Teeuwen
>Priority: Critical
>
> We have versioned resource types in folders concerning the release date. For 
> example /apps/myapp/1702/components/mycomponent
> Now when switching from jsp to HTL, we get following exception:
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> Compilation errors in 
> apps/myapp/1702/components/mycomponent/SightlyJava_main.java:
> Line 19, column 971 : The declared package "apps.myapp" does not match the 
> expected package "apps.myapp.1702.components.mycomponent"
> Line 19, column 981 : Syntax error on token ".1702", delete this token
> at 
> org.apache.sling.scripting.sightly.impl.compiler.SightlyJavaCompilerService.compileSource(SightlyJavaCompilerService.java:143)
> I guess this is because it translates the folders to package names, and 1702 
> is not a valid package identifier, but why isn’t it throwing this exception 
> then in all the already existing jsp components?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Apache Sling Tenant version 1.1.0

[Carsten Ziegeler]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-6223) Impossible to create HTL resource type that starts with a number inside the foldername

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-6223.
-
Resolution: Fixed

> Impossible to create HTL resource type that starts with a number inside the 
> foldername
> --
>
> Key: SLING-6223
> URL: https://issues.apache.org/jira/browse/SLING-6223
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.2
>Reporter: Roy Teeuwen
>Priority: Critical
>
> We have versioned resource types in folders concerning the release date. For 
> example /apps/myapp/1702/components/mycomponent
> Now when switching from jsp to HTL, we get following exception:
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> org.apache.sling.scripting.sightly.impl.compiler.CompilerException: 
> Compilation errors in 
> apps/myapp/1702/components/mycomponent/SightlyJava_main.java:
> Line 19, column 971 : The declared package "apps.myapp" does not match the 
> expected package "apps.myapp.1702.components.mycomponent"
> Line 19, column 981 : Syntax error on token ".1702", delete this token
> at 
> org.apache.sling.scripting.sightly.impl.compiler.SightlyJavaCompilerService.compileSource(SightlyJavaCompilerService.java:143)
> I guess this is because it translates the folders to package names, and 1702 
> is not a valid package identifier, but why isn’t it throwing this exception 
> then in all the already existing jsp components?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6085) resource.getValueMap() to unavailable in Sightly JS-code

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6085:

Affects Version/s: Scripting JavaScript 2.0.2

> resource.getValueMap() to unavailable in Sightly JS-code
> 
>
> Key: SLING-6085
> URL: https://issues.apache.org/jira/browse/SLING-6085
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JavaScript 2.0.2
>Reporter: Feike Visser
>
> In Sightly JS-api you can't use resource.getValueMap() method, looks like it 
> is unavailable.
> There you need to do this workaround to get to the properties
> {code}
> "use strict";
> use(function () {
> var parent = resource.getParent();
> var props = 
> parent.adaptTo(Packages.org.apache.sling.api.resource.ValueMap);
> return props.get("jcr:createdBy","");
> });
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6085) resource.getValueMap() to unavailable in Sightly JS-code

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6085:

Fix Version/s: Scripting JavaScript 2.0.32

> resource.getValueMap() to unavailable in Sightly JS-code
> 
>
> Key: SLING-6085
> URL: https://issues.apache.org/jira/browse/SLING-6085
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JavaScript 2.0.2
>Reporter: Feike Visser
> Fix For: Scripting JavaScript 2.0.32
>
>
> In Sightly JS-api you can't use resource.getValueMap() method, looks like it 
> is unavailable.
> There you need to do this workaround to get to the properties
> {code}
> "use strict";
> use(function () {
> var parent = resource.getParent();
> var props = 
> parent.adaptTo(Packages.org.apache.sling.api.resource.ValueMap);
> return props.get("jcr:createdBy","");
> });
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-6458) Java 8 features (lambdas, method references, etc) are not supported

[Henry Kuijpers (JIRA)]

Henry Kuijpers created SLING-6458:
-

 Summary: Java 8 features (lambdas, method references, etc) are not 
supported
 Key: SLING-6458
 URL: https://issues.apache.org/jira/browse/SLING-6458
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP 2.2.2, Scripting JSP 2.2.0, Scripting JSP 
2.1.8, Scripting JSP 2.1.6, Scripting JSP 2.1.4, Scripting JSP 2.1.0, Scripting 
JSP 2.0.28, Scripting JSP 2.2.4, Scripting JSP 2.2.6
 Environment: AEM 5.6.1 SP2, AEM 6.1 SP1, AEM 6.2
Reporter: Henry Kuijpers


When trying to use Java 8 functionality in a JSP file, the Jasper framework in 
the Sling Scripting bundle fails to compile the JSP file. It seems to get stuck 
on a Java 8 feature: Lambdas.
{code}
<%@page session="false" %>
<%@ page import="java.util.stream.IntStream" %>
<%@ page import="java.io.IOException" %>
<%
out.println("Lambda test");
IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
final JspWriter out2 = out;
leip.forEach(x -> {
try {
out2.println(x);
} catch (IOException e) {
// Intentionally do nothing
}
});
%>
{code}
When we remove the complete "leip.forEach" statement, the code compiles and 
executes successfully.

Upon further investigation, I found out that the Jasper compiler that is being 
used, does not have support for "tag 18", which seems to be the lambda feature 
in Java 8.
I could find the constant pool tags over here: 
https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.

I could find a bug report for Tomcat (where Jasper is developed) over here: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
It seems that the issue was fixed in a newer version of Jasper, namely 6.0.40. 
We are currently using 6.0.14 (which is in Apache Sling Scripting JSP version 
bundle version 2.1.4). 

I tried looking at 
https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
 but for some reason all newer versions are also embedding Jasper 6.0.14 (which 
does not support Java 8) and in the custom code inside that bundle I also do 
not see any cases for 18 in the switch statement in 
SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look like 
this fix: https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff

See below a stacktrace of what's happening:
{code}
12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/products/somos/en_US/account/sign-up.html HTTP/1.1] 
org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for extension 
html, cannot render resource ResourceWrapper, 
type=test/components/form/actions/register, 
path=/content/products/somos/en_US/account/sign-up/jcr:content/par/start, 
resource=[JcrNodeResource, type=foundation/components/form/start, 
superType=null, 
path=/content/products/somos/en_US/account/sign-up/jcr:content/par/start]
12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/products/somos/en_US/account/sign-up.html HTTP/1.1] 
com.day.cq.wcm.tags.IncludeTag Error while executing script 
/apps/test/components/form/actions/register/post.POST.jsp 
org.apache.sling.api.scripting.ScriptEvaluationException: 
org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile class 
for JSP
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
at 
org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:102)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:524)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:361)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingS

[jira] [Updated] (SLING-6458) Java 8 features (lambdas, method references, etc) are not supported

[Henry Kuijpers (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Kuijpers updated SLING-6458:
--
Description: 
When trying to use Java 8 functionality in a JSP file, the Jasper framework in 
the Sling Scripting bundle fails to compile the JSP file. It seems to get stuck 
on a Java 8 feature: Lambdas.
{code}
<%@page session="false" %>
<%@ page import="java.util.stream.IntStream" %>
<%@ page import="java.io.IOException" %>
<%
out.println("Lambda test");
IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
final JspWriter out2 = out;
leip.forEach(x -> {
try {
out2.println(x);
} catch (IOException e) {
// Intentionally do nothing
}
});
%>
{code}
When we remove the complete "leip.forEach" statement, the code compiles and 
executes successfully.

Upon further investigation, I found out that the Jasper compiler that is being 
used, does not have support for "tag 18", which seems to be the lambda feature 
in Java 8.
I could find the constant pool tags over here: 
https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.

I could find a bug report for Tomcat (where Jasper is developed) over here: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
It seems that the issue was fixed in a newer version of Jasper, namely 6.0.40. 
We are currently using 6.0.14 (which is in Apache Sling Scripting JSP version 
bundle version 2.1.4). 

I tried looking at 
https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
 but for some reason all newer versions are also embedding Jasper 6.0.14 (which 
does not support Java 8) and in the custom code inside that bundle I also do 
not see any cases for 18 in the switch statement in 
SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look like 
this fix: https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff

See below a stacktrace of what's happening:
{code}
12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/products/somos/en_US/account/sign-up.html HTTP/1.1] 
org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for extension 
html, cannot render resource ResourceWrapper, 
type=test/components/form/actions/register, 
path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
type=foundation/components/form/start, superType=null, 
path=/content/page/sign-up/jcr:content/par/start]
12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/products/somos/en_US/account/sign-up.html HTTP/1.1] 
com.day.cq.wcm.tags.IncludeTag Error while executing script 
/apps/test/components/form/actions/register/post.POST.jsp 
org.apache.sling.api.scripting.ScriptEvaluationException: 
org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile class 
for JSP
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
at 
org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:102)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:524)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:361)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:508)
at 
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:45)
... filters ommitted for brevity ...
at 
com.day.j2ee.servletengine.RequestDispatcherImpl.doFilter(RequestDispatcherImpl.java:321)
at 
com.day.j2ee.servletengine.RequestDispatcherImpl.service(RequestDispatcherImpl.java:340)
at 
com.day

[jira] [Updated] (SLING-6458) Java 8 features (lambdas, method references, etc) are not supported

[Henry Kuijpers (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Kuijpers updated SLING-6458:
--
Description: 
When trying to use Java 8 functionality in a JSP file, the Jasper framework in 
the Sling Scripting bundle fails to compile the JSP file. It seems to get stuck 
on a Java 8 feature: Lambdas.
{code}
<%@page session="false" %>
<%@ page import="java.util.stream.IntStream" %>
<%@ page import="java.io.IOException" %>
<%
out.println("Lambda test");
IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
final JspWriter out2 = out;
leip.forEach(x -> {
try {
out2.println(x);
} catch (IOException e) {
// Intentionally do nothing
}
});
%>
{code}
When we remove the complete "leip.forEach" statement, the code compiles and 
executes successfully.

Upon further investigation, I found out that the Jasper compiler that is being 
used, does not have support for "tag 18", which seems to be the lambda feature 
in Java 8.
I could find the constant pool tags over here: 
https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.

I could find a bug report for Tomcat (where Jasper is developed) over here: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
It seems that the issue was fixed in a newer version of Jasper, namely 6.0.40. 
We are currently using 6.0.14 (which is in Apache Sling Scripting JSP version 
bundle version 2.1.4). 

I tried looking at 
https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
 but for some reason all newer versions are also embedding Jasper 6.0.14 (which 
does not support Java 8) and in the custom code inside that bundle I also do 
not see any cases for 18 in the switch statement in 
SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look like 
this fix: https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff

See below a stacktrace of what's happening:
{code}
12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/page/sign-up.html HTTP/1.1] 
org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for extension 
html, cannot render resource ResourceWrapper, 
type=test/components/form/actions/register, 
path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
type=foundation/components/form/start, superType=null, 
path=/content/page/sign-up/jcr:content/par/start]
12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
/content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error while 
executing script /apps/test/components/form/actions/register/post.POST.jsp 
org.apache.sling.api.scripting.ScriptEvaluationException: 
org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile class 
for JSP
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
at 
org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
at 
org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:102)
at 
org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:524)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:361)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:508)
at 
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:45)
... filters ommitted for brevity ...
at 
com.day.j2ee.servletengine.RequestDispatcherImpl.doFilter(RequestDispatcherImpl.java:321)
at 
com.day.j2ee.servletengine.RequestDispatcherImpl.service(RequestDispatcherImpl.java:340)
at 
com.day.j2ee.servletengine.RequestDispatcherImpl.service

[jira] [Updated] (SLING-6458) JSP scripting does not support Java 8 features (lambdas, method references, etc)

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-6458:
---
Summary: JSP scripting does not support Java 8 features (lambdas, method 
references, etc)  (was: Java 8 features (lambdas, method references, etc) are 
not supported)

> JSP scripting does not support Java 8 features (lambdas, method references, 
> etc)
> 
>
> Key: SLING-6458
> URL: https://issues.apache.org/jira/browse/SLING-6458
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.28, Scripting JSP 2.1.0, Scripting JSP 
> 2.1.4, Scripting JSP 2.1.6, Scripting JSP 2.1.8, Scripting JSP 2.2.0, 
> Scripting JSP 2.2.2, Scripting JSP 2.2.4, Scripting JSP 2.2.6
> Environment: AEM 5.6.1 SP2, AEM 6.1 SP1, AEM 6.2
>Reporter: Henry Kuijpers
>
> When trying to use Java 8 functionality in a JSP file, the Jasper framework 
> in the Sling Scripting bundle fails to compile the JSP file. It seems to get 
> stuck on a Java 8 feature: Lambdas.
> {code}
> <%@page session="false" %>
> <%@ page import="java.util.stream.IntStream" %>
> <%@ page import="java.io.IOException" %>
> <%
> out.println("Lambda test");
> IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
> final JspWriter out2 = out;
> leip.forEach(x -> {
> try {
> out2.println(x);
> } catch (IOException e) {
> // Intentionally do nothing
> }
> });
> %>
> {code}
> When we remove the complete "leip.forEach" statement, the code compiles and 
> executes successfully.
> Upon further investigation, I found out that the Jasper compiler that is 
> being used, does not have support for "tag 18", which seems to be the lambda 
> feature in Java 8.
> I could find the constant pool tags over here: 
> https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
> Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.
> I could find a bug report for Tomcat (where Jasper is developed) over here: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
> It seems that the issue was fixed in a newer version of Jasper, namely 
> 6.0.40. We are currently using 6.0.14 (which is in Apache Sling Scripting JSP 
> version bundle version 2.1.4). 
> I tried looking at 
> https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
>  but for some reason all newer versions are also embedding Jasper 6.0.14 
> (which does not support Java 8) and in the custom code inside that bundle I 
> also do not see any cases for 18 in the switch statement in 
> SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look 
> like this fix: 
> https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff
> See below a stacktrace of what's happening:
> {code}
> 12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] 
> org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for 
> extension html, cannot render resource ResourceWrapper, 
> type=test/components/form/actions/register, 
> path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
> type=foundation/components/form/start, superType=null, 
> path=/content/page/sign-up/jcr:content/par/start]
> 12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error 
> while executing script 
> /apps/test/components/form/actions/register/post.POST.jsp 
> org.apache.sling.api.scripting.ScriptEvaluationException: 
> org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile 
> class for JSP
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
> at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
> at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.acce

[jira] [Updated] (SLING-6458) JSP scripting does not support Java 8 features (lambdas, method references, etc)

[Henry Kuijpers (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Kuijpers updated SLING-6458:
--
Environment: (was: AEM 5.6.1 SP2, AEM 6.1 SP1, AEM 6.2)

> JSP scripting does not support Java 8 features (lambdas, method references, 
> etc)
> 
>
> Key: SLING-6458
> URL: https://issues.apache.org/jira/browse/SLING-6458
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.28, Scripting JSP 2.1.0, Scripting JSP 
> 2.1.4, Scripting JSP 2.1.6, Scripting JSP 2.1.8, Scripting JSP 2.2.0, 
> Scripting JSP 2.2.2, Scripting JSP 2.2.4, Scripting JSP 2.2.6
>Reporter: Henry Kuijpers
>
> When trying to use Java 8 functionality in a JSP file, the Jasper framework 
> in the Sling Scripting bundle fails to compile the JSP file. It seems to get 
> stuck on a Java 8 feature: Lambdas.
> {code}
> <%@page session="false" %>
> <%@ page import="java.util.stream.IntStream" %>
> <%@ page import="java.io.IOException" %>
> <%
> out.println("Lambda test");
> IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
> final JspWriter out2 = out;
> leip.forEach(x -> {
> try {
> out2.println(x);
> } catch (IOException e) {
> // Intentionally do nothing
> }
> });
> %>
> {code}
> When we remove the complete "leip.forEach" statement, the code compiles and 
> executes successfully.
> Upon further investigation, I found out that the Jasper compiler that is 
> being used, does not have support for "tag 18", which seems to be the lambda 
> feature in Java 8.
> I could find the constant pool tags over here: 
> https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
> Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.
> I could find a bug report for Tomcat (where Jasper is developed) over here: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
> It seems that the issue was fixed in a newer version of Jasper, namely 
> 6.0.40. We are currently using 6.0.14 (which is in Apache Sling Scripting JSP 
> version bundle version 2.1.4). 
> I tried looking at 
> https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
>  but for some reason all newer versions are also embedding Jasper 6.0.14 
> (which does not support Java 8) and in the custom code inside that bundle I 
> also do not see any cases for 18 in the switch statement in 
> SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look 
> like this fix: 
> https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff
> See below a stacktrace of what's happening:
> {code}
> 12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] 
> org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for 
> extension html, cannot render resource ResourceWrapper, 
> type=test/components/form/actions/register, 
> path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
> type=foundation/components/form/start, superType=null, 
> path=/content/page/sign-up/jcr:content/par/start]
> 12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error 
> while executing script 
> /apps/test/components/form/actions/register/post.POST.jsp 
> org.apache.sling.api.scripting.ScriptEvaluationException: 
> org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile 
> class for JSP
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
> at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
> at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:102)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:524)
> at 

[jira] [Commented] (SLING-6458) JSP scripting does not support Java 8 features (lambdas, method references, etc)

[Felix Meschberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821647#comment-15821647
 ] 

Felix Meschberger commented on SLING-6458:
--

There are two topics here:

* First that we are based on an old and venerable Jasper version. Unfortunately 
we have made some changes to Jasper, that are not integrated upstream (as they 
are Sling specific) so upgrading is not trivial. Nevertheless at one point in 
time we should upgrade to a more recent Jasper version, which my gut tells me 
should rather be from the Tomcat 8 or even Tomcat 9 series.
* Second the compiler converting the Java Code generated by Jasper to Byte 
Code. We are embedding the Eclipse compiler and it looks like that version of 
the Compiler does not support Java 8 (yet).

So, my impression for this issue is, that we basically should be upgrading the 
embedded Eclipse Compiler to the most recent version supporting Java 8 (and 
make sure the source/target version numbers for configuration support Java 8 as 
well)

> JSP scripting does not support Java 8 features (lambdas, method references, 
> etc)
> 
>
> Key: SLING-6458
> URL: https://issues.apache.org/jira/browse/SLING-6458
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.28, Scripting JSP 2.1.0, Scripting JSP 
> 2.1.4, Scripting JSP 2.1.6, Scripting JSP 2.1.8, Scripting JSP 2.2.0, 
> Scripting JSP 2.2.2, Scripting JSP 2.2.4, Scripting JSP 2.2.6
>Reporter: Henry Kuijpers
>
> When trying to use Java 8 functionality in a JSP file, the Jasper framework 
> in the Sling Scripting bundle fails to compile the JSP file. It seems to get 
> stuck on a Java 8 feature: Lambdas.
> {code}
> <%@page session="false" %>
> <%@ page import="java.util.stream.IntStream" %>
> <%@ page import="java.io.IOException" %>
> <%
> out.println("Lambda test");
> IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
> final JspWriter out2 = out;
> leip.forEach(x -> {
> try {
> out2.println(x);
> } catch (IOException e) {
> // Intentionally do nothing
> }
> });
> %>
> {code}
> When we remove the complete "leip.forEach" statement, the code compiles and 
> executes successfully.
> Upon further investigation, I found out that the Jasper compiler that is 
> being used, does not have support for "tag 18", which seems to be the lambda 
> feature in Java 8.
> I could find the constant pool tags over here: 
> https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
> Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.
> I could find a bug report for Tomcat (where Jasper is developed) over here: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
> It seems that the issue was fixed in a newer version of Jasper, namely 
> 6.0.40. We are currently using 6.0.14 (which is in Apache Sling Scripting JSP 
> version bundle version 2.1.4). 
> I tried looking at 
> https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
>  but for some reason all newer versions are also embedding Jasper 6.0.14 
> (which does not support Java 8) and in the custom code inside that bundle I 
> also do not see any cases for 18 in the switch statement in 
> SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look 
> like this fix: 
> https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff
> See below a stacktrace of what's happening:
> {code}
> 12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] 
> org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for 
> extension html, cannot render resource ResourceWrapper, 
> type=test/components/form/actions/register, 
> path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
> type=foundation/components/form/start, superType=null, 
> path=/content/page/sign-up/jcr:content/par/start]
> 12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error 
> while executing script 
> /apps/test/components/form/actions/register/post.POST.jsp 
> org.apache.sling.api.scripting.ScriptEvaluationException: 
> org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile 
> class for JSP
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
> at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.jav

[jira] [Created] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-6459:
---

 Summary: Upgrade Jackrabbit to 2.14.0
 Key: SLING-6459
 URL: https://issues.apache.org/jira/browse/SLING-6459
 Project: Sling
  Issue Type: Task
  Components: JCR, Karaf, Launchpad, Testing
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
Launchpad Builder 9






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-6460) Update Oak to 1.5.17

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-6460:
---

 Summary: Update Oak to 1.5.17
 Key: SLING-6460
 URL: https://issues.apache.org/jira/browse/SLING-6460
 Project: Sling
  Issue Type: Task
  Components: JCR, Karaf, Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Oak Server 1.1.4, Karaf Features 0.2.0, Launchpad 
Builder 9






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6458) JSP scripting does not support Java 8 features (lambdas, method references, etc)

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821681#comment-15821681
 ] 

Carsten Ziegeler commented on SLING-6458:
-

The compiler we use supports Java 8 and our configuration for source/target 
definitely supports Java 8. I know that if you run Sling on Java 8 it will 
generate 1.8 byte code and run fine with it. So I think it's rather the Jasper 
version, the Eclipse compiler we use should be able to handle these things

For reference we use this version of the compiler:
org.eclipse.jdt.core.compiler
ecj
4.5.1


> JSP scripting does not support Java 8 features (lambdas, method references, 
> etc)
> 
>
> Key: SLING-6458
> URL: https://issues.apache.org/jira/browse/SLING-6458
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.28, Scripting JSP 2.1.0, Scripting JSP 
> 2.1.4, Scripting JSP 2.1.6, Scripting JSP 2.1.8, Scripting JSP 2.2.0, 
> Scripting JSP 2.2.2, Scripting JSP 2.2.4, Scripting JSP 2.2.6
>Reporter: Henry Kuijpers
>
> When trying to use Java 8 functionality in a JSP file, the Jasper framework 
> in the Sling Scripting bundle fails to compile the JSP file. It seems to get 
> stuck on a Java 8 feature: Lambdas.
> {code}
> <%@page session="false" %>
> <%@ page import="java.util.stream.IntStream" %>
> <%@ page import="java.io.IOException" %>
> <%
> out.println("Lambda test");
> IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
> final JspWriter out2 = out;
> leip.forEach(x -> {
> try {
> out2.println(x);
> } catch (IOException e) {
> // Intentionally do nothing
> }
> });
> %>
> {code}
> When we remove the complete "leip.forEach" statement, the code compiles and 
> executes successfully.
> Upon further investigation, I found out that the Jasper compiler that is 
> being used, does not have support for "tag 18", which seems to be the lambda 
> feature in Java 8.
> I could find the constant pool tags over here: 
> https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
> Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.
> I could find a bug report for Tomcat (where Jasper is developed) over here: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
> It seems that the issue was fixed in a newer version of Jasper, namely 
> 6.0.40. We are currently using 6.0.14 (which is in Apache Sling Scripting JSP 
> version bundle version 2.1.4). 
> I tried looking at 
> https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
>  but for some reason all newer versions are also embedding Jasper 6.0.14 
> (which does not support Java 8) and in the custom code inside that bundle I 
> also do not see any cases for 18 in the switch statement in 
> SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look 
> like this fix: 
> https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff
> See below a stacktrace of what's happening:
> {code}
> 12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] 
> org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for 
> extension html, cannot render resource ResourceWrapper, 
> type=test/components/form/actions/register, 
> path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
> type=foundation/components/form/start, superType=null, 
> path=/content/page/sign-up/jcr:content/par/start]
> 12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error 
> while executing script 
> /apps/test/components/form/actions/register/post.POST.jsp 
> org.apache.sling.api.scripting.ScriptEvaluationException: 
> org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile 
> class for JSP
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
> at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
> at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.

[jira] [Updated] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6459:

Fix Version/s: JCR Davex 1.3.6
   JCR Webdav 2.3.6

> Upgrade Jackrabbit to 2.14.0
> 
>
> Key: SLING-6459
> URL: https://issues.apache.org/jira/browse/SLING-6459
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Webdav 2.3.6, Karaf Features 0.2.0, Karaf 
> Integration Tests 0.2.0, Launchpad Builder 9, JCR Davex 1.3.6
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6458) JSP scripting does not support Java 8 features (lambdas, method references, etc)

[Felix Meschberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821692#comment-15821692
 ] 

Felix Meschberger commented on SLING-6458:
--

Thanks [~cziegeler]. In this case I stand corrected and it really is about 
topic (1): Update Jasper.

> JSP scripting does not support Java 8 features (lambdas, method references, 
> etc)
> 
>
> Key: SLING-6458
> URL: https://issues.apache.org/jira/browse/SLING-6458
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.28, Scripting JSP 2.1.0, Scripting JSP 
> 2.1.4, Scripting JSP 2.1.6, Scripting JSP 2.1.8, Scripting JSP 2.2.0, 
> Scripting JSP 2.2.2, Scripting JSP 2.2.4, Scripting JSP 2.2.6
>Reporter: Henry Kuijpers
>
> When trying to use Java 8 functionality in a JSP file, the Jasper framework 
> in the Sling Scripting bundle fails to compile the JSP file. It seems to get 
> stuck on a Java 8 feature: Lambdas.
> {code}
> <%@page session="false" %>
> <%@ page import="java.util.stream.IntStream" %>
> <%@ page import="java.io.IOException" %>
> <%
> out.println("Lambda test");
> IntStream leip = IntStream.of(1, 2, 3, 4, 5, 6);
> final JspWriter out2 = out;
> leip.forEach(x -> {
> try {
> out2.println(x);
> } catch (IOException e) {
> // Intentionally do nothing
> }
> });
> %>
> {code}
> When we remove the complete "leip.forEach" statement, the code compiles and 
> executes successfully.
> Upon further investigation, I found out that the Jasper compiler that is 
> being used, does not have support for "tag 18", which seems to be the lambda 
> feature in Java 8.
> I could find the constant pool tags over here: 
> https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4-140 
> Clearly, there is no support for MethodHandle, MethodType, InvokeDynamic.
> I could find a bug report for Tomcat (where Jasper is developed) over here: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=54475 
> It seems that the issue was fixed in a newer version of Jasper, namely 
> 6.0.40. We are currently using 6.0.14 (which is in Apache Sling Scripting JSP 
> version bundle version 2.1.4). 
> I tried looking at 
> https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.scripting.jsp
>  but for some reason all newer versions are also embedding Jasper 6.0.14 
> (which does not support Java 8) and in the custom code inside that bundle I 
> also do not see any cases for 18 in the switch statement in 
> SmapUtil$SDEInstaller.copyConstantPool. Nor do I see any traces that look 
> like this fix: 
> https://bz.apache.org/bugzilla/attachment.cgi?id=31416&action=diff
> See below a stacktrace of what's happening:
> {code}
> 12.01.2017 14:39:19.063 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] 
> org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for 
> extension html, cannot render resource ResourceWrapper, 
> type=test/components/form/actions/register, 
> path=/content/page/sign-up/jcr:content/par/start, resource=[JcrNodeResource, 
> type=foundation/components/form/start, superType=null, 
> path=/content/page/sign-up/jcr:content/par/start]
> 12.01.2017 14:39:19.079 *ERROR* [144.119.190.210 [1484228359038] POST 
> /content/page/sign-up.html HTTP/1.1] com.day.cq.wcm.tags.IncludeTag Error 
> while executing script 
> /apps/test/components/form/actions/register/post.POST.jsp 
> org.apache.sling.api.scripting.ScriptEvaluationException: 
> org.apache.sling.scripting.jsp.jasper.JasperException: Unable to compile 
> class for JSP
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:171)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:463)
> at com.day.cq.wcm.tags.IncludeTag.includeScript(IncludeTag.java:167)
> at com.day.cq.wcm.tags.IncludeTag.doEndTag(IncludeTag.java:87)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:281)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:102)
> at 
> org.apache.sling.sc

[jira] [Updated] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6459:

Fix Version/s: Commons Testing 2.1.2

> Upgrade Jackrabbit to 2.14.0
> 
>
> Key: SLING-6459
> URL: https://issues.apache.org/jira/browse/SLING-6459
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Webdav 2.3.6, Karaf Features 0.2.0, Karaf 
> Integration Tests 0.2.0, Launchpad Builder 9, JCR Davex 1.3.6, Commons 
> Testing 2.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6459.
-
Resolution: Done

[r1778556|https://svn.apache.org/r1778556]
[r1778557|https://svn.apache.org/r1778557]
[r1778558|https://svn.apache.org/r1778558]
[r1778559|https://svn.apache.org/r1778559]
[r1778560|https://svn.apache.org/r1778560]
[r1778561|https://svn.apache.org/r1778561]

> Upgrade Jackrabbit to 2.14.0
> 
>
> Key: SLING-6459
> URL: https://issues.apache.org/jira/browse/SLING-6459
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Webdav 2.3.6, Karaf Features 0.2.0, Karaf 
> Integration Tests 0.2.0, Launchpad Builder 9, JCR Davex 1.3.6, Commons 
> Testing 2.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE] Release Apache Sling Scripting HTL Compiler 1.0.6, Apache Sling Scripting HTL Java Compiler 1.0.8, Apache Sling Scripting HTL Engine 1.0.30, Apache Sling HTL Maven Plugin 1.0.6

[Radu Cotescu]

Hi,

We solved 3 issues in this releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338973
https://issues.apache.org/jira/browse/SLING/fixforversion/12338981
https://issues.apache.org/jira/browse/SLING/fixforversion/12338980
https://issues.apache.org/jira/browse/SLING/fixforversion/12338974

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1621/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1621 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Radu

[jira] [Comment Edited] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821695#comment-15821695
 ] 

Oliver Lietz edited comment on SLING-6459 at 1/13/17 12:08 PM:
---

[r1778556|https://svn.apache.org/r1778556]
[r1778557|https://svn.apache.org/r1778557]
[r1778558|https://svn.apache.org/r1778558]
[r1778559|https://svn.apache.org/r1778559]
[r1778560|https://svn.apache.org/r1778560]
[r1778561|https://svn.apache.org/r1778561]
[r1778565|https://svn.apache.org/r1778565]


was (Author: olli):
[r1778556|https://svn.apache.org/r1778556]
[r1778557|https://svn.apache.org/r1778557]
[r1778558|https://svn.apache.org/r1778558]
[r1778559|https://svn.apache.org/r1778559]
[r1778560|https://svn.apache.org/r1778560]
[r1778561|https://svn.apache.org/r1778561]

> Upgrade Jackrabbit to 2.14.0
> 
>
> Key: SLING-6459
> URL: https://issues.apache.org/jira/browse/SLING-6459
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Webdav 2.3.6, JCR Oak Server 1.1.4, Karaf Features 
> 0.2.0, Karaf Integration Tests 0.2.0, Launchpad Builder 9, JCR Davex 1.3.6, 
> Commons Testing 2.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6459) Upgrade Jackrabbit to 2.14.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6459:

Fix Version/s: JCR Oak Server 1.1.4

> Upgrade Jackrabbit to 2.14.0
> 
>
> Key: SLING-6459
> URL: https://issues.apache.org/jira/browse/SLING-6459
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Webdav 2.3.6, JCR Oak Server 1.1.4, Karaf Features 
> 0.2.0, Karaf Integration Tests 0.2.0, Launchpad Builder 9, JCR Davex 1.3.6, 
> Commons Testing 2.1.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SLING-6457) MergedResource's toString does not display properly merged resources' paths

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-6457:
--

Assignee: Konrad Windszus

> MergedResource's toString does not display properly merged resources' paths
> ---
>
> Key: SLING-6457
> URL: https://issues.apache.org/jira/browse/SLING-6457
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.3.0
>Reporter: Krystian Nowak
>Assignee: Konrad Windszus
>Priority: Minor
> Attachments: SLING-6457-krystian.patch
>
>
> Paths of merged resources are kept in a String array which is accessed by 
> _toString_ via _ResourceMetadata metadata_ field which is in fact a String to 
> Object map.
> Therefore _toString_ method prints 
> _this.metadata.get(MergedResourceConstants.METADATA_RESOURCES)_ directly 
> which results in an output similar to this:
> {noformat}
> MergedResource [path=/merged, resources=[Ljava.lang.String;@51920d25]
> {noformat}
> instead of e.g.:
> {noformat}
> MergedResource [path=/merged, resources=[/a, /b, /c]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6457) MergedResource's toString does not display properly merged resources' paths

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-6457.

   Resolution: Fixed
Fix Version/s: Resource Merger 1.3.2

Applied the patch in [r1778578|https://svn.apache.org/r1778578]. Thanks 
[~krystian] for providing it.

> MergedResource's toString does not display properly merged resources' paths
> ---
>
> Key: SLING-6457
> URL: https://issues.apache.org/jira/browse/SLING-6457
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.3.0
>Reporter: Krystian Nowak
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: Resource Merger 1.3.2
>
> Attachments: SLING-6457-krystian.patch
>
>
> Paths of merged resources are kept in a String array which is accessed by 
> _toString_ via _ResourceMetadata metadata_ field which is in fact a String to 
> Object map.
> Therefore _toString_ method prints 
> _this.metadata.get(MergedResourceConstants.METADATA_RESOURCES)_ directly 
> which results in an output similar to this:
> {noformat}
> MergedResource [path=/merged, resources=[Ljava.lang.String;@51920d25]
> {noformat}
> instead of e.g.:
> {noformat}
> MergedResource [path=/merged, resources=[/a, /b, /c]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6460) Update Oak to 1.5.17

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6460.
-
Resolution: Done

[r1778569|https://svn.apache.org/r1778569]
[r1778570|https://svn.apache.org/r1778570]
[r1778571|https://svn.apache.org/r1778571]

> Update Oak to 1.5.17
> 
>
> Key: SLING-6460
> URL: https://issues.apache.org/jira/browse/SLING-6460
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Karaf, Launchpad
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: JCR Oak Server 1.1.4, Karaf Features 0.2.0, Launchpad 
> Builder 9
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6414) Update Oak to 1.5.15

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6414.
-
Resolution: Done

[r1774918|https://svn.apache.org/r1774918]

> Update Oak to 1.5.15
> 
>
> Key: SLING-6414
> URL: https://issues.apache.org/jira/browse/SLING-6414
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-6415) Update Tika to 1.14

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6415:

Fix Version/s: Launchpad Builder 9

> Update Tika to 1.14
> ---
>
> Key: SLING-6415
> URL: https://issues.apache.org/jira/browse/SLING-6415
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Launchpad Builder 9
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6415) Update Tika to 1.14

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6415.
-
Resolution: Done

[r1774919|https://svn.apache.org/r1774919]
[r1778590|https://svn.apache.org/r1778590]

> Update Tika to 1.14
> ---
>
> Key: SLING-6415
> URL: https://issues.apache.org/jira/browse/SLING-6415
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Launchpad Builder 9
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6413) Update Jackrabbit to 2.13.6

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6413.
-
Resolution: Done

[r1774917|https://svn.apache.org/r1774917]

> Update Jackrabbit to 2.13.6
> ---
>
> Key: SLING-6413
> URL: https://issues.apache.org/jira/browse/SLING-6413
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6136) Remove workaround for KARAF-4760 (FELIX-5261, comments in *.config files)

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6136.
-
Resolution: Done

see SLING-6426

> Remove workaround for KARAF-4760 (FELIX-5261, comments in *.config files)
> -
>
> Key: SLING-6136
> URL: https://issues.apache.org/jira/browse/SLING-6136
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Karaf Distribution 0.2.0, Karaf 
> Configs 0.2.0
>
>
> workaround added in [r1764341|https://svn.apache.org/r1764341] (using cfg 
> format)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (SLING-6412) Update Pax Exam to 4.9.2

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6412.
-
Resolution: Done

[r1774889|https://svn.apache.org/r1774889]

> Update Pax Exam to 4.9.2
> 
>
> Key: SLING-6412
> URL: https://issues.apache.org/jira/browse/SLING-6412
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Karaf Integration Tests 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-6461) Isolate jcr:content with filter.xml include is not pushed to Server

[Andreas Schaefer (JIRA)]

Andreas Schaefer created SLING-6461:
---

 Summary: Isolate jcr:content with filter.xml include is not pushed 
to Server
 Key: SLING-6461
 URL: https://issues.apache.org/jira/browse/SLING-6461
 Project: Sling
  Issue Type: Bug
  Components: Tooling
 Environment: Mac OS X Sierra, Java 1.8, Eclipse Neon.2
Reporter: Andreas Schaefer


If a jcr:content node is included by a filter.xml but not its parent then the 
deployment of the corresponding .content.xml fails and with it its parent node 
becomes a Sling Folder and the jcr:content node is missing.

Assuming we have the following on our file system:

- A folder /etc/designs/base
- A file .content.xml in that folder:


http://sling.apache.org/jcr/sling/1.0"; 
xmlns:cq="http://www.day.com/jcr/cq/1.0"; xmlns:jcr="http://www.jcp.org/jcr/1.0";
jcr:primaryType="cq:Page">



A filter.xml:














Taking out the include filter and replace it with the comment out one below 
makes the deployment work.

Some preliminary investigations revealed that the 
ResourceChangeCommandFactory.getFilterResult() returns
PREREQUISITE instead of ALLOW as the path that is tested is /etc/designs/base 
instead of /etc/designs/base/jcr:content.

Locally I added that code after the filter.filter() call and before the return:

//AS NOTE: If we have a jcr:content and it is limited by an include then it 
might fail
//AS NOTE: (DENY) or worse coming back as PREREQUISITE making an undefined 
node. Here it
//AS NOTE: checks if the resource proxy has a child of jcr:content and if so 
check with
//AS NOTE: that path.
if(filterResult != FilterResult.ALLOW && resourceProxy != null) {
List resourceProxyChildren = resourceProxy.getChildren();
if(resourceProxyChildren.size() == 1) {
ResourceProxy child = resourceProxyChildren.get(0);
if(child.getPath().endsWith("/jcr:content")) {
FilterResult temp = filter.filter(child.getPath());
if(temp == FilterResult.ALLOW) {
return FilterResult.ALLOW;
}
}
}
}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-6462) Filter Isolated jcr:content nodes (by includes) are not deployed

[Andreas Schaefer (JIRA)]

Andreas Schaefer created SLING-6462:
---

 Summary: Filter Isolated jcr:content nodes (by includes) are not 
deployed
 Key: SLING-6462
 URL: https://issues.apache.org/jira/browse/SLING-6462
 Project: Sling
  Issue Type: Bug
  Components: Tooling
 Environment: MacOS Sierra, JDK 1.8, latest Sling
Reporter: Andreas Schaefer


If a jcr:content node is included by a filter.xml but not its parent then the 
deployment of the corresponding .content.xml fails and with it its parent node 
becomes a Sling Folder and the jcr:content node is missing.

Assuming we have the following on our file system:

- A folder /etc/designs/base
- A file .content.xml in that folder:


http://sling.apache.org/jcr/sling/1.0"; 
xmlns:cq="http://www.day.com/jcr/cq/1.0"; xmlns:jcr="http://www.jcp.org/jcr/1.0";
jcr:primaryType="cq:Page">



A filter.xml:














Taking out the include filter and replace it with the comment out one below 
makes the deployment work.

Some preliminary investigations revealed that the 
ResourceChangeCommandFactory.getFilterResult() returns
PREREQUISITE instead of ALLOW as the path that is tested is /etc/designs/base 
instead of /etc/designs/base/jcr:content.

Locally I added that code after the filter.filter() call and before the return:

//AS NOTE: If we have a jcr:content and it is limited by an include then it 
might fail
//AS NOTE: (DENY) or worse coming back as PREREQUISITE making an undefined 
node. Here it
//AS NOTE: checks if the resource proxy has a child of jcr:content and if so 
check with
//AS NOTE: that path.
if(filterResult != FilterResult.ALLOW && resourceProxy != null) {
List resourceProxyChildren = resourceProxy.getChildren();
if(resourceProxyChildren.size() == 1) {
ResourceProxy child = resourceProxyChildren.get(0);
if(child.getPath().endsWith("/jcr:content")) {
FilterResult temp = filter.filter(child.getPath());
if(temp == FilterResult.ALLOW) {
return FilterResult.ALLOW;
}
}
}
}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Andreas Schaefer Sr.]

If tooling is every going to support other IDEs than Eclipse then you should 
not add more Eclipse dependencies
to non Eclipse modules. 

Cheers - Andy Schaefer

> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
> 
> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
>>> On 9 Jan 2017, at 06:00, Robert Munteanu 
>>> wrote:
>>> 
>>> Hi Konrad,
>>> 
>>> On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
 This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
 33.
 Any suggestions which annotation types to use in the Eclipse IDE
 for
 null checks?
 Or would it be fine to build the Sling IDE with target 1.8?
>>> 
>>> I am not opposed to building the IDE tooling with target 1.8 .
>>> First
>>> though, there is a workaround noted in the Eclipse bug:
>>> 
>>>  please make sure that an in projects below 1.8 you reference
>>> version
>>> [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
>>> 
>>> Would that work for our scenario?
>> 
>> I have not tested that, but I just checked that indeed at least
>> Eclipse Neon ships with two different versions of that bundle 1.1.100
>> and 2.1.0 but I am not sure about older and newer versions of
>> Eclipse. I would rather instead upgrade to Java 8, since with Neon
>> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
>> llation).
>> WDYT?
> 
> I for one would switch to Java 8 only if really needed, as I think we
> need to make it as easy as possible to run the IDE tools.
> 
> Are there any developers out there using the IDE Tooling on Java 7? No
> idea. If there's a way to get null checking with Java 7, let's do that.
> Otherwise, feel free to raise a new SLING issue about moving to Java 8
> to track the reasons behind the move and change the requirement to Java
> 8.
> 
> Robert
> 
>> 
>>> 
>>> Robert
>>> 
 Konrad
 
> On 29 Dec 2016, at 18:01, Apache Jenkins Server  .apa
> che.org> wrote:
> 
> See 
> 
> Changes:
> 
> [kwin] SLING-6344 disable syncing if no filter.xml can be found
> 
> simplify FilterLocator service
> 
> --
> [...truncated 899 lines...]
> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> @
> reactor ---
> [INFO] 
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
> descriptor) @ reactor ---
> [INFO] 
> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
> (default) @ reactor ---
> [INFO] 
> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
> [INFO] 72 implicit excludes (use -debug for more details).
> [INFO] Exclude: derby.log
> [INFO] Exclude: .gitignore
> [INFO] Exclude: README.md
> [INFO] Exclude: *.launch
> [INFO] Exclude: build.properties
> [INFO] Exclude: .options
> [INFO] Exclude: META-INF/MANIFEST.MF
> [INFO] Exclude: **/*.binary
> [INFO] Exclude: eclipse-test/**
> [INFO] Exclude: source-bundle/target/**
> [INFO] Exclude: .Xauthority-*
> [INFO] 6 resources included (use -debug for more details)
> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
> sion
> Limit' is not recognized.
> Compiler warnings:
>  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
> 'http://
> javax.xml.XMLConstants/property/accessExternalDTD' is not
> recognized.'
> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
> java
> x.xml.XMLConstants/feature/secure-processing' is not
> recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> /jav
> ax.xml.XMLConstants/property/accessExternalDTD' is not
> recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
> /www
> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
> recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
> generated: 0 approved: 5 licence.
> [JENKINS] Archiving disabled
> [INFO] 
> 
> 
> [INFO] 
> 
> 
> [INFO] Building Sling IDE Tools: Target definition 1.1.1-
> SNAPSHOT
> [INFO] 
> 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
> org.apache.sling.ide.target-definition ---
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
> @
> org.apache.sling.ide.target-definition ---
> [INFO] 
> [INFO] --- tycho-packaging-plugin:0.22.0:package-target-
> definition
> (default-package-target-definition) @
> org.apache.sling.ide.target-
> 

[jira] [Updated] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Nitin Nizhawan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Nizhawan updated SLING-6423:
--
Attachment: SLING-6423_parser_changes.patch

[~bdelacretaz] Attached patch to support ACLOptions syntax in parser. Could you 
please review

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Konrad Windszus]

For the API part I will make sure to not introduce any Eclipse specific 
dependencies.
For the null-check annotations we should probably then rely on JSR-305 
annotations (https://sling.apache.org/documentation/development/jsr-305.html).
Konrad

> On 13 Jan 2017, at 17:10, Andreas Schaefer Sr.  wrote:
> 
> If tooling is every going to support other IDEs than Eclipse then you should 
> not add more Eclipse dependencies
> to non Eclipse modules. 
> 
> Cheers - Andy Schaefer
> 
>> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
>> 
>> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
 On 9 Jan 2017, at 06:00, Robert Munteanu 
 wrote:
 
 Hi Konrad,
 
 On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
> 33.
> Any suggestions which annotation types to use in the Eclipse IDE
> for
> null checks?
> Or would it be fine to build the Sling IDE with target 1.8?
 
 I am not opposed to building the IDE tooling with target 1.8 .
 First
 though, there is a workaround noted in the Eclipse bug:
 
 please make sure that an in projects below 1.8 you reference
 version
 [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
 
 Would that work for our scenario?
>>> 
>>> I have not tested that, but I just checked that indeed at least
>>> Eclipse Neon ships with two different versions of that bundle 1.1.100
>>> and 2.1.0 but I am not sure about older and newer versions of
>>> Eclipse. I would rather instead upgrade to Java 8, since with Neon
>>> Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
>>> llation).
>>> WDYT?
>> 
>> I for one would switch to Java 8 only if really needed, as I think we
>> need to make it as easy as possible to run the IDE tools.
>> 
>> Are there any developers out there using the IDE Tooling on Java 7? No
>> idea. If there's a way to get null checking with Java 7, let's do that.
>> Otherwise, feel free to raise a new SLING issue about moving to Java 8
>> to track the reasons behind the move and change the requirement to Java
>> 8.
>> 
>> Robert
>> 
>>> 
 
 Robert
 
> Konrad
> 
>> On 29 Dec 2016, at 18:01, Apache Jenkins Server > .apa
>> che.org> wrote:
>> 
>> See 
>> 
>> Changes:
>> 
>> [kwin] SLING-6344 disable syncing if no filter.xml can be found
>> 
>> simplify FilterLocator service
>> 
>> --
>> [...truncated 899 lines...]
>> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
>> @
>> reactor ---
>> [INFO] 
>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>> descriptor) @ reactor ---
>> [INFO] 
>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>> (default) @ reactor ---
>> [INFO] 
>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
>> [INFO] 72 implicit excludes (use -debug for more details).
>> [INFO] Exclude: derby.log
>> [INFO] Exclude: .gitignore
>> [INFO] Exclude: README.md
>> [INFO] Exclude: *.launch
>> [INFO] Exclude: build.properties
>> [INFO] Exclude: .options
>> [INFO] Exclude: META-INF/MANIFEST.MF
>> [INFO] Exclude: **/*.binary
>> [INFO] Exclude: eclipse-test/**
>> [INFO] Exclude: source-bundle/target/**
>> [INFO] Exclude: .Xauthority-*
>> [INFO] 6 resources included (use -debug for more details)
>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
>> sion
>> Limit' is not recognized.
>> Compiler warnings:
>> WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
>> 'http://
>> javax.xml.XMLConstants/property/accessExternalDTD' is not
>> recognized.'
>> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://
>> java
>> x.xml.XMLConstants/feature/secure-processing' is not
>> recognized.
>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
>> /jav
>> ax.xml.XMLConstants/property/accessExternalDTD' is not
>> recognized.
>> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http:/
>> /www
>> .oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
>> recognized.
>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
>> generated: 0 approved: 5 licence.
>> [JENKINS] Archiving disabled
>> [INFO] 
>> 
>> 
>> [INFO] 
>> 
>> 
>> [INFO] Building Sling IDE Tools: Target definition 1.1.1-
>> SNAPSHOT
>> [INFO] 
>> 
>> 
>> [INFO] 
>> 

Re: Null checking annotatins for IDE tooling (was: Build failed in Jenkins: sling-ide #88)

[Andreas Schaefer Sr.]

This is not limited to API.

There is the issue with impl-vlt that uses the Activator to obtain the Plugin 
Logger.
IntelliJ for example is not OSGi based and this caused me some headaches (and 
still does).

But there is also code that would be common to IDEs but it is embedded into 
Eclipse
source because it has references to Eclipse objects like the 
ResourceChangeCommandFactory.

A while ago I proposed a set of interfaces that would remove the Eclipse 
dependencies from the
RCCF and hide the IDE specific logic inside the implementations of these 
interfaces.

So far this went nowhere as I don’t know where to find the Eclipse code 
necessary and how to
build and test it properly.

Later I went a step further creating a Deployment Manager that even extracts 
IDE specific
code / classes from methods like SlingLaunchpadBehaviour.publishModule() etc.
The goal was to create a common behavior of the code deployment to AEM in all
IDEs.

Cheers - Andy

> On Jan 13, 2017, at 9:39 AM, Konrad Windszus  wrote:
> 
> For the API part I will make sure to not introduce any Eclipse specific 
> dependencies.
> For the null-check annotations we should probably then rely on JSR-305 
> annotations (https://sling.apache.org/documentation/development/jsr-305.html).
> Konrad
> 
>> On 13 Jan 2017, at 17:10, Andreas Schaefer Sr.  wrote:
>> 
>> If tooling is every going to support other IDEs than Eclipse then you should 
>> not add more Eclipse dependencies
>> to non Eclipse modules. 
>> 
>> Cheers - Andy Schaefer
>> 
>>> On Jan 10, 2017, at 3:24 AM, Robert Munteanu  wrote:
>>> 
>>> On Mon, 2017-01-09 at 09:24 -0500, Konrad Windszus wrote:
> On 9 Jan 2017, at 06:00, Robert Munteanu 
> wrote:
> 
> Hi Konrad,
> 
> On Thu, 2016-12-29 at 19:23 +0100, Konrad Windszus wrote:
>> This is due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=4340
>> 33.
>> Any suggestions which annotation types to use in the Eclipse IDE
>> for
>> null checks?
>> Or would it be fine to build the Sling IDE with target 1.8?
> 
> I am not opposed to building the IDE tooling with target 1.8 .
> First
> though, there is a workaround noted in the Eclipse bug:
> 
> please make sure that an in projects below 1.8 you reference
> version
> [1.1.0,2.0.0) of the annotation bundle (exluding 2.0.0!)
> 
> Would that work for our scenario?
 
 I have not tested that, but I just checked that indeed at least
 Eclipse Neon ships with two different versions of that bundle 1.1.100
 and 2.1.0 but I am not sure about older and newer versions of
 Eclipse. I would rather instead upgrade to Java 8, since with Neon
 Java 8 is anyhow required (see https://wiki.eclipse.org/Eclipse/Insta
 llation).
 WDYT?
>>> 
>>> I for one would switch to Java 8 only if really needed, as I think we
>>> need to make it as easy as possible to run the IDE tools.
>>> 
>>> Are there any developers out there using the IDE Tooling on Java 7? No
>>> idea. If there's a way to get null checking with Java 7, let's do that.
>>> Otherwise, feel free to raise a new SLING issue about moving to Java 8
>>> to track the reasons behind the move and change the requirement to Java
>>> 8.
>>> 
>>> Robert
>>> 
 
> 
> Robert
> 
>> Konrad
>> 
>>> On 29 Dec 2016, at 18:01, Apache Jenkins Server >> .apa
>>> che.org> wrote:
>>> 
>>> See 
>>> 
>>> Changes:
>>> 
>>> [kwin] SLING-6344 disable syncing if no filter.xml can be found
>>> 
>>> simplify FilterLocator service
>>> 
>>> --
>>> [...truncated 899 lines...]
>>> [INFO] --- maven-remote-resources-plugin:1.5:process (default)
>>> @
>>> reactor ---
>>> [INFO] 
>>> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-
>>> descriptor) @ reactor ---
>>> [INFO] 
>>> [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files
>>> (default) @ reactor ---
>>> [INFO] 
>>> [INFO] --- apache-rat-plugin:0.10:check (default) @ reactor ---
>>> [INFO] 72 implicit excludes (use -debug for more details).
>>> [INFO] Exclude: derby.log
>>> [INFO] Exclude: .gitignore
>>> [INFO] Exclude: README.md
>>> [INFO] Exclude: *.launch
>>> [INFO] Exclude: build.properties
>>> [INFO] Exclude: .options
>>> [INFO] Exclude: META-INF/MANIFEST.MF
>>> [INFO] Exclude: **/*.binary
>>> [INFO] Exclude: eclipse-test/**
>>> [INFO] Exclude: source-bundle/target/**
>>> [INFO] Exclude: .Xauthority-*
>>> [INFO] 6 resources included (use -debug for more details)
>>> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser:
>>> Property 'http://www.oracle.com/xml/jaxp/properties/entityExpan
>>> sion
>>> Limit' is not recognized.
>>> Compiler warnings:
>>> WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property
>>>

RE: [VOTE] Release Apache Sling Scripting HTL Compiler 1.0.6, Apache Sling Scripting HTL Java Compiler 1.0.8, Apache Sling Scripting HTL Engine 1.0.30, Apache Sling HTL Maven Plugin 1.0.6

[Stefan Seifert]

+1

[jira] [Updated] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Nitin Nizhawan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Nizhawan updated SLING-6423:
--
Attachment: SLING_6423_testcasesV2.patch

patch SLING_6423_testcasesV2.patch containing updated test cases as per 
{{(ACLOptions=merge)}} syntax

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Nitin Nizhawan (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821973#comment-15821973
 ] 

Nitin Nizhawan edited comment on SLING-6423 at 1/14/17 5:58 AM:


[~bdelacretaz] Attached patch SLING-6423_parser_changes.patch to support 
ACLOptions syntax in parser. Could you please review


was (Author: nitin.nizhawan):
[~bdelacretaz] Attached patch to support ACLOptions syntax in parser. Could you 
please review

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Nitin Nizhawan (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821973#comment-15821973
 ] 

Nitin Nizhawan edited comment on SLING-6423 at 1/14/17 5:58 AM:


[~bdelacretaz] Attached patch SLING\-6423_parser_changes.patch to support 
ACLOptions syntax in parser. Could you please review


was (Author: nitin.nizhawan):
[~bdelacretaz] Attached patch SLING-6423_parser_changes.patch to support 
ACLOptions syntax in parser. Could you please review

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)