[jira] [Created] (SLING-6493) Remove (sub) service user from JcrResourceBundleProvider

2017-01-27 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-6493:
---

 Summary: Remove (sub) service user from JcrResourceBundleProvider
 Key: SLING-6493
 URL: https://issues.apache.org/jira/browse/SLING-6493
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: i18n 2.5.8


{noformat}
2017-01-27T19:22:44,554 | ERROR | pool-30-thread-1 | i18n   
  | 180 - org.apache.sling.i18n - 2.5.6 | 
[org.apache.sling.i18n.impl.JcrResourceBundleProvider(140)] The activate method 
has thrown an exception
org.apache.sling.api.resource.LoginException: Cannot derive user name for 
bundle org.apache.sling.i18n [180] and sub service sling-i18n
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryImpl.getServiceResourceResolver(ResourceResolverFactoryImpl.java:84)
 ~[?:?]
at 
org.apache.sling.i18n.impl.JcrResourceBundleProvider.activate(JcrResourceBundleProvider.java:372)
 ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:?]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
 ~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501) ~[?:?]
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:302) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:294) 
~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:298)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:823)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:347)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:247)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:344) 
~[?:?]
at org.apache.felix.framework.Felix.getService(Felix.java:3699) ~[?:?]
at 
org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:470)
 ~[?:?]
at 
org.apache.sling.resourceresolver.impl.observation.ResourceChangeListenerWhiteboard$1.addingService(ResourceChangeListenerWhiteboard.java:84)
 ~[?:?]
at 
org.apache.sling.resourceresolver.impl.observation.ResourceChangeListenerWhiteboard$1.addingService(ResourceChangeListenerWhiteboard.java:64)
 ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
 ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870)
 ~[?:?]
at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) 
~[?:?]
at 
org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:901)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
 ~[?:?]
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4557) 
~[?:?]
at org.apache.felix.framework.Felix.registerService(Felix.java:3549) 
~[?:?]
at 
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:348)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:887)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:874)
 ~[?:?]
at 

[jira] [Resolved] (SLING-6365) JcrInstaller incorrectly uses loginService arguments

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6365.
-
Resolution: Fixed

[~rombert], linked this issue as blocker for Sling 9

> JcrInstaller incorrectly uses loginService arguments
> 
>
> Key: SLING-6365
> URL: https://issues.apache.org/jira/browse/SLING-6365
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: JCR Installer 3.1.22
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: JCR Installer 3.1.24
>
>
> As [~andrei.dulvac] pointed out on SLING-5228, my changes use the 'subsystem 
> name' and 'workspace' parameters inconsistently. This works because the 
> arguments are always (null, null), as we no longer have workspaces with Oak.
> However, we should make sure the arguments are always used correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-6365) JcrInstaller incorrectly uses loginService arguments

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reopened SLING-6365:
-

That fix has to be part of Sling 9:

{noformat}
2017-01-27T20:22:59,212 | INFO  | pool-27-thread-1 | JcrInstaller   
  | 181 - org.apache.sling.installer.provider.jcr - 3.1.22 | Activating 
Apache Sling JCR Installer
2017-01-27T20:22:59,216 | ERROR | pool-27-thread-1 | JcrInstaller   
  | 181 - org.apache.sling.installer.provider.jcr - 3.1.22 | Repository 
exception during startup - deactivating installer!
javax.jcr.LoginException: Cannot derive user name for bundle 
org.apache.sling.installer.provider.jcr [181] and sub service default
at 
org.apache.sling.jcr.base.AbstractSlingRepository2.loginService(AbstractSlingRepository2.java:311)
 ~[?:?]
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.(JcrInstaller.java:213)
 ~[?:?]
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.start(JcrInstaller.java:351)
 ~[?:?]
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.activate(JcrInstaller.java:338)
 ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:?]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
 ~[?:?]
at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501) ~[?:?]
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:302) 
~[?:?]
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:294) 
~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:298)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:823)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:347)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:247)
 ~[?:?]
at 
org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:344) 
~[?:?]
at org.apache.felix.framework.Felix.getService(Felix.java:3699) ~[?:?]
at 
org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:470)
 ~[?:?]
at 
org.apache.sling.commons.osgi.SortingServiceTracker.addingService(SortingServiceTracker.java:79)
 ~[?:?]
at 
org.apache.sling.installer.core.impl.SortingServiceTracker.addingService(SortingServiceTracker.java:45)
 ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
 ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870)
 ~[?:?]
at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) 
~[?:?]
at 
org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229) ~[?:?]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:901)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
 ~[?:?]
at 
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
 ~[?:?]
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4557) 
~[?:?]
at org.apache.felix.framework.Felix.registerService(Felix.java:3549) 
~[?:?]
at 
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:348)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:887)
 ~[?:?]
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:874)
 ~[?:?]
at 

[jira] [Updated] (SLING-6365) JcrInstaller incorrectly uses loginService arguments

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-6365:

Priority: Major  (was: Minor)

> JcrInstaller incorrectly uses loginService arguments
> 
>
> Key: SLING-6365
> URL: https://issues.apache.org/jira/browse/SLING-6365
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: JCR Installer 3.1.22
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: JCR Installer 3.1.24
>
>
> As [~andrei.dulvac] pointed out on SLING-5228, my changes use the 'subsystem 
> name' and 'workspace' parameters inconsistently. This works because the 
> arguments are always (null, null), as we no longer have workspaces with Oak.
> However, we should make sure the arguments are always used correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


RE: [VOTE] Release Apache Sling Installer 3.8.2

2017-01-27 Thread Stefan Seifert
+1



[jira] [Resolved] (SLING-6484) PackageTransformer will install packages with the same name/group/version only once

2017-01-27 Thread Konrad Windszus (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-6484.

   Resolution: Fixed
Fix Version/s: Installer Packages Factory 1.0.0

Fixed in [r1780517|https://svn.apache.org/r1780517] after some discussion in 
JCRVLT-155.

> PackageTransformer will install packages with the same name/group/version 
> only once
> ---
>
> Key: SLING-6484
> URL: https://issues.apache.org/jira/browse/SLING-6484
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Packages Factory 1.0.0
>Reporter: Konrad Windszus
> Fix For: Installer Packages Factory 1.0.0
>
> Attachments: SLING-6484v01.patch
>
>
> Due to the check in 
> https://github.com/apache/sling/blob/trunk/installer/factories/packages/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L219,
>  installation of the same package (same version, name and group) will be 
> prevented the 2nd time, even if a modified version has been uploaded in 
> between.
> See the related ticket JCRVLT-155.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-6392) OSGi Installer: Symbolic name changes on a resource keeping the same URL is not properly supported

2017-01-27 Thread Konrad Windszus (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-6392:
--

Assignee: Konrad Windszus

> OSGi Installer: Symbolic name changes on a resource keeping the same URL is 
> not properly supported
> --
>
> Key: SLING-6392
> URL: https://issues.apache.org/jira/browse/SLING-6392
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Attachments: SLING-6392-test-v01.patch
>
>
> After deploying bundle with symbolic name {{A}} to JCR location 
> {{/apps/myapp/install/mybundle.jar}} or somewhere in the filesystem it is 
> correctly being picked up by the JcrInstaller or FileInstaller and deployed 
> in Apache Felix. Now the symbolic name has been changed to {{B}} and the 
> updated JAR has been deployed to the same location in the JCR  
> {{/apps/myapp/install/mybundle.jar}} or to the file system the updated bundle 
> is not correctly deployed.
> The OSGI installer console exposes that both bundles {{A}} and {{B}} are in 
> state {{Installed}} but the /system/console/bundle only shows bundle {{A}} 
> but not {{B}}.
> It would actually be expected that {{A}} is uninstalled, while {{B}} is 
> getting installed!
> Such a change can happen if you use the {{maven-bundle-plugin}} with a 
> default configuration and you just change the groupId of the underlying maven 
> project. That will not affect the finalName of the artifact (by default 
> artifactId) but the symbolic name of the bundle (see 
> http://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#default-behavior).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6488) Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Clelia Meneghin (JIRA)
Clelia Meneghin created SLING-6488:
--

 Summary: Exclude IntelliJ Modules Files from rat plugin
 Key: SLING-6488
 URL: https://issues.apache.org/jira/browse/SLING-6488
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Reporter: Clelia Meneghin
Priority: Trivial


Currently any present IntelliJ Module Files will cause the rat plugin to fail 
to build. I suggest to exclude them in the parent poms rat plugin 
configurations. 

see attached patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6488) Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Clelia Meneghin (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clelia Meneghin updated SLING-6488:
---
Attachment: 
SLING_6488___Exclude_IntelliJ_Modules_Files_from_rat_plugin.patch

> Exclude IntelliJ Modules Files from rat plugin
> --
>
> Key: SLING-6488
> URL: https://issues.apache.org/jira/browse/SLING-6488
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Reporter: Clelia Meneghin
>Priority: Trivial
> Attachments: 
> SLING_6488___Exclude_IntelliJ_Modules_Files_from_rat_plugin.patch
>
>
> Currently any present IntelliJ Module Files will cause the rat plugin to fail 
> to build. I suggest to exclude them in the parent poms rat plugin 
> configurations. 
> see attached patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Clelia Meneghin
Hi

Currently any present IntelliJ Module Files will cause the rat plugin to fail 
to build. I suggest to exclude them in the parent poms rat plugin 
configurations.

I created an issue [0]

Regards,
Clelia

[0] https://issues.apache.org/jira/browse/SLING-6488


[jira] [Commented] (SLING-6392) OSGi Installer: Symbolic name changes on a resource keeping the same URL is not properly supported

2017-01-27 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842521#comment-15842521
 ] 

Konrad Windszus commented on SLING-6392:


[~cziegeler] I tried to prepare a patch for this issue, but the logic in 
OSGiInstallerImpl is too convoluted for me to figure out what I need to do 
exactly. Is the attached IT enough for you to provide a patch? I would really 
like to see a fix for this in the next release.

> OSGi Installer: Symbolic name changes on a resource keeping the same URL is 
> not properly supported
> --
>
> Key: SLING-6392
> URL: https://issues.apache.org/jira/browse/SLING-6392
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Attachments: SLING-6392-test-v01.patch
>
>
> After deploying bundle with symbolic name {{A}} to JCR location 
> {{/apps/myapp/install/mybundle.jar}} or somewhere in the filesystem it is 
> correctly being picked up by the JcrInstaller or FileInstaller and deployed 
> in Apache Felix. Now the symbolic name has been changed to {{B}} and the 
> updated JAR has been deployed to the same location in the JCR  
> {{/apps/myapp/install/mybundle.jar}} or to the file system the updated bundle 
> is not correctly deployed.
> The OSGI installer console exposes that both bundles {{A}} and {{B}} are in 
> state {{Installed}} but the /system/console/bundle only shows bundle {{A}} 
> but not {{B}}.
> It would actually be expected that {{A}} is uninstalled, while {{B}} is 
> getting installed!
> Such a change can happen if you use the {{maven-bundle-plugin}} with a 
> default configuration and you just change the groupId of the underlying maven 
> project. That will not affect the finalName of the artifact (by default 
> artifactId) but the symbolic name of the bundle (see 
> http://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#default-behavior).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Felix Meschberger
Hi

Goot point.

And also: Are these files in subversion ? If they are, they should be removed 
and excluded by configuration. They don’t belong there.

Regards
Felix

> Am 27.01.2017 um 11:24 schrieb Clelia Meneghin :
> 
> Hi
> 
> Currently any present IntelliJ Module Files will cause the rat plugin to fail 
> to build. I suggest to exclude them in the parent poms rat plugin 
> configurations.
> 
> I created an issue [0]
> 
> Regards,
> Clelia
> 
> [0] https://issues.apache.org/jira/browse/SLING-6488



[jira] [Assigned] (SLING-6488) Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reassigned SLING-6488:
---

Assignee: Oliver Lietz

> Exclude IntelliJ Modules Files from rat plugin
> --
>
> Key: SLING-6488
> URL: https://issues.apache.org/jira/browse/SLING-6488
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Reporter: Clelia Meneghin
>Assignee: Oliver Lietz
>Priority: Trivial
> Attachments: 
> SLING_6488___Exclude_IntelliJ_Modules_Files_from_rat_plugin.patch
>
>
> Currently any present IntelliJ Module Files will cause the rat plugin to fail 
> to build. I suggest to exclude them in the parent poms rat plugin 
> configurations. 
> see attached patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6488) Exclude IntelliJ Modules Files from rat plugin

2017-01-27 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842608#comment-15842608
 ] 

Oliver Lietz commented on SLING-6488:
-

[~cmeneghi], I'm an IDEA user and don't see any build failures. Those IDE files 
are excluded per default, see 
http://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#useIdeaDefaultExcludes
Which build fails?


> Exclude IntelliJ Modules Files from rat plugin
> --
>
> Key: SLING-6488
> URL: https://issues.apache.org/jira/browse/SLING-6488
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Reporter: Clelia Meneghin
>Assignee: Oliver Lietz
>Priority: Trivial
> Attachments: 
> SLING_6488___Exclude_IntelliJ_Modules_Files_from_rat_plugin.patch
>
>
> Currently any present IntelliJ Module Files will cause the rat plugin to fail 
> to build. I suggest to exclude them in the parent poms rat plugin 
> configurations. 
> see attached patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6489) discovery.oak: log less frequent when slingId is not (yet) mapped

2017-01-27 Thread Stefan Egli (JIRA)
Stefan Egli created SLING-6489:
--

 Summary: discovery.oak: log less frequent when slingId is not 
(yet) mapped
 Key: SLING-6489
 URL: https://issues.apache.org/jira/browse/SLING-6489
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Discovery Oak 1.2.16
Reporter: Stefan Egli
 Fix For: Discovery Oak 1.2.18


When connecting an oak-run in read-write mode to a documentMk based cluster, 
discovery.oak complains with the following info messages repeatedly:

{noformat}

2017-01-27 17:32:09,970 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
NO_ESTABLISHED_VIEW] 
org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
slingId mapped for clusterNodeId=2 
2017-01-27 17:32:11,971 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
2017-01-27 17:32:11,971 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
NO_ESTABLISHED_VIEW] 
org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
slingId mapped for clusterNodeId=2 
2017-01-27 17:32:13,972 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
2017-01-27 17:32:13,972 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.b.c.BaseDiscoveryService - getTopology: undefined cluster view: 
NO_ESTABLISHED_VIEW] 
org.apache.sling.discovery.base.commons.UndefinedClusterViewException: no 
slingId mapped for clusterNodeId=2 
2017-01-27 17:32:15,973 INFO NA 
[discovery.connectors.common.runner.cf92d88d-345a-4e65-b776-f18dde62e585.discoveryLiteCheck]
 o.a.s.d.o.c.OakClusterViewService - getLocalClusterView: undefined 
clusterView: NO_ESTABLISHED_VIEW - no slingId mapped for clusterNodeId=2 
{noformat}

while this is 'by design' (being that oak-run represents only half of the 
expected discovery.oak/discovery-lite stack) we could lower the frequency of 
these messages to keep the log file cleaner. Perhaps log only every 5-10min.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)
Feike Visser created SLING-6490:
---

 Summary: Sightly doesn't render valid style attribute-value
 Key: SLING-6490
 URL: https://issues.apache.org/jira/browse/SLING-6490
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Feike Visser


I have the following piece of Java:

{code}
public class Style {

public String style = "background-image: url('/path/to/image.jpg');";
}
{code}

I can't get this value printed unless I use @ context = 'unsafe'
{code}

  

{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842732#comment-15842732
 ] 

Feike Visser commented on SLING-6490:
-

FYI: [~vladb], any idea?

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling DavEx Access to repositories 1.3.6, Apache Sling Simple WebDAV Access to repositories 2.3.6

2017-01-27 Thread Oliver Lietz
On Wednesday 25 January 2017 18:53:17 Robert Munteanu wrote:
> Hi,
> 
> We solved 7 issues in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12335042
> https://issues.apache.org/jira/browse/SLING/fixforversion/12335341

Hi Robert,

there are new test errors when running Launchpad's integration tests against 
Sling Karaf. Did you test DavEx with regular Launchpad?

Running 
org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.572 sec <<< 
FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest
testDescriptor(org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest)
  
Time elapsed: 0.411 sec  <<< ERROR!
javax.jcr.RepositoryException: Unable to access a repository with the 
following settings:
org.apache.jackrabbit.repository.uri: http://localhost:61839/server/
The following RepositoryFactory classes were consulted:
org.apache.jackrabbit.jcr2dav.Jcr2davRepositoryFactory: declined
org.apache.jackrabbit.jcr2spi.Jcr2spiRepositoryFactory: declined
org.apache.jackrabbit.commons.JndiRepositoryFactory: declined
org.apache.jackrabbit.core.RepositoryFactoryImpl: declined
Perhaps the repository you are trying to access is not available at the 
moment.
at 
org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:223)
at 
org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:263)
at 
org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest.setUp(DavExIntegrationTest.java:47)
at junit.framework.TestCase.runBare(TestCase.java:139)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

testReadNode(org.apache.sling.launchpad.webapp.integrationtest.DavExDisabledAnonAccessTest)
  
Time elapsed: 0.161 sec  <<< ERROR!
javax.jcr.RepositoryException: Unable to access a repository with the 
following settings:
org.apache.jackrabbit.repository.uri: http://localhost:61839/server/
The following RepositoryFactory classes were consulted:
org.apache.jackrabbit.jcr2dav.Jcr2davRepositoryFactory: declined
org.apache.jackrabbit.jcr2spi.Jcr2spiRepositoryFactory: declined
org.apache.jackrabbit.commons.JndiRepositoryFactory: declined
org.apache.jackrabbit.core.RepositoryFactoryImpl: declined
Perhaps the repository you are trying to access is not available at the 
moment.
at 
org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:223)
at 
org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:263)
at 
org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest.setUp(DavExIntegrationTest.java:47)
at junit.framework.TestCase.runBare(TestCase.java:139)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 

[jira] [Updated] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Feike Visser updated SLING-6490:

Labels: Sightly  (was: )

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Vlad Bailescu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842758#comment-15842758
 ] 

Vlad Bailescu commented on SLING-6490:
--

[~fvisser]: The {{styleToken}} context is to be used for tokens, not CSS 
declarations (See 
https://github.com/Adobe-Marketing-Cloud/htl-spec/blob/master/SPECIFICATION.md#121-display-context).
 In your case you might want to use something like:

{code:html}
style="background-image: ${fv.backgroundImage}"
{code}

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842768#comment-15842768
 ] 

Feike Visser commented on SLING-6490:
-

But also things like styleString isn't working.

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842768#comment-15842768
 ] 

Feike Visser edited comment on SLING-6490 at 1/27/17 12:46 PM:
---

[~vladb] But also things like styleString isn't working.


was (Author: fvisser):
But also things like styleString isn't working.

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Vlad Bailescu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842788#comment-15842788
 ] 

Vlad Bailescu commented on SLING-6490:
--

There's probably some name confusion because of the fact that CSS declarations 
can be part of the {{style}} attribute (string) value. The {{styleString}} 
context is supposed to be used for strings within the CSS declarations, ie:

{code:html}
style="background-image: url('${fv.url}')"
{code}

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling JSP Scripting 2.2.6

2017-01-27 Thread Oliver Lietz
On Wednesday 25 January 2017 08:25:35 Carsten Ziegeler wrote:
> Hi,
> 
> We solved 1 issues in this release:
> https://issues.apache.org/jira/browse/SLING-6458

+1 though I still get those nasty VerifyErrors.
Are there any plans for a major update of Jasper – 8.5 or even 9?

Regards,
O.



[jira] [Created] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Antonio Sanso (JIRA)
Antonio Sanso created SLING-6491:


 Summary: Make RestartActiveBundlesTask#execute more resilient. 
 Key: SLING-6491
 URL: https://issues.apache.org/jira/browse/SLING-6491
 Project: Sling
  Issue Type: Bug
  Components: Installer
Reporter: Antonio Sanso


RestartActiveBundlesTask#execute could be more resilient. 
See this stacktrace for an example:

{code}
[OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
Uncaught exception during task execution! java.lang.IllegalStateException: 
Cannot start an uninstalled bundle.   at 
org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
  at 
{code}

patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Vlad Bailescu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842805#comment-15842805
 ] 

Vlad Bailescu commented on SLING-6490:
--

For more clarity: there is no HTL context at the moment that can handle entire 
CSS declarations. Same goes for JavaScript code and this is by design of the 
language/contexts so that HTL expression are only used in pin-point locations, 
instead of injecting large CSS/JS blocks of code. This keeps CSS and JS close 
to the HTML template.

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


RE: [VOTE] Release Apache Sling ABC version Resource Inventory 1.0.6

2017-01-27 Thread Oliver Lietz
On Thursday 26 January 2017 12:58:34 Stefan Seifert wrote:
> +1
> 
> (although it looks strange that the list of changes contains no functional
> change and only an improved unit test coverage)

Does improved test coverage really justify a new release?

O.

> stefan



[jira] [Assigned] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-6490:
---

Assignee: Radu Cotescu

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-6490.
-
Resolution: Not A Bug

As described by [~vladb], when you need to sanitise JS / CSS, you have to make 
sure that you're validating more fine grained content - tokens or strings, but 
not chunks of code.

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842830#comment-15842830
 ] 

Feike Visser commented on SLING-6490:
-

tested this, but the file-location gets wrongly escaped now:

{code}
'\2f content\2f dam\2fwe-retail\2f en\2f experiences\2f 
arctic-surfing-in-lofoten\2f camp-fire.jpg'
{code}

Sightly syntax:
{code}
 style="backgroundimage: url('${ fv.style @ context='styleString'}')
{code}

Java:
{code}
public class Style {

public String style = 
"/content/dam/we-retail/en/experiences/arctic-surfing-in-lofoten/camp-fire.jpg";

}
{code}

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Feike Visser reopened SLING-6490:
-

Please check my latest comment..

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842841#comment-15842841
 ] 

Feike Visser commented on SLING-6490:
-

[~radu.cotescu] thanks for your comment, indeed [~vladb] had a good point on 
sanitising JS/CSS.
Still I don't get it to work. See my example.

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Antonio Sanso (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842854#comment-15842854
 ] 

Antonio Sanso commented on SLING-6491:
--

pasting diff

{code}
Index: 
src/main/java/org/apache/sling/installer/core/impl/tasks/RestartActiveBundlesTask.java
===
--- 
src/main/java/org/apache/sling/installer/core/impl/tasks/RestartActiveBundlesTask.java
  (revision 1765764)
+++ 
src/main/java/org/apache/sling/installer/core/impl/tasks/RestartActiveBundlesTask.java
  (working copy)
@@ -78,6 +78,9 @@
 remove.add(id);
 } catch (final BundleException e) {
 getLogger().info("Unable to start bundle {} : {}", 
bundle, e.getMessage());
+} catch (final IllegalStateException ie) {
+getLogger().info("Unable to start bundle {} : {}", 
bundle, ie.getMessage());
+remove.add(id);
 }
 } else {
 // bundle might be null(!)
{code}

[~cziegeler] WDYT?

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Vlad Bailescu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842870#comment-15842870
 ] 

Vlad Bailescu commented on SLING-6490:
--

[~fvisser]: the escaping looks good to me, but {{backgroundimage}} should be 
{{background-image}}

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842881#comment-15842881
 ] 

Feike Visser commented on SLING-6490:
-

thanks [~vladb] :-)

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5364) Provide Pipes feature

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-5364:

Fix Version/s: Karaf Distribution 0.2.0
   Karaf Integration Tests 0.2.0

> Provide Pipes feature
> -
>
> Key: SLING-5364
> URL: https://issues.apache.org/jira/browse/SLING-5364
> Project: Sling
>  Issue Type: New Feature
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
> Karaf Distribution 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5364) Provide Pipes feature

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-5364.
-
Resolution: Implemented

[r1780558|https://svn.apache.org/r1780558]
[r1780559|https://svn.apache.org/r1780559]
[r1780560|https://svn.apache.org/r1780560]

> Provide Pipes feature
> -
>
> Key: SLING-5364
> URL: https://issues.apache.org/jira/browse/SLING-5364
> Project: Sling
>  Issue Type: New Feature
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
> Karaf Distribution 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6490) Sightly doesn't render valid style attribute-value

2017-01-27 Thread Feike Visser (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Feike Visser resolved SLING-6490.
-
Resolution: Won't Fix

> Sightly doesn't render valid style attribute-value
> --
>
> Key: SLING-6490
> URL: https://issues.apache.org/jira/browse/SLING-6490
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>  Labels: Sightly
>
> I have the following piece of Java:
> {code}
> public class Style {
> public String style = "background-image: url('/path/to/image.jpg');";
> }
> {code}
> I can't get this value printed unless I use @ context = 'unsafe'
> {code}
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842912#comment-15842912
 ] 

Konrad Windszus commented on SLING-6491:


This is related to SLING-5457 and IMHO we should rework the whole 
retry/exception handling of the installer. I made a proposal for that in 
https://issues.apache.org/jira/browse/SLING-5457?focusedCommentId=15594506=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15594506.

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Antonio Sanso (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842916#comment-15842916
 ] 

Antonio Sanso commented on SLING-6491:
--

[~kwin] thanks. In any case I think that the patch I propose can still find a 
place in the final solution

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842925#comment-15842925
 ] 

Carsten Ziegeler commented on SLING-6491:
-

[~asanso] Yes, I think we should apply this patch regardless of any other 
changes

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Authentication Service 1.3.24

2017-01-27 Thread Antonio Sanso
my own +1
On Jan 26, 2017, at 3:28 PM, Antonio Sanso  wrote:

> Hi,
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING-6485
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1627/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1627 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.



[jira] [Commented] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Antonio Sanso (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842933#comment-15842933
 ] 

Antonio Sanso commented on SLING-6491:
--

[~cziegeler] thanks I applied the patch in r1780567

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6491) Make RestartActiveBundlesTask#execute more resilient.

2017-01-27 Thread Antonio Sanso (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso resolved SLING-6491.
--
   Resolution: Fixed
Fix Version/s: Installer Core 3.8.2

> Make RestartActiveBundlesTask#execute more resilient. 
> --
>
> Key: SLING-6491
> URL: https://issues.apache.org/jira/browse/SLING-6491
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Antonio Sanso
> Fix For: Installer Core 3.8.2
>
>
> RestartActiveBundlesTask#execute could be more resilient. 
> See this stacktrace for an example:
> {code}
> [OsgiInstallerImpl] org.apache.sling.installer.core.impl.OsgiInstallerImpl 
> Uncaught exception during task execution! java.lang.IllegalStateException: 
> Cannot start an uninstalled bundle. at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:1953)at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998) at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984) at 
> org.apache.sling.installer.core.impl.tasks.RestartActiveBundlesTask.execute(RestartActiveBundlesTask.java:75)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:855)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
>   at 
> {code}
> patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6319) Installer sometimes deletes the wrong .ser files

2017-01-27 Thread Antonio Sanso (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-6319:
-
Fix Version/s: Installer Core 3.8.2

> Installer sometimes deletes the wrong .ser files
> 
>
> Key: SLING-6319
> URL: https://issues.apache.org/jira/browse/SLING-6319
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
> Fix For: Installer Core 3.8.2
>
>
> It looks like the logic used to delete the {{rsrc.getPrivateCopyOfFile()}} in 
> {{OsgiInstallerImpl.registerResources}} is wrong and sometimes causes .ser 
> files to be wrongly deleted.
> I'll commit a new {{OsgiInstallerImplTest}} that demonstrates this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[DSCUSS] Release Installer Core 3.8.2 (is the bundle "releasable")

2017-01-27 Thread Antonio Sanso
hi *,

I would like to Release Installer Core 3.8.2. Looking at [0] I see 4 issue 
resolved and one still open [1].
Can we postpone [1] for the 3.8.4 release? Is this bundle currently 
“releasable” (aka in a stable state) ?

Thanks and regards

antonio


[0] https://issues.apache.org/jira/browse/SLING/fixforversion/12338691
[1] https://issues.apache.org/jira/browse/SLING-6313

Re: [DSCUSS] Release Installer Core 3.8.2 (is the bundle "releasable")

2017-01-27 Thread Carsten Ziegeler
Antonio Sanso wrote
> hi *,
> 
> I would like to Release Installer Core 3.8.2. Looking at [0] I see 4 issue 
> resolved and one still open [1].
> Can we postpone [1] for the 3.8.4 release? Is this bundle currently 
> “releasable” (aka in a stable state) ?
> 
I think it is in a stable state and can be released

Regards

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [DSCUSS] Release Installer Core 3.8.2 (is the bundle "releasable")

2017-01-27 Thread Antonio Sanso
Thanks I will give a shoot so…

On Jan 27, 2017, at 5:03 PM, Carsten Ziegeler  wrote:

> Antonio Sanso wrote
>> hi *,
>> 
>> I would like to Release Installer Core 3.8.2. Looking at [0] I see 4 issue 
>> resolved and one still open [1].
>> Can we postpone [1] for the 3.8.4 release? Is this bundle currently 
>> “releasable” (aka in a stable state) ?
>> 
> I think it is in a stable state and can be released
> 
> Regards
> 
> Carsten
> 
> -- 
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



[jira] [Created] (SLING-6492) Remove (sub) service user from ScriptCacheImpl

2017-01-27 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-6492:
---

 Summary: Remove (sub) service user from ScriptCacheImpl
 Key: SLING-6492
 URL: https://issues.apache.org/jira/browse/SLING-6492
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Core 2.0.46


There is no *sub* service user {{sling-scripting}} in Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6492) Remove (sub) service user from ScriptCacheImpl

2017-01-27 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6492.
-
Resolution: Done

[r1780579|https://svn.apache.org/r1780579]

> Remove (sub) service user from ScriptCacheImpl
> --
>
> Key: SLING-6492
> URL: https://issues.apache.org/jira/browse/SLING-6492
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Scripting Core 2.0.46
>
>
> There is no *sub* service user {{sling-scripting}} in Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

2017-01-27 Thread Antonio Sanso (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-6313:
-
Fix Version/s: (was: Installer Core 3.8.2)
   Installer Core 3.8.4

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Installer Core 3.8.4
>
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] Release Apache Sling Installer 3.8.2

2017-01-27 Thread Antonio Sanso
Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338691

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1628/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1628 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

RE: [VOTE] Release Apache Sling Authentication Service 1.3.24

2017-01-27 Thread Stefan Seifert
+1