[jira] [Commented] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows
[
https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119349#comment-17119349
]
Robert Munteanu commented on SLING-9483:
I was looking at
https://github.com/apache/sling-org-apache-sling-feature/commit/afb1e40cafbd906a4546ce0ee0074b08512d14c0
and I was thinking maybe we can use a better Java API ( {{java.noi,file.Path}}
maybe? ) instead of adding checks for Windows.
> Sling Feature is not supporting jar:file URLs on Windows
>
>
> Key: SLING-9483
> URL: https://issues.apache.org/jira/browse/SLING-9483
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model 1.2.2
>
>
> When using a jar:file url to launch a feature in the feature launcher it will
> fail because the folder to export the Feature Model file contains the drive
> name (c:/) which fails when the folder is created.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows
[
https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119349#comment-17119349
]
Robert Munteanu edited comment on SLING-9483 at 5/29/20, 7:25 AM:
--
I was looking at
https://github.com/apache/sling-org-apache-sling-feature/commit/afb1e40cafbd906a4546ce0ee0074b08512d14c0
and I was thinking that we should use better Java API ( {{java.nio.file.Path}}
maybe? ) instead of adding checks for Windows.
was (Author: rombert):
I was looking at
https://github.com/apache/sling-org-apache-sling-feature/commit/afb1e40cafbd906a4546ce0ee0074b08512d14c0
and I was thinking maybe we can use a better Java API ( {{java.noi,file.Path}}
maybe? ) instead of adding checks for Windows.
> Sling Feature is not supporting jar:file URLs on Windows
>
>
> Key: SLING-9483
> URL: https://issues.apache.org/jira/browse/SLING-9483
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model 1.2.2
>
>
> When using a jar:file url to launch a feature in the feature launcher it will
> fail because the folder to export the Feature Model file contains the drive
> name (c:/) which fails when the folder is created.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9487) Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole.
Dominik Süß created SLING-9487:
--
Summary: Default for org.apache.sling.commons.log.file only set
via metatype breaking the logstatus webconsole.
Key: SLING-9487
URL: https://issues.apache.org/jira/browse/SLING-9487
Project: Sling
Issue Type: Bug
Components: Commons
Reporter: Dominik Süß
As the default for {{org.apache.sling.commons.log.file}} for PID
{{org.apache.sling.commons.log.LogManager.factory.config}} is only set for the
metatype the default only applies on setting the configuration via UI.
The webconsole UI is dependent on this path to be configured to group the
loggers accordin to those writers and spawns a nullpointerexception if a config
is getting registered (e.g. via sling installer or feature model) that doesn't
set this parameter.
The proposed solution to this bug is to make sure that configuration being
registered without this path pick up the same default value defined as in the
metatype.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-commons-log] DominikSuess opened a new pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…
DominikSuess opened a new pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6 …nagedServiceFactory This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9487) Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole.
[
https://issues.apache.org/jira/browse/SLING-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119469#comment-17119469
]
Dominik Süß commented on SLING-9487:
PR at https://github.com/apache/sling-org-apache-sling-commons-log/pull/6
> Default for org.apache.sling.commons.log.file only set via metatype breaking
> the logstatus webconsole.
> --
>
> Key: SLING-9487
> URL: https://issues.apache.org/jira/browse/SLING-9487
> Project: Sling
> Issue Type: Bug
> Components: Commons
>Reporter: Dominik Süß
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As the default for {{org.apache.sling.commons.log.file}} for PID
> {{org.apache.sling.commons.log.LogManager.factory.config}} is only set for
> the metatype the default only applies on setting the configuration via UI.
> The webconsole UI is dependent on this path to be configured to group the
> loggers accordin to those writers and spawns a nullpointerexception if a
> config is getting registered (e.g. via sling installer or feature model) that
> doesn't set this parameter.
> The proposed solution to this bug is to make sure that configuration being
> registered without this path pick up the same default value defined as in the
> metatype.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[RESULT][VOTE] Release Apache Sling slingfeature-maven-plugin 1.3.4
With 5 binding +1 votes and 1 non-binding +1 vote this release succeeds. I've promoted the artifacts. Best regards, David On Mon, 25 May 2020 at 15:24, wrote: > Hi all, > > I would like to call the release on the Sling Feature Maven Plugin 1.3.4 > > Resolved issues: > https://issues.apache.org/jira/projects/SLING/versions/12348275 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2269 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2269 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Best regards, > > David >
[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on pull request #28: Feature Converter doesn't cleanup after itself
bosschaert commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635914387 > do you mind creating an issue for this? Not sure if I have access Creating a sling issue can be done by anyone. Just create an account and file the issue here: https://issues.apache.org/jira/projects/SLING This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-log] bosschaert commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…
bosschaert commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-635915203 LGTM 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-log] bosschaert edited a comment on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…
bosschaert edited a comment on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-635915203 LGTM 👍 There is a test failure though... ITConfigAdminSupport.testChangeLogLevelWithConfig:118 null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-9488) Do not wait in case of journal not seeded
Christian Schneider created SLING-9488: -- Summary: Do not wait in case of journal not seeded Key: SLING-9488 URL: https://issues.apache.org/jira/browse/SLING-9488 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Journal Core 0.1.10 Reporter: Christian Schneider Currently we wait up to 60s until the queues are seeded. As the UI accesses the queues this means the UI appears to be down. Instead we could assume that we have 0 queues in case of not seeded. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9484) CMS - Archetype Missing BND Configurations
[ https://issues.apache.org/jira/browse/SLING-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9484. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/601ef302669fd5d45b46e2442c4038eabed1ecff > CMS - Archetype Missing BND Configurations > -- > > Key: SLING-9484 > URL: https://issues.apache.org/jira/browse/SLING-9484 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 0.16.4 > > > The Sling CMS Archetype project is missing the BND configuration attributes: > * -includeresource > * Sling-Initial-Content > * Sling-Model-Packages > And therefore will not load content or expose models. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] move o.a.s.graphql.samples.website to its own repo
Hi Bertrand, On Thu, 2020-05-28 at 16:48 +0200, Bertrand Delacretaz wrote: > Hi, > > I'd like to move the org.apache.sling.graphql.samples.website [1] > module to its own Git repository. > > It's a companion module to the GraphQL Core module, which > demonstrates > its features, see the README there for more info. > > Proposed repository name: > > org.apache.sling.graphql.sample.website You probably considered this, but I am curious - why a separate repository vs adding it to sling-samples [2]? Thanks, Robert [2]: https://github.com/apache/sling-samples > > (using singular "sample" as it's "a sample website") > > This majority vote is open for at least 72 hours. > > Here's my +1 > > -Bertrand > > [1] > https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.graphql.samples.website
[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]
[
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119625#comment-17119625
]
Robert Munteanu commented on SLING-9397:
[~cris_rockwell] - looking at the instructions indeed the SSL setup is
complicated. One first good step would be to either make signing/encryption
optional or to provide a faster way to do it for Sling. Can this be done with a
content package or a script? I guess one self-signed keystore is something we
can script and then deploy on-demand to Sling. And I would assume that we can
automate keycloak setup as well.
Docker/Maven things can come a bit later and I can help with that.
> SAML2 Authentication Handler [initial submission]
> -
>
> Key: SLING-9397
> URL: https://issues.apache.org/jira/browse/SLING-9397
> Project: Sling
> Issue Type: New Feature
> Components: Authentication
> Environment: localhost
>Reporter: Cris Rockwell
>Priority: Major
> Labels: SAML, authentification, security, user_management
> Original Estimate: 168h
> Time Spent: 1h
> Remaining Estimate: 167h
>
> Here is a pull request which adds an authentication handler for a SAML2
> Service Provider via the embedded OpenSAML V3 dependencies
> [https://github.com/apache/sling-whiteboard/pull/51]
>
> *TODO Before Initial*
> [X] Sync attributes released by the IDP
> [X] Confirm license and attribution
> "As the code is ASL2 and does not require a notice or anything else, we don't
> need to mention in. But I think its usually good style to do so and have a
> single sentence in our NOTICE that we include (modified) code from ... which
> has ASL2 as the license"
>
> *TODO After Initial*
> [ ] Get confirmation the project builds and operates as expected
> [X] Ensure that the NOTICE file is the correct one
> [ ] Testing setup ( documentation, local SAML provider, etc )
> [ ] Clarify whether we can depend on artifacts not deployed on Maven Central
> [ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
> * [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
> [ ] Consider whether use of {{SAML2ConfigService}} and
> {{SAML2ConfigServiceImpl}} is a good design or not.
> [ ] Get feedback whether README instructions are too much, too little,
> unclear, etc
> [ ] Decide whether to make signing and encryption optional. Currently it is
> required
> [ ] Find and fix any bugs
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE] move o.a.s.graphql.samples.website to its own repo
Hi Robert On Fri, May 29, 2020 at 3:40 PM Robert Munteanu wrote: > ...You probably considered this, but I am curious - why a separate > repository vs adding it to sling-samples [2]?... I didn't really consider that so far but you're right that if my code has no need for a Jenkins build for example that's good enough. I'll probably be too lazy to write tests for that code so I'll move there for now, thanks for the suggestion! -Bertrand > [2]: https://github.com/apache/sling-samples
FYI, deprecated a few very old samples: espblog, javashell, path-based-rtp
Hi, I have moved those to a DEPRECATED folder in the sling-samples module [1] If someone needs them back, it's easy to revert. -Bertrand [1] https://github.com/apache/sling-samples/commit/863fb0c26238afe22fb231219fca23cf4c9543dd
[jira] [Created] (SLING-9489) Make it possible to compare parts of feature models
A. J. David Bosschaert created SLING-9489: - Summary: Make it possible to compare parts of feature models Key: SLING-9489 URL: https://issues.apache.org/jira/browse/SLING-9489 Project: Sling Issue Type: New Feature Components: Feature Model, Maven Plugins and Archetypes Affects Versions: slingfeature-maven-plugin 1.3.4 Reporter: A. J. David Bosschaert Assignee: A. J. David Bosschaert Fix For: slingfeature-maven-plugin 1.3.6 We need a mojo that allows the comparison of parts of a feature model. If these parts are not equal the mojo should fail the build. Right now comparing extensions would be a good start. But comparing configurations or bundles would also be good. Key is that not everything needs to be compared. The configuration in the pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119712#comment-17119712 ] Carsten Ziegeler commented on SLING-9489: - What is the use case? We also already have a diff mojo, maybe this can be extended? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-commons-log] kwin commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…
kwin commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-636040989 Switching to https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types is more sustainable but is certainly more effort. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119718#comment-17119718 ] A. J. David Bosschaert commented on SLING-9489: --- The use-case is that sometimes optimizations can be made when certain parts of a feature model are the same. Think of for example processing of an extension. If the extension is the same between 2 feature models you can sometimes save time during the build by only processing it once. Or for example when code is generated from an extension. If 2 extensions are the same between 2 feature models then the same generated code can be shared between them. I looked at the FeaturesDiff mojo and it doesn't seem to fit very well for this use-case. That mojo takes a number of feature models and compares them with older versions of the same feature models. Then it produces a diff feature model for each, i.e. a model that can be applied to the older feature model to get the newer feature model. For the use-case that this issue is about we need to: * compare different feature models (not older versions of the same) * compare only parts, not the whole * generate a build error if there is a difference, no need to generate a diff model I looked at refactoring the FeaturesDiff mojo, but because the use-cases are so different I think it would be cleaner to create a new, separate mojo for this issue here. > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119725#comment-17119725 ] Carsten Ziegeler commented on SLING-9489: - This sounds like a strange feature for a maven plugin Can't the part which generates code simply call the diff functionality (which is a separate module) and then do whatever is appropriate? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] move o.a.s.graphql.samples.website to its own repo
On Fri, May 29, 2020 at 4:21 PM Bertrand Delacretaz wrote: > ...you're right that if my code > has no need for a Jenkins build for example that's good enough... Turns out that a build is already setup for https://github.com/apache/sling-samples/ - I just fixed it by removing the "fling" failing module. -Bertrand
[jira] [Created] (SLING-9490) Feature Model Converter doesn't clean up tmp directories
Kaushal Mall created SLING-9490: --- Summary: Feature Model Converter doesn't clean up tmp directories Key: SLING-9490 URL: https://issues.apache.org/jira/browse/SLING-9490 Project: Sling Issue Type: Bug Reporter: Kaushal Mall The _sub-content-packages_ and _synthetic-content-packages_ under the Java tmp directory are left behind after the execution causing the new changes in the content package not being picked up. _synthetic_ is also misspelled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall commented on pull request #28: Feature Converter doesn't cleanup after itself
kaushalmall commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-636159564 created https://issues.apache.org/jira/browse/SLING-9490 thanks @bosschaert This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119923#comment-17119923 ] A. J. David Bosschaert commented on SLING-9489: --- [~cziegeler] do you think this functionality would fit as a feature model analyzer? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9482) Seed the cache from offset persisted in the source repository
[ https://issues.apache.org/jira/browse/SLING-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-9482. --- Resolution: Fixed > Seed the cache from offset persisted in the source repository > - > > Key: SLING-9482 > URL: https://issues.apache.org/jira/browse/SLING-9482 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.16 > > > The approach taken in SLING-9460 to avoid sending seeding messages does not > address some scenarios like publishing content without subscriber agents. > Without subscriber agents. > To be sure we always have a recent seed available, we should persist seed > offsets in the source repository (typ. author) and seed caches from it. We do > have the local store class that allows to easily write the offsets in the > repository. To not stress the repository too much, we should batch those > writes (e.g. 1 offset update every 10 package processed). To support a > cluster, the writes must be initiated only from the cluster leader instance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Framework Properties Override on Feature Launcher
Hi Is it just me or does the Feature Launcher not support Framework Properties Overrides? Cheers - Andy
