[Bug 8062] [review] no URL makes uridnsbl rules "unrun"
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8062 Bug 8062 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8065] disabled plugins cause undefined dependencies for meta rules
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8065 Bug 8065 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8061] [review] Fix meta handling for $suppl_attrib->{rule_hits}
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061 Bug 8061 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7987] DNSEval.pm,HashBL.pm,URILocalBL.pm: unnecessary use of rule_pending and rule_ready
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7987 Bug 7987 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Bug 8060 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 Bug 8059 depends on bug 7735, which changed state. Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 Henrik Krohns changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #83 from Henrik Krohns --- Hopefully no need to reopen anymore. :-) Sendingtrunk/lib/Mail/SpamAssassin/Plugin/Check.pm Transmitting file data .done Committing transaction... Committed revision 1905160. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 --- Comment #82 from Bill Cole --- +1 to commit latest fix. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735
--- Comment #81 from Giovanni Bechis ---
(In reply to Henrik Krohns from comment #80)
> (In reply to Henrik Krohns from comment #76)
> >
> > --- lib/Mail/SpamAssassin/Plugin/Check.pm (revision 1905124)
> > +++ lib/Mail/SpamAssassin/Plugin/Check.pm (working copy)
> > @@ -316,7 +316,7 @@
> >$pms->got_hit($rulename, '', ruletype => 'meta', value => $result);
> > } else {
> >dbg("rules-all: ran meta rule $rulename, no hit") if
> > $would_log_rules_all;
> > - $h->{$rulename} = 0; # mark meta done
> > + $pms->rule_ready($rulename, 1); # mark meta done
> > }
> > delete $mr->{$rulename};
> > delete $mp->{$rulename};
>
> Vote to commit please. Even though it's quite trivial.
+1 for me to commit this.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735
--- Comment #80 from Henrik Krohns ---
(In reply to Henrik Krohns from comment #76)
>
> --- lib/Mail/SpamAssassin/Plugin/Check.pm (revision 1905124)
> +++ lib/Mail/SpamAssassin/Plugin/Check.pm (working copy)
> @@ -316,7 +316,7 @@
>$pms->got_hit($rulename, '', ruletype => 'meta', value => $result);
> } else {
>dbg("rules-all: ran meta rule $rulename, no hit") if
> $would_log_rules_all;
> - $h->{$rulename} = 0; # mark meta done
> + $pms->rule_ready($rulename, 1); # mark meta done
> }
> delete $mr->{$rulename};
> delete $mp->{$rulename};
Vote to commit please. Even though it's quite trivial.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 --- Comment #79 from Wolfgang Breyha --- Calling rule_ready() looks good and achieves the same results as my changes. I see you added the call to do_meta_tests() in front of finish_meta_tests() as well in October with the patch for #8061. Maybe that and the call to rule_ready() is already enough to run as many metas as possible. I had quite good results with this combination on top of rc3. -- You are receiving this mail because: You are the assignee for the bug.
