[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #12 from Kevin A. McGrail kmcgr...@pccc.com --- So just re-reading this bug. If I read the extra comments, it does work but you would like more debug / output changes, correct? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #13 from AXB axb.li...@gmail.com --- (In reply to comment #12) So just re-reading this bug. If I read the extra comments, it does work but you would like more debug / output changes, correct? yep. especially spamd logging: normally autolearn=spam if forced: autolearn=force_spam or somethign like it. or in debug dbg: learn: auto-learn? yes, spam, force -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #8 from AXB axb.li...@gmail.com --- I have the feeling that applying autolearn_force to a meta rule doesn't work. Don't have a clue how I can debug this. Any ideas? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #9 from AXB axb.li...@gmail.com --- for normal spam/ham we see autolearn=spam / ham Would be nice to have a: autolearn=force_spam / force_ham when it hits. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #10 from AXB axb.li...@gmail.com --- (In reply to comment #8) FTR: cat msg | spamassassin -D learn -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #11 from AXB axb.li...@gmail.com --- Feb 17 12:48:03.246 [4123] dbg: learn: auto-learn: currently using scoreset 3, recomputing score based on scoreset 1 Feb 17 12:48:03.246 [4123] dbg: learn: auto-learn: adding head_only points 0.865 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: adding body_only points 0.001 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: adding body_only points 0.5 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: adding head_only points 4.099 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: adding head_only points 3.5 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: message score: 12.764, computed score for autolearn: 8.965 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn? ham=-10, spam=1, body-points=0.501, head-points=8.464, learned-points=3.5 Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn: autolearn_force flagged for a rule. Removing seperate body and head point threshold. Body Only Points: 0.501 (-9 req'd) / Head Only Points: 8.464 (-99 req'd) Feb 17 12:48:03.247 [4123] dbg: learn: auto-learn? yes, spam (8.965 1) Feb 17 12:48:03.247 [4123] dbg: learn: initializing learner Feb 17 12:48:03.248 [4123] dbg: learn: learning spam Feb 17 12:48:03.266 [4123] dbg: learn: initializing learner Would be nice if debug would show which rule triggered the autolearn_force for this msg the autolearn_force tflag was set to a meta rule so (I believe) it seems to be working with metas. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503 --- Comment #7 from Kevin A. McGrail kmcgr...@pccc.com --- More tweaks so Jenkins can skip the tests. svn commit -m 'Made autolearn_force tests require DB_File so they pass on Jenkins and fixed Manifest. Bug 5503.' SendingMANIFEST Sendingt/autolearn_force.t Sendingt/autolearn_force_fail.t Transmitting file data ... Committed revision 1436363. Also added a test for autolearn svn commit -m 'Added a test for autolearn' SendingMANIFEST Adding t/autolearn.t Transmitting file data .. Committed revision 1436371. These tests could likely use more conditions like checking for autolearn ham but overall they helped a lot in finding the bug at the core of the head scores body scores. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5503] [REVIEW] FR: autolearn_force will force Bayes learning according to tflag setting
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5503
Kevin A. McGrail kmcgr...@pccc.com changed:
What|Removed |Added
Summary|FR: autolearn_force will|[REVIEW] FR:
|force Bayes learning|autolearn_force will force
|according to tflag setting |Bayes learning according to
||tflag setting
Severity|enhancement |blocker
--- Comment #6 from Kevin A. McGrail kmcgr...@pccc.com ---
svn commit -m 'feature request for tflag autolearn_force to make the
requirements less stringent - bug 5503'
Sendinglib/Mail/SpamAssassin/Conf.pm
Sendinglib/Mail/SpamAssassin/PerMsgStatus.pm
Sendinglib/Mail/SpamAssassin/Plugin/AutoLearnThreshold.pm
Adding t/autolearn_force.t
Adding t/autolearn_force_fail.t
Transmitting file data .
Committed revision 1436171.
svn commit -m 'cleaned up more with the autolearn_force code and worked on
major autolearn bug - bug 5503'
Sendinglib/Mail/SpamAssassin/Conf/Parser.pm
Sendinglib/Mail/SpamAssassin/Conf.pm
Sendinglib/Mail/SpamAssassin/PerMsgStatus.pm
Sendinglib/Mail/SpamAssassin/Plugin/AutoLearnThreshold.pm
Sendingt/autolearn_force.t
Sendingt/autolearn_force_fail.t
Transmitting file data ..
Committed revision 1436202.
OK, I committed this. However, I found some oddities and think I might have
uncovered something fundamentally broken with autolearn.
First, in the handling of figuring out if something is a head or a body test,
there appears to be some bugginess.
I changed lib/Mail/SpamAssassin/PerMsgStatus.pm to return head or body.
Before, it seemed to sometimes return both for the same rule.
If you add -D to the autolearn_force and autolearn_force_fail test calls, the
autolearn_force I would expect to hit body_only
Jan 20 22:45:00.432 [3288] dbg: learn: auto-learn: autolearn_force flagged for
a rule. Removing seperate body and head point threshold. Body Only Points: 6.02
(0 req'd) / Head Only Points: 0 (0 req'd)
However for autolearn_force_fail, I would have expected to hit head only points
but I get body only points.
Jan 20 22:46:11.216 [3300] dbg: learn: auto-learn: autolearn_force not flagged
for a rule. Body Only Points: 12.02 (3 req'd) / Head Only Points: 0 (3 req'd)
Before I made the if/elsif change in PerMsgStatus, I would get 12.02 for both
Body and Head Only.
I think maybe_header_only and maybe_body_only are problematic before I started
this process. It appears to me from the debug output I added that this line I
commented is causing the test_type to be lost:
Index: lib/Mail/SpamAssassin/Conf/Parser.pm
===
--- lib/Mail/SpamAssassin/Conf/Parser.pm(revision 1435362)
+++ lib/Mail/SpamAssassin/Conf/Parser.pm(working copy)
@@ -924,7 +924,8 @@
# free up stuff we no longer need
delete $conf-{tests};
delete $conf-{priority};
-delete $conf-{test_types};
+#test_types are needed - see bug 5503
+#delete $conf-{test_types};
}
}
I could be wrong, though and would REALLY like some extra eyes on revision
1436171 and 1436202.
Changing this to be a blocker because I think it uncovered a pretty large
issue.
Regards,
KAM
--
You are receiving this mail because:
You are the assignee for the bug.
