[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

Kevin A. McGrail  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #12 from Kevin A. McGrail  ---
Paranthesis are not valid in a uri so it's not being mishandled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

--- Comment #9 from Giovanni Bechis  ---
With default rules I cannot spot differences and a
"eval:check_uridnsbl('URIBL_SBLXBL')" rule is not triggered for me; note that
some rules are better triggered iff the content is detected as html because the
code path is different.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

--- Comment #8 from RW  ---
I don't have an email, I was looking to see what happened with things like
   canadianpharmacy.com!
!!!canadianpharmacy.com!!! 
--canadianpharmacy.com--

Most them don't work correctly.

I've always found things like printf  '\nbuy from canadianpharmacy.com, \n' to
work fine for testing body rules. The newline at the beginning causes SA to
treat the text that follows as body text with the default mime type of
text/plain; charset=us-ascii. Sometimes mime headers are needed and
occasionally a Subject, but not in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

--- Comment #7 from Giovanni Bechis  ---
(In reply to RW from comment #5)
> not parsing out "(sunkeymaker.com" is a step forward, but really the correct
> thing to do is to find "sunkeymaker.com".  
> 
> The parsing seems to be rather fragile, for example  
> 
>  printf  '\nbuy from canadianpharmacy.com. \n' |spamasssassin
> 
> works, but
> 
>  printf  '\nbuy from canadianpharmacy.com, \n' |spamasssassin
>  
> doesn't. (All I've done there is to change a full stop to a comma.)

Can you provide an email message that breaks this way ?
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

--- Comment #6 from Giovanni Bechis  ---
Created attachment 5494
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5494=edit
Remove parenthesis from uri if present

Remove parenthesis from uri, slightly tested with few emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

RW  changed:

   What|Removed |Added

 CC||rwmailli...@googlemail.com

--- Comment #5 from RW  ---
not parsing out "(sunkeymaker.com" is a step forward, but really the correct
thing to do is to find "sunkeymaker.com".  

The parsing seems to be rather fragile, for example  

 printf  '\nbuy from canadianpharmacy.com. \n' |spamasssassin

works, but

 printf  '\nbuy from canadianpharmacy.com, \n' |spamasssassin

doesn't. (All I've done there is to change a full stop to a comma.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6572

Giovanni Bechis  changed:

   What|Removed |Added

 CC||giova...@paclan.it

--- Comment #4 from Giovanni Bechis  ---
Created attachment 5492
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5492=edit
check for valid domain names

Parenthesis is not allowed in domain names, same for other chars.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6572

Kevin A. McGrail kmcgr...@pccc.com changed:

   What|Removed |Added

 CC||kmcgr...@pccc.com

--- Comment #2 from Kevin A. McGrail kmcgr...@pccc.com 2012-01-17 17:39:43 
UTC ---
Henrik, 

I was thinking that the RBL should just list www.(sunkeymaker.com,
www.(sunkeymaker.com) and www.sunkeymaker.com to fix the issue more so than
changing the lookup technology?

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6572

--- Comment #3 from Henrik Krohns h...@hege.li 2012-01-17 18:44:20 UTC ---
(In reply to comment #2)
 Henrik, 
 
 I was thinking that the RBL should just list www.(sunkeymaker.com,
 www.(sunkeymaker.com) and www.sunkeymaker.com to fix the issue more so than
 changing the lookup technology?

I was just wondering if that's even legal character for DNS or domains. Seems
strange that we would willingly parse the domain as such. Either ignore or fix
it..

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 6572] URI parser mishandles parenthesis

[bugzilla-daemon]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6572

Henrik Krohns h...@hege.li changed:

   What|Removed |Added

 CC||h...@hege.li

--- Comment #1 from Henrik Krohns h...@hege.li 2011-04-15 03:52:01 EDT ---
I'm personally patching this like this. It's certain not to break anything. I'm
not sure if some plugins are actually expecting bad behavior like this, no time
to find out..

---
/local/src/amavis/spamassassin-trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm  
Mon Dec 13 22:10:00 2010
+++ URIDNSBL.pm Fri Apr 15 10:40:26 2011
@@ -428,6 +428,8 @@

 # take the usable domains and add them to the ordered list
 while (my($host,$domain) = each( %{$info-{hosts}} )) {
+  $host =~ s/\(//g;
+  $domain =~ s/\(//g;
   if ($skip_domains-{$domain}) {
 dbg(uridnsbl: domain $domain in skip list);
   } else {

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.