[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Giovanni Bechis changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #12 from Giovanni Bechis --- Sendinglib/Mail/SpamAssassin/Plugin/OLEVBMacro.pm Transmitting file data .done Committing transaction... Committed revision 1904481. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 --- Comment #11 from Kevin A. McGrail --- +1 from me but with GB's inherent +1 you are good to go. RC4 here we come! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 --- Comment #10 from Bill Cole --- +1 from me for the new patch -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment #9 from Giovanni Bechis --- (In reply to Sidney Markowitz from comment #8) > I'm +1 for this latest patch. It adds just one return 0 exactly where it > needs to be and adds a few comments that for me complete my understanding of > the purpose of that sub and why this is the correct fix. > > I see no reason not to include this patch in 4.0.0 with no delay. This > latest patch is a simple, safe one line of code fix. > > Giovanni, are you +1 for this being included in 4.0.0 if others vote for > this too? I expect everyone who voted +1 on the earlier more complicated > patch will be +1 for this simpler and safer one. Yes, I am +1 for this being included in 4.0.0. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 --- Comment #8 from Sidney Markowitz --- I'm +1 for this latest patch. It adds just one return 0 exactly where it needs to be and adds a few comments that for me complete my understanding of the purpose of that sub and why this is the correct fix. I see no reason not to include this patch in 4.0.0 with no delay. This latest patch is a simple, safe one line of code fix. Giovanni, are you +1 for this being included in 4.0.0 if others vote for this too? I expect everyone who voted +1 on the earlier more complicated patch will be +1 for this simpler and safer one. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Giovanni Bechis changed: What|Removed |Added Attachment #5835|0 |1 is obsolete|| --- Comment #7 from Giovanni Bechis --- Created attachment 5836 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5836=edit Check for Office 2003 markers only when needed This patch checks for Office 2003 markers only when needed. I'm +1 just to get 4.0 rolling asap anyway and postpone the fix for 4.0.1. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 --- Comment #6 from Sidney Markowitz --- This is somewhat along Henrik's comment, but pushed a bit further. We already have $marker1 which is the file signature of a .doc file. sub _check_office_doc checks for exactly that. Isn't the real bug that _check_oldtype_doc or _check_markers doesn't return 0 right away if (index($data, $marker1) != 0) ? What is the reason for checking for anything else in _check_markers if the file does not start with the signature of a .doc file? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Henrik Krohns changed: What|Removed |Added CC||apa...@hege.li --- Comment #5 from Henrik Krohns --- I'm on the border with the last patch, because of yet one more likely unneeded config clause. Word doesn't care if the extension is doc or docx, so it would make much more sense to just detect the file legaciness automatically. But as the module is not even used by default and doesn't claim to be a virus scanner or anything serious, I'm +1 just to get 4.0 rolling asap. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 --- Comment #4 from Giovanni Bechis --- Created attachment 5835 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5835=edit Do checks on legacy file formats only when needed The issue was because we are scanning for doc markers also on docx documents and this file hits the marker by fault. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.0 CC||sid...@sidney.com --- Comment #3 from Sidney Markowitz --- This seems simple enough to allow in the 4.0.0 release, but I'll hold off on my vote and doing the commit until I have a chance to look up the documentation on the marker that the code to check for it is being removed. If someone has a link to it, please put it in a comment. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Bill Cole changed: What|Removed |Added CC||billc...@apache.org --- Comment #2 from Bill Cole --- +1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org --- Comment #1 from Kevin A. McGrail --- The patch looks fine and I'm +1 to commit it. Need another +1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8055] OLEVBMacro wrong detection
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8055 Giovanni Bechis changed: What|Removed |Added Summary|OLEVMMacro wrong detection |OLEVBMacro wrong detection -- You are receiving this mail because: You are the assignee for the bug.
