Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On 6/13/2019 1:13 PM, Henrik K wrote: > On Thu, Jun 13, 2019 at 12:59:16PM -0400, Kevin A. McGrail wrote: >> Just double checking since John mentioned the extra parens. > In this case.. too much parens.. qr_to_string was supposed to remove the > (?-xism:. > > We should really implement the (apache infra provided?) CI service that > would run commits through make test with ~5 perl versions betweek 5.10 - > 5.28. Manually it's so time consuming. Love it. Can you drive it or get someone to drive it? We need CI again. I've missed it since Jenkins failed catastrophically. -- Kevin A. McGrail Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On Thu, Jun 13, 2019 at 12:59:16PM -0400, Kevin A. McGrail wrote: > > Just double checking since John mentioned the extra parens. In this case.. too much parens.. qr_to_string was supposed to remove the (?-xism:. We should really implement the (apache infra provided?) CI service that would run commits through make test with ~5 perl versions betweek 5.10 - 5.28. Manually it's so time consuming.
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On 6/13/2019 12:44 PM, Henrik K wrote: >> Henrik, your thoughts on this with the sa-compile changes? The key >> point I need is should it block 3.4.3 or did you already fix it? Or is >> it just a rule issue? > I thought it was already established that I fixed it and rc3 needs to > rolled. > Just double checking since John mentioned the extra parens. -- Kevin A. McGrail Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On Thu, Jun 13, 2019 at 12:42:17PM -0400, Kevin A. McGrail wrote: > On 6/13/2019 11:33 AM, John Hardin wrote: > > On Thu, 13 Jun 2019, Kevin A. McGrail wrote: > > > >> While running sa-update, I noticed a number of lines about replace tag > >> compilation errors. > >> > >> Attached is an output from 3.4.2 and an output from 3.4.3. > >> > >> Henrik, any thoughts? > > > > It looks like appending another paren at the end of the entire RE > > would fix it. > > > Henrik, your thoughts on this with the sa-compile changes? The key > point I need is should it block 3.4.3 or did you already fix it? Or is > it just a rule issue? I thought it was already established that I fixed it and rc3 needs to rolled.
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On 6/13/2019 11:33 AM, John Hardin wrote: > On Thu, 13 Jun 2019, Kevin A. McGrail wrote: > >> While running sa-update, I noticed a number of lines about replace tag >> compilation errors. >> >> Attached is an output from 3.4.2 and an output from 3.4.3. >> >> Henrik, any thoughts? > > It looks like appending another paren at the end of the entire RE > would fix it. > Henrik, your thoughts on this with the sa-compile changes? The key point I need is should it block 3.4.3 or did you already fix it? Or is it just a rule issue? -- Kevin A. McGrail Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On Thu, 13 Jun 2019, Kevin A. McGrail wrote: While running sa-update, I noticed a number of lines about replace tag compilation errors. Attached is an output from 3.4.2 and an output from 3.4.3. Henrik, any thoughts? It looks like appending another paren at the end of the entire RE would fix it. -- John Hardin KA7OHZhttp://www.impsec.org/~jhardin/ jhar...@impsec.orgFALaholic #11174 pgpk -a jhar...@impsec.org key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79 --- There is no better measure of the unthinking contempt of the environmentalist movement for civilization than their call to turn off the lights and sit in the dark.-- Sultan Knish --- 5 days until SWMBO's Birthday
Re: Jun 13 10:47:12.641 [9171] info: replacetags: regexp compilation failed - Possible Blocker on SA 3.4.3
On Thu, 13 Jun 2019, Kevin A. McGrail wrote: While running sa-update, I noticed a number of lines about replace tag compilation errors. Attached is an output from 3.4.2 and an output from 3.4.3. Doesn't happen on a trunk lint... ? -- John Hardin KA7OHZhttp://www.impsec.org/~jhardin/ jhar...@impsec.orgFALaholic #11174 pgpk -a jhar...@impsec.org key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79 --- There is no better measure of the unthinking contempt of the environmentalist movement for civilization than their call to turn off the lights and sit in the dark.-- Sultan Knish --- 5 days until SWMBO's Birthday
