Re: IndentationCheck of checkstyle

[Ted Yu]

Right. 

Pardon my carelessness. 

> On Dec 29, 2015, at 9:58 PM, Reynold Xin  wrote:
> 
> OK to close the loop - this thread has nothing to do with Spark?
> 
> 
>> On Tue, Dec 29, 2015 at 9:55 PM, Ted Yu  wrote:
>> Oops, wrong list :-)
>> 
>>> On Dec 29, 2015, at 9:48 PM, Reynold Xin  wrote:
>>> 
>>> +Herman
>>> 
>>> Is this coming from the newly merged Hive parser?
>>> 
>>> 
>>> 
 On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang  wrote:
 
 
 format issue I think, go ahead
 
 
 
 
 At 2015-12-30 13:36:05, "Ted Yu"  wrote:
 Hi,
 I noticed that there are a lot of checkstyle warnings in the following 
 form:
 
 >>> source="com.puppycrawl.tools.checkstyle.   
 checks.indentation.IndentationCheck"/>
 
 To my knowledge, we use two spaces for each tab. Not sure why all of a 
 sudden we have so many IndentationCheck warnings:
 
 grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
 3133   52645  678294
 
 If there is no objection, I would create a JIRA and relax IndentationCheck 
 warning.
 
 Cheers
> 

IndentationCheck of checkstyle

[Ted Yu]

Hi,
I noticed that there are a lot of checkstyle warnings in the following form:



To my knowledge, we use two spaces for each tab. Not sure why all of a
sudden we have so many IndentationCheck warnings:

grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
3133   52645  678294

If there is no objection, I would create a JIRA and relax IndentationCheck
warning.

Cheers

Re: IndentationCheck of checkstyle

[Reynold Xin]

OK to close the loop - this thread has nothing to do with Spark?


On Tue, Dec 29, 2015 at 9:55 PM, Ted Yu  wrote:

> Oops, wrong list :-)
>
> On Dec 29, 2015, at 9:48 PM, Reynold Xin  wrote:
>
> +Herman
>
> Is this coming from the newly merged Hive parser?
>
>
>
> On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang 
> wrote:
>
>>
>>
>> format issue I think, go ahead
>>
>>
>>
>>
>> At 2015-12-30 13:36:05, "Ted Yu"  wrote:
>>
>> Hi,
>> I noticed that there are a lot of checkstyle warnings in the following
>> form:
>>
>> > source="com.puppycrawl.tools.checkstyle.
>> checks.indentation.IndentationCheck"/>
>>
>> To my knowledge, we use two spaces for each tab. Not sure why all of a
>> sudden we have so many IndentationCheck warnings:
>>
>> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
>> 3133   52645  678294
>>
>> If there is no objection, I would create a JIRA and
>> relax IndentationCheck warning.
>>
>> Cheers
>>
>>
>>
>>
>>
>
>

Re: IndentationCheck of checkstyle

[Ted Yu]

Oops, wrong list :-)

> On Dec 29, 2015, at 9:48 PM, Reynold Xin  wrote:
> 
> +Herman
> 
> Is this coming from the newly merged Hive parser?
> 
> 
> 
>> On Tue, Dec 29, 2015 at 9:46 PM, Allen Zhang  wrote:
>> 
>> 
>> format issue I think, go ahead
>> 
>> 
>> 
>> 
>> At 2015-12-30 13:36:05, "Ted Yu"  wrote:
>> Hi,
>> I noticed that there are a lot of checkstyle warnings in the following form:
>> 
>> > source="com.puppycrawl.tools.checkstyle.   
>> checks.indentation.IndentationCheck"/>
>> 
>> To my knowledge, we use two spaces for each tab. Not sure why all of a 
>> sudden we have so many IndentationCheck warnings:
>> 
>> grep 'hild have incorrect indentati' trunkCheckstyle.xml | wc
>> 3133   52645  678294
>> 
>> If there is no objection, I would create a JIRA and relax IndentationCheck 
>> warning.
>> 
>> Cheers
>