Re: [DISCUSS] SPIP: Testing Framework for Spark UI Javascript files

2023-11-24 Thread Kent Yao
Thank you all. I will start an official vote for this SPIP.

Kent

On 2023/11/22 03:05:42 Mridul Muralidharan wrote:
> This should be a very good addition !
> 
> Regards,
> Mridul
> 
> On Tue, Nov 21, 2023 at 7:46 PM Dongjoon Hyun 
> wrote:
> 
> > Thank you for proposing a new UI test framework for Apache Spark 4.0.
> >
> > It looks very useful.
> >
> > Thanks,
> > Dongjoon.
> >
> >
> > On Tue, Nov 21, 2023 at 1:51 AM Kent Yao  wrote:
> >
> >> Hi Spark Dev,
> >>
> >> This is a call to discuss a new SPIP: Testing Framework for
> >> Spark UI Javascript files [1]. The SPIP aims to improve the test
> >> coverage and develop experience for Spark UI-related javascript
> >> codes.
> >> The Jest [2], a JavaScript Testing Framework licensed under MIT, will
> >> be used to build this dev and test-only module.
> >> There is also a W.I.P. pull request [3] to show what it would be like.
> >>
> >> This thread will be open for at least the next 72 hours. Suggestions
> >> are welcome.If there is no veto found, I will close this thread after
> >> 2023-11-24 18:00(+08:00) and raise a new thread for voting.
> >>
> >> Thanks,
> >> Kent Yao
> >>
> >> [1]
> >> https://docs.google.com/document/d/1hWl5Q2CNNOjN5Ubyoa28XmpJtDyD9BtGtiEG2TT94rg/edit?usp=sharing
> >> [2] https://github.com/jestjs/jest
> >> [3] https://github.com/apache/spark/pull/43903
> >>
> >> -
> >> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
> >>
> >>
> 

-
To unsubscribe e-mail: dev-unsubscr...@spark.apache.org



Re: [DISCUSS] SPIP: Testing Framework for Spark UI Javascript files

2023-11-21 Thread Mridul Muralidharan
This should be a very good addition !

Regards,
Mridul

On Tue, Nov 21, 2023 at 7:46 PM Dongjoon Hyun 
wrote:

> Thank you for proposing a new UI test framework for Apache Spark 4.0.
>
> It looks very useful.
>
> Thanks,
> Dongjoon.
>
>
> On Tue, Nov 21, 2023 at 1:51 AM Kent Yao  wrote:
>
>> Hi Spark Dev,
>>
>> This is a call to discuss a new SPIP: Testing Framework for
>> Spark UI Javascript files [1]. The SPIP aims to improve the test
>> coverage and develop experience for Spark UI-related javascript
>> codes.
>> The Jest [2], a JavaScript Testing Framework licensed under MIT, will
>> be used to build this dev and test-only module.
>> There is also a W.I.P. pull request [3] to show what it would be like.
>>
>> This thread will be open for at least the next 72 hours. Suggestions
>> are welcome.If there is no veto found, I will close this thread after
>> 2023-11-24 18:00(+08:00) and raise a new thread for voting.
>>
>> Thanks,
>> Kent Yao
>>
>> [1]
>> https://docs.google.com/document/d/1hWl5Q2CNNOjN5Ubyoa28XmpJtDyD9BtGtiEG2TT94rg/edit?usp=sharing
>> [2] https://github.com/jestjs/jest
>> [3] https://github.com/apache/spark/pull/43903
>>
>> -
>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
>>
>>


Re: [DISCUSS] SPIP: Testing Framework for Spark UI Javascript files

2023-11-21 Thread Wenchen Fan
+1, very useful!

On Wed, Nov 22, 2023 at 10:29 AM Dongjoon Hyun 
wrote:

> Thank you for proposing a new UI test framework for Apache Spark 4.0.
>
> It looks very useful.
>
> Thanks,
> Dongjoon.
>
>
> On Tue, Nov 21, 2023 at 1:51 AM Kent Yao  wrote:
>
>> Hi Spark Dev,
>>
>> This is a call to discuss a new SPIP: Testing Framework for
>> Spark UI Javascript files [1]. The SPIP aims to improve the test
>> coverage and develop experience for Spark UI-related javascript
>> codes.
>> The Jest [2], a JavaScript Testing Framework licensed under MIT, will
>> be used to build this dev and test-only module.
>> There is also a W.I.P. pull request [3] to show what it would be like.
>>
>> This thread will be open for at least the next 72 hours. Suggestions
>> are welcome.If there is no veto found, I will close this thread after
>> 2023-11-24 18:00(+08:00) and raise a new thread for voting.
>>
>> Thanks,
>> Kent Yao
>>
>> [1]
>> https://docs.google.com/document/d/1hWl5Q2CNNOjN5Ubyoa28XmpJtDyD9BtGtiEG2TT94rg/edit?usp=sharing
>> [2] https://github.com/jestjs/jest
>> [3] https://github.com/apache/spark/pull/43903
>>
>> -
>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
>>
>>


Re: [DISCUSS] SPIP: Testing Framework for Spark UI Javascript files

2023-11-21 Thread Dongjoon Hyun
Thank you for proposing a new UI test framework for Apache Spark 4.0.

It looks very useful.

Thanks,
Dongjoon.


On Tue, Nov 21, 2023 at 1:51 AM Kent Yao  wrote:

> Hi Spark Dev,
>
> This is a call to discuss a new SPIP: Testing Framework for
> Spark UI Javascript files [1]. The SPIP aims to improve the test
> coverage and develop experience for Spark UI-related javascript
> codes.
> The Jest [2], a JavaScript Testing Framework licensed under MIT, will
> be used to build this dev and test-only module.
> There is also a W.I.P. pull request [3] to show what it would be like.
>
> This thread will be open for at least the next 72 hours. Suggestions
> are welcome.If there is no veto found, I will close this thread after
> 2023-11-24 18:00(+08:00) and raise a new thread for voting.
>
> Thanks,
> Kent Yao
>
> [1]
> https://docs.google.com/document/d/1hWl5Q2CNNOjN5Ubyoa28XmpJtDyD9BtGtiEG2TT94rg/edit?usp=sharing
> [2] https://github.com/jestjs/jest
> [3] https://github.com/apache/spark/pull/43903
>
> -
> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
>
>