[jira] [Commented] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Dian Fu (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718139#comment-14718139
 ] 

Dian Fu commented on SQOOP-2538:


Skip the review board as the patch is very simple.

 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2489) Sqoop2: Hive with Parquet in Kite Connector

2015-08-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718164#comment-14718164
 ] 

ASF GitHub Bot commented on SQOOP-2489:
---

GitHub user sleefd opened a pull request:

https://github.com/apache/sqoop/pull/8

fix the problem of NoClassDefFoundError of HiveOutputFormat when impo…

for jira SQOOP-2489 @abec 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sleefd/sqoop sqoop2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sqoop/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 3baa7430c6fcac8d0847aaa0c49fead4fadce372
Author: slee sle...@gmail.com
Date:   2015-08-28T07:44:50Z

fix the problem of NoClassDefFoundError of HiveOutputFormat when import or 
export to hive through kite connector




 Sqoop2: Hive with Parquet in Kite Connector
 ---

 Key: SQOOP-2489
 URL: https://issues.apache.org/jira/browse/SQOOP-2489
 Project: Sqoop
  Issue Type: Bug
  Components: sqoop2-kite-connector
Affects Versions: 1.99.6
Reporter: Abraham Elmahrek
 Fix For: 1.99.7


 {code}
 java.lang.NoClassDefFoundError: org/apache/hadoop/hive/ql/io/HiveOutputFormat
   at java.lang.ClassLoader.defineClass1(Native Method)
   at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
   at 
 java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
   at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
   at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
   at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
   at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
   at java.lang.Class.forName0(Native Method)
   at java.lang.Class.forName(Class.java:190)
   at 
 org.kitesdk.data.spi.hive.HiveUtils.getHiveParquetOutputFormat(HiveUtils.java:446)
   at org.kitesdk.data.spi.hive.HiveUtils.clinit(HiveUtils.java:91)
   at 
 org.kitesdk.data.spi.hive.HiveManagedMetadataProvider.create(HiveManagedMetadataProvider.java:83)
   at 
 org.kitesdk.data.spi.hive.HiveManagedDatasetRepository.create(HiveManagedDatasetRepository.java:77)
   at org.kitesdk.data.Datasets.create(Datasets.java:239)
   at org.kitesdk.data.Datasets.create(Datasets.java:307)
   at org.kitesdk.data.Datasets.create(Datasets.java:335)
   at 
 org.apache.sqoop.connector.kite.KiteDatasetExecutor.createDataset(KiteDatasetExecutor.java:70)
   at 
 org.apache.sqoop.connector.kite.KiteLoader.getExecutor(KiteLoader.java:52)
   at org.apache.sqoop.connector.kite.KiteLoader.load(KiteLoader.java:62)
   at org.apache.sqoop.connector.kite.KiteLoader.load(KiteLoader.java:36)
   at 
 org.apache.sqoop.job.mr.SqoopOutputFormatLoadExecutor$ConsumerThread.run(SqoopOutputFormatLoadExecutor.java:250)
   at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
   at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:745)
 Caused by: java.lang.ClassNotFoundException: 
 org.apache.hadoop.hive.ql.io.HiveOutputFormat
   at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
   at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
   ... 31 more
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] sqoop pull request: fix the problem of NoClassDefFoundError of Hiv...

2015-08-28 Thread sleefd
GitHub user sleefd opened a pull request:

https://github.com/apache/sqoop/pull/8

fix the problem of NoClassDefFoundError of HiveOutputFormat when impo…

for jira SQOOP-2489 @abec 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sleefd/sqoop sqoop2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sqoop/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 3baa7430c6fcac8d0847aaa0c49fead4fadce372
Author: slee sle...@gmail.com
Date:   2015-08-28T07:44:50Z

fix the problem of NoClassDefFoundError of HiveOutputFormat when import or 
export to hive through kite connector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Dian Fu (JIRA)
Dian Fu created SQOOP-2538:
--

 Summary: Sqoop2: Use the table name variable instead of the table 
name string
 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu


In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
table name string instead of the table name variable when referring a table 
name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2538:
---
Attachment: SQOOP-2538.001.patch

 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2538:
---
Fix Version/s: 1.99.7

 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SQOOP-2540) Sqoop2: Add RepositoryProvider for MySQL

2015-08-28 Thread Dian Fu (JIRA)
Dian Fu created SQOOP-2540:
--

 Summary: Sqoop2: Add RepositoryProvider for MySQL
 Key: SQOOP-2540
 URL: https://issues.apache.org/jira/browse/SQOOP-2540
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu


As MySQL repository is already supported, we should add RepositoryProvider for 
MySQL to make it testable using MySQL repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Jarek Jarcec Cecho (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718270#comment-14718270
 ] 

Jarek Jarcec Cecho commented on SQOOP-2538:
---

+1

 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718271#comment-14718271
 ] 

ASF subversion and git services commented on SQOOP-2538:


Commit adc4367d9b37e4a87f97dfd069967f62a8d4611f in sqoop's branch 
refs/heads/sqoop2 from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=adc4367 ]

SQOOP-2538: Sqoop2: Use the table name variable instead of the table name string

(Dian Fu via Jarek Jarcec Cecho)


 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718268#comment-14718268
 ] 

Hudson commented on SQOOP-2531:
---

FAILURE: Integrated in Sqoop-hadoop20 #1012 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1012/])
SQOOP-2531: readlink -f not supported on OS X (jarcec: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.gita=commith=03ed21b4f1958a4aeba33ace2a3f06ac34626f9d)
* src/scripts/tool-script.sh.template


 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
Assignee: Stuart Williams
  Labels: newbie, patch
 Fix For: 1.4.7

 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2539) Sqoop2: Enforce resource name not null when creating table

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2539:
---
Issue Type: Sub-task  (was: Bug)
Parent: SQOOP-2419

 Sqoop2: Enforce resource name not null when creating table
 --

 Key: SQOOP-2539
 URL: https://issues.apache.org/jira/browse/SQOOP-2539
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Dian Fu
Assignee: Dian Fu

 Currently resource name such as job name, connector name or link name can be 
 null. We should enforce that these resource names cannot be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718289#comment-14718289
 ] 

Hudson commented on SQOOP-2531:
---

FAILURE: Integrated in Sqoop-hadoop23 #1215 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1215/])
SQOOP-2531: readlink -f not supported on OS X (jarcec: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.gita=commith=03ed21b4f1958a4aeba33ace2a3f06ac34626f9d)
* src/scripts/tool-script.sh.template


 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
Assignee: Stuart Williams
  Labels: newbie, patch
 Fix For: 1.4.7

 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SQOOP-2539) Sqoop2: Enforce resource name not null when creating table

2015-08-28 Thread Dian Fu (JIRA)
Dian Fu created SQOOP-2539:
--

 Summary: Sqoop2: Enforce resource name not null when creating table
 Key: SQOOP-2539
 URL: https://issues.apache.org/jira/browse/SQOOP-2539
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu


Currently resource name such as job name, connector name or link name can be 
null. We should enforce that these resource names cannot be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2540) Sqoop2: Add RepositoryProvider for MySQL

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2540:
---
Attachment: SQOOP-2540.001.patch

 Sqoop2: Add RepositoryProvider for MySQL
 

 Key: SQOOP-2540
 URL: https://issues.apache.org/jira/browse/SQOOP-2540
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2540.001.patch


 As MySQL repository is already supported, we should add RepositoryProvider 
 for MySQL to make it testable using MySQL repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2537) Sqoop2: Use object name instead of object id for the name filed in MResource

2015-08-28 Thread Jarek Jarcec Cecho (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718260#comment-14718260
 ] 

Jarek Jarcec Cecho commented on SQOOP-2537:
---

The {{NullPointerException}} seems relevant [~dian.fu], would you mind taking a 
look?

{code}
org.apache.sqoop.common.SqoopException: CLIENT_0001:Server has returned 
exception
at 
org.apache.sqoop.client.request.ResourceRequest.doHttpRequest(ResourceRequest.java:135)
at 
org.apache.sqoop.client.request.ResourceRequest.doHttpRequest(ResourceRequest.java:68)
at 
org.apache.sqoop.client.request.ResourceRequest.get(ResourceRequest.java:177)
at 
org.apache.sqoop.client.request.LinkResourceRequest.read(LinkResourceRequest.java:52)
at 
org.apache.sqoop.client.request.SqoopResourceRequests.readLink(SqoopResourceRequests.java:113)
at org.apache.sqoop.client.SqoopClient.getLink(SqoopClient.java:308)
at org.apache.sqoop.client.SqoopClient.createJob(SqoopClient.java:418)
at 
org.apache.sqoop.integration.connector.hdfs.AppendModeTest.test(AppendModeTest.java:47)
Caused by: java.lang.NullPointerException: 
at 
org.apache.sqoop.security.authorization.AuthorizationEngine.checkPrivilege(AuthorizationEngine.java:191)
at 
org.apache.sqoop.security.authorization.AuthorizationEngine.readLink(AuthorizationEngine.java:86)
at 
org.apache.sqoop.handler.LinkRequestHandler.getLinks(LinkRequestHandler.java:244)
at 
org.apache.sqoop.handler.LinkRequestHandler.handleEvent(LinkRequestHandler.java:68)
at 
org.apache.sqoop.server.v1.LinkServlet.handleGetRequest(LinkServlet.java:68)
at 
org.apache.sqoop.server.SqoopProtocolServlet.doGet(SqoopProtocolServlet.java:50)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at 
org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:572)
at 
org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.doFilter(DelegationTokenAuthenticationFilter.java:269)
at 
org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:542)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
at 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:615)
at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:861)
at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:606)
at 
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
at java.lang.Thread.run(Thread.java:745)
{code}

 Sqoop2: Use object name instead of object id for the name filed in MResource
 

 Key: SQOOP-2537
 URL: https://issues.apache.org/jira/browse/SQOOP-2537
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2537.001.patch


 Currently the meaning of the name field in MResource isn't consistent. Some 
 places assume this field means the object name of the resource, such as in 
 AuthorizationRequestHandler. Some places assume this field means the object 
 id of the resource, such as in AuthorizationEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2537) Sqoop2: Use object name instead of object id for the name filed in MResource

2015-08-28 Thread Dian Fu (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718293#comment-14718293
 ] 

Dian Fu commented on SQOOP-2537:


Thanks [~jarcec] for review. The reason to the exceptions is that resource name 
such as job name, link name or connector name is null. Have created SQOOP-2539 
to limit that resource name cannot be null.

 Sqoop2: Use object name instead of object id for the name filed in MResource
 

 Key: SQOOP-2537
 URL: https://issues.apache.org/jira/browse/SQOOP-2537
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2537.001.patch


 Currently the meaning of the name field in MResource isn't consistent. Some 
 places assume this field means the object name of the resource, such as in 
 AuthorizationRequestHandler. Some places assume this field means the object 
 id of the resource, such as in AuthorizationEngine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718328#comment-14718328
 ] 

Hudson commented on SQOOP-2531:
---

FAILURE: Integrated in Sqoop-hadoop100 #979 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/979/])
SQOOP-2531: readlink -f not supported on OS X (jarcec: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.gita=commith=03ed21b4f1958a4aeba33ace2a3f06ac34626f9d)
* src/scripts/tool-script.sh.template


 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
Assignee: Stuart Williams
  Labels: newbie, patch
 Fix For: 1.4.7

 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2538) Sqoop2: Use the table name variable instead of the table name string

2015-08-28 Thread Sqoop QA bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718190#comment-14718190
 ] 

Sqoop QA bot commented on SQOOP-2538:
-

Testing file 
[SQOOP-2538.001.patch|https://issues.apache.org/jira/secure/attachment/12752949/SQOOP-2538.001.patch]
 against branch sqoop2 took 0:53:09.394072.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1408 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1649/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1649/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 73 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1649/console].

This message is automatically generated.

 Sqoop2: Use the table name variable instead of the table name string
 

 Key: SQOOP-2538
 URL: https://issues.apache.org/jira/browse/SQOOP-2538
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2538.001.patch


 In {{DerbySchemaUpgradeQuery}}, there are some places which directly use the 
 table name string instead of the table name variable when referring a table 
 name. This makes it difficult to maintain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 37868: Sqoop2: Use object name instead of object id for the name filed in MResource

2015-08-28 Thread Jarek Cecho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37868/#review96846
---


Generally it looks fine, I have one nit below and then it seems that precommit 
hook is complaining about failing integration tests.


security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java
 (lines 39 - 49)
https://reviews.apache.org/r/37868/#comment152529

Nit: Do we need the interim variables here? Can we just do:

case CONNECTOR: return repository.findConnector(id).getUniqueName();
case LINK: ...


Jarcec

- Jarek Cecho


On Aug. 28, 2015, 2:47 a.m., Dian Fu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37868/
 ---
 
 (Updated Aug. 28, 2015, 2:47 a.m.)
 
 
 Review request for Sqoop.
 
 
 Bugs: SQOOP-2537
 https://issues.apache.org/jira/browse/SQOOP-2537
 
 
 Repository: sqoop-sqoop2
 
 
 Description
 ---
 
 Currently the meaning of the name field in MResource isn't consistent. Some 
 places assume this field means the object name of the resource, such as in 
 AuthorizationRequestHandler. Some places assume this field means the object 
 id of the resource, such as in AuthorizationEngine.
 
 
 Diffs
 -
 
   
 security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java
  bebbe91 
   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 
 23f6c63 
   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 
 13ebb35 
   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 
 aa7e5ff 
   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 
 f2a6758 
 
 Diff: https://reviews.apache.org/r/37868/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dian Fu
 




[jira] [Commented] (SQOOP-2540) Sqoop2: Add RepositoryProvider for MySQL

2015-08-28 Thread Sqoop QA bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718356#comment-14718356
 ] 

Sqoop QA bot commented on SQOOP-2540:
-

Testing file 
[SQOOP-2540.001.patch|https://issues.apache.org/jira/secure/attachment/12752970/SQOOP-2540.001.patch]
 against branch sqoop2 took 0:52:56.509692.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1408 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1650/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1650/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 73 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1650/console].

This message is automatically generated.

 Sqoop2: Add RepositoryProvider for MySQL
 

 Key: SQOOP-2540
 URL: https://issues.apache.org/jira/browse/SQOOP-2540
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7

 Attachments: SQOOP-2540.001.patch


 As MySQL repository is already supported, we should add RepositoryProvider 
 for MySQL to make it testable using MySQL repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread Jarek Jarcec Cecho (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718254#comment-14718254
 ] 

Jarek Jarcec Cecho commented on SQOOP-2531:
---

As we agreed that current patch is okej, I'll push it - we can take the 
refactoring discussion to a separate JIRA :)

 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
  Labels: newbie, patch
 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718255#comment-14718255
 ] 

ASF subversion and git services commented on SQOOP-2531:


Commit 03ed21b4f1958a4aeba33ace2a3f06ac34626f9d in sqoop's branch 
refs/heads/trunk from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=03ed21b ]

SQOOP-2531: readlink -f not supported on OS X

(Stuart Williams via Jarek Jarcec Cecho)


 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
  Labels: newbie, patch
 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2540) Sqoop2: Add RepositoryProvider for MySQL

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2540:
---
Fix Version/s: 1.99.7

 Sqoop2: Add RepositoryProvider for MySQL
 

 Key: SQOOP-2540
 URL: https://issues.apache.org/jira/browse/SQOOP-2540
 Project: Sqoop
  Issue Type: Bug
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7


 As MySQL repository is already supported, we should add RepositoryProvider 
 for MySQL to make it testable using MySQL repository.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2531) readlink -f not supported on OS X

2015-08-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718323#comment-14718323
 ] 

Hudson commented on SQOOP-2531:
---

FAILURE: Integrated in Sqoop-hadoop200 #1019 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1019/])
SQOOP-2531: readlink -f not supported on OS X (jarcec: 
https://git-wip-us.apache.org/repos/asf?p=sqoop.gita=commith=03ed21b4f1958a4aeba33ace2a3f06ac34626f9d)
* src/scripts/tool-script.sh.template


 readlink -f not supported on OS X
 -

 Key: SQOOP-2531
 URL: https://issues.apache.org/jira/browse/SQOOP-2531
 Project: Sqoop
  Issue Type: Bug
  Components: build, tools
Affects Versions: 1.4.6
 Environment: OS X
Reporter: Stuart Williams
Assignee: Stuart Williams
  Labels: newbie, patch
 Fix For: 1.4.7

 Attachments: SQOOP-2531.patch


 Tool scripts (sqoop-*) rely on readlink -f to get the path to the script, 
 which is not an available readlink option on OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2539) Sqoop2: Enforce resource name not null when creating table

2015-08-28 Thread Dian Fu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated SQOOP-2539:
---
Fix Version/s: 1.99.7

 Sqoop2: Enforce resource name not null when creating table
 --

 Key: SQOOP-2539
 URL: https://issues.apache.org/jira/browse/SQOOP-2539
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7


 Currently resource name such as job name, connector name or link name can be 
 null. We should enforce that these resource names cannot be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 37886: Sqoop2: Add RepositoryProvider for MySQL

2015-08-28 Thread Dian Fu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37886/
---

Review request for Sqoop.


Bugs: SQOOP-2540
https://issues.apache.org/jira/browse/SQOOP-2540


Repository: sqoop-sqoop2


Description
---

As MySQL repository is already supported, we should add RepositoryProvider for 
MySQL to make it testable using MySQL repository.


Diffs
-

  
common-test/src/main/java/org/apache/sqoop/common/test/repository/DerbyRepositoryProvider.java
 760f74e 
  
common-test/src/main/java/org/apache/sqoop/common/test/repository/MysqlRepositoryProvider.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/37886/diff/


Testing
---


Thanks,

Dian Fu



[jira] [Commented] (SQOOP-1959) sqoop failed to import data from oracle whether specify the driver option or not

2015-08-28 Thread philip (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14719327#comment-14719327
 ] 

philip commented on SQOOP-1959:
---

Whats the resolution here? Could you kindly comment?

 sqoop failed to import data from oracle whether specify the driver option or 
 not
 

 Key: SQOOP-1959
 URL: https://issues.apache.org/jira/browse/SQOOP-1959
 Project: Sqoop
  Issue Type: Bug
  Components: connectors/oracle
Affects Versions: 1.4.5
 Environment: CentOS release 5.5 
 sqoop : 1.4.5 
 hive: 0.11.0 
 hadoop: 1.2.1 
 jdk: 1.7.0_71 
 oracle: 10.0.1.0 
 oracle jdbc driver: ojdbc6.jar
Reporter: daniel
   Original Estimate: 72h
  Remaining Estimate: 72h

 The ojdbc6.jar works fine through the PLSQL client. While trying to import 
 data from oracle, the *sqoop import* didn't work whether specifying the 
 *-driver option* or not. 
 h3. (1) use the default driver (oracle.jdbc.OracleDriver ), 
 a) {color:red}can't get tables.{color} 
 *sqoop list-tables --connect jdbc:oracle:thin:@IP:HOST:DB01 --username XX 
 --password XX*
 {noformat}
 14/12/26 05:04:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5
 14/12/26 05:04:32 WARN tool.BaseSqoopTool: Setting your password on the 
 command-line is insecure. Consider using -P instead.
 14/12/26 05:04:32 INFO oracle.OraOopManagerFactory: Data Connector for Oracle 
 and Hadoop is disabled.
 14/12/26 05:04:32 INFO manager.SqlManager: Using default fetchSize of 1000
 14/12/26 05:04:33 INFO manager.OracleManager: Time zone has been set to GMT
 {noformat}
 b) {color:red}
 ERROR tool.ImportTool: Imported Failed: There is no column found in the 
 target table TABLE01. Please ensure that your table name is correct.
 {color}
 *sqoop import --driver oracle.jdbc.driver.OracleDriver --hive-import 
 --connect jdbc:oracle:thin:@IP:HOST:SID --username XX --password XX --verbose 
 -m 1  --table TABLE01*
 {noformat}
 ..
 14/12/26 05:36:55 DEBUG sqoop.ConnFactory: Instantiated ConnManager 
 org.apache.sqoop.manager.OracleManager@b15b5a
 14/12/26 05:36:55 INFO tool.CodeGenTool: Beginning code generation
 14/12/26 05:36:55 DEBUG manager.OracleManager: Using column names query: 
 SELECT t.* FROM TABLE01 t WHERE 1=0
 14/12/26 05:36:55 DEBUG manager.SqlManager: Execute getColumnInfoRawQuery : 
 SELECT t.* FROM TABLE01 t WHERE 1=0
 14/12/26 05:36:56 DEBUG manager.OracleManager: Creating a new connection for 
 jdbc:oracle:thin:@IP:HOST:SID, using username: XX
 14/12/26 05:36:56 DEBUG manager.OracleManager: No connection paramenters 
 specified. Using regular API for making connection.
 14/12/26 05:36:56 INFO manager.OracleManager: Time zone has been set to GMT
 14/12/26 05:36:56 DEBUG manager.SqlManager: Using fetchSize for next query: 
 1000
 14/12/26 05:36:56 INFO manager.SqlManager: Executing SQL statement: SELECT 
 t.* FROM TABLE01 t WHERE 1=0
 {color:red}
 14/12/26 05:36:56 DEBUG manager.OracleManager$ConnCache: Caching released 
 connection for jdbc:oracle:thin:@IP:HOST:SID/XX
 14/12/26 05:36:56 ERROR tool.ImportTool: Imported Failed: There is no column 
 found in the target table TABLE01. Please ensure that your table name is 
 correct.
 {color}
 {noformat}
 h3. (2) specify the --driver  option: --driver 
 oracle.jdbc.driver.OracleDriver
 a) {color:red}correctly list the tables of DB01{color}
 *sqoop list-tables --driver oracle.jdbc.driver.OracleDriver --connect 
 jdbc:oracle:thin:@IP:HOST:SID --username XX --password XX*
 {noformat}
 14/12/26 05:32:13 INFO manager.SqlManager: Using default fetchSize of 1000
 WWV_FLOW_DUAL100
 WWV_FLOW_LOV_TEMP
 WWV_FLOW_TEMP_TABLE
 TABLE01
 ..
 {noformat}
 b) {color:red}same as issues 
 [https://issues.apache.org/jira/browse/SQOOP-457], ORA-00933: SQL command not 
 properly ended{color}
 *sqoop import --driver oracle.jdbc.driver.OracleDriver --hive-import 
 --connect jdbc:oracle:thin:@IP:HOST:SID --username XX --password XX --verbose 
 -m 1  --table TABLE01*
 {noformat}
 14/12/26 05:33:49 INFO manager.SqlManager: Executing SQL statement: SELECT 
 t.* FROM TABLE01 AS t WHERE 1=0
 14/12/26 05:33:49 ERROR manager.SqlManager: Error executing statement: 
 java.sql.SQLSyntaxErrorException: ORA-00933: SQL command not properly ended
 java.sql.SQLSyntaxErrorException: ORA-00933: SQL command not properly ended
   at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:439)
   at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:395)
   at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:802)
   ..
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2543:
---

 Summary: Sqoop2: Create sqoop mini cluster factory
 Key: SQOOP-2543
 URL: https://issues.apache.org/jira/browse/SQOOP-2543
 Project: Sqoop
  Issue Type: Bug
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Elmahrek updated SQOOP-2543:

Attachment: (was: SQOOP-2543.patch)

 Sqoop2: Create sqoop mini cluster factory and provider
 --

 Key: SQOOP-2543
 URL: https://issues.apache.org/jira/browse/SQOOP-2543
 Project: Sqoop
  Issue Type: Bug
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Elmahrek updated SQOOP-2543:

Attachment: SQOOP-2543.patch

 Sqoop2: Create sqoop mini cluster factory and provider
 --

 Key: SQOOP-2543
 URL: https://issues.apache.org/jira/browse/SQOOP-2543
 Project: Sqoop
  Issue Type: Bug
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7

 Attachments: SQOOP-2543.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Elmahrek updated SQOOP-2543:

Summary: Sqoop2: Create sqoop mini cluster factory and provider  (was: 
Sqoop2: Create sqoop mini cluster factory)

 Sqoop2: Create sqoop mini cluster factory and provider
 --

 Key: SQOOP-2543
 URL: https://issues.apache.org/jira/browse/SQOOP-2543
 Project: Sqoop
  Issue Type: Bug
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2539) Sqoop2: Enforce resource name not null when creating table

2015-08-28 Thread Jarek Jarcec Cecho (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720292#comment-14720292
 ] 

Jarek Jarcec Cecho commented on SQOOP-2539:
---

Generally +1 as we want to migrate to use the names as a primary way of 
referring to objects. This one will be a bit tricky as we will have to resolve 
situation when the name will be null in the database (e.g. we have resolve 
upgrade) - perhaps generate names according to some scheme?

 Sqoop2: Enforce resource name not null when creating table
 --

 Key: SQOOP-2539
 URL: https://issues.apache.org/jira/browse/SQOOP-2539
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Dian Fu
Assignee: Dian Fu
 Fix For: 1.99.7


 Currently resource name such as job name, connector name or link name can be 
 null. We should enforce that these resource names cannot be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 37898: SQOOP-2445 Sqoop2: Generic JDBC: Prevent use of tableColumns and sql at the same time

2015-08-28 Thread Jarek Cecho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37898/
---

Review request for Sqoop.


Bugs: SQOOP-2445
https://issues.apache.org/jira/browse/SQOOP-2445


Repository: sqoop-sqoop2


Description
---

Dropped suggested option combination.


Diffs
-

  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
 909ed74 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
 ec1c3b7 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
 31fafb1 

Diff: https://reviews.apache.org/r/37898/diff/


Testing
---

Unit tests are passing. I did not run all integration tests - would be great to 
see if they pass in precommit hook.


Thanks,

Jarek Cecho



[jira] [Updated] (SQOOP-2445) Sqoop2: Generic JDBC: Prevent use of tableColumns and sql at the same time

2015-08-28 Thread Jarek Jarcec Cecho (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Jarcec Cecho updated SQOOP-2445:
--
Attachment: SQOOP-2445.patch

 Sqoop2: Generic JDBC: Prevent use of tableColumns and sql at the same time
 --

 Key: SQOOP-2445
 URL: https://issues.apache.org/jira/browse/SQOOP-2445
 Project: Sqoop
  Issue Type: Sub-task
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
 Fix For: 1.99.7

 Attachments: SQOOP-2445.patch


 We're supporting data retrieval with custom query. I see bunch of code around 
 that is trying to solve situation when user enters both of custom query and 
 specifies what columns he wants to transfer from that custom query. This 
 seems to me as unnecessary complication as user can limit the column in the 
 first place by specifying appropriate query. Hence I would like to prohibit 
 this behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] sqoop pull request: fix the problem of NoClassDefFoundError of Hiv...

2015-08-28 Thread abec
Github user abec commented on the pull request:

https://github.com/apache/sqoop/pull/8#issuecomment-135871928
  
Hey man, this looks good to me. Can you attach a patch to the Jira? The 
Sqoop project still hasn't setup proper pull request handling yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (SQOOP-2542) Sqoop2: Provide test infrastructure base class for connector tests

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2542:
---

 Summary: Sqoop2: Provide test infrastructure base class for 
connector tests
 Key: SQOOP-2542
 URL: https://issues.apache.org/jira/browse/SQOOP-2542
 Project: Sqoop
  Issue Type: Sub-task
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SQOOP-2541) Sqoop2: Provide test infrastructure base class for upgrade tests

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2541:
---

 Summary: Sqoop2: Provide test infrastructure base class for 
upgrade tests
 Key: SQOOP-2541
 URL: https://issues.apache.org/jira/browse/SQOOP-2541
 Project: Sqoop
  Issue Type: Sub-task
  Components: sqoop2-test
Affects Versions: 1.99.7
Reporter: Abraham Elmahrek
Assignee: Abraham Elmahrek
 Fix For: 1.99.7






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)