[jira] [Commented] (SQOOP-3054) Get FileSystem from parameter "--target-dir"

2016-11-21 Thread Ying Cao (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685894#comment-15685894
 ] 

Ying Cao commented on SQOOP-3054:
-

getFileSystem()  from "--target-dir"

> Get FileSystem from parameter "--target-dir"
> 
>
> Key: SQOOP-3054
> URL: https://issues.apache.org/jira/browse/SQOOP-3054
> Project: Sqoop
>  Issue Type: Bug
>  Components: connectors
>Affects Versions: 1.4.6
> Environment: Redhat 6.6, Sqoop 1.4.6+Hadoop 2.7.2+Hive 1.2.1
>Reporter: Ying Cao
> Fix For: 1.4.7
>
> Attachments: SQOOP-3054.patch
>
>
> FileSystems gets from conf , update to get filesystem from parateter 
> "--target-dir"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SQOOP-3054) Get FileSystem from parameter "--target-dir"

2016-11-21 Thread Ying Cao (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ying Cao updated SQOOP-3054:

Attachment: SQOOP-3054.patch

> Get FileSystem from parameter "--target-dir"
> 
>
> Key: SQOOP-3054
> URL: https://issues.apache.org/jira/browse/SQOOP-3054
> Project: Sqoop
>  Issue Type: Bug
>  Components: connectors
>Affects Versions: 1.4.6
> Environment: Redhat 6.6, Sqoop 1.4.6+Hadoop 2.7.2+Hive 1.2.1
>Reporter: Ying Cao
> Fix For: 1.4.7
>
> Attachments: SQOOP-3054.patch
>
>
> FileSystems gets from conf , update to get filesystem from parateter 
> "--target-dir"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SQOOP-3054) Get FileSystem from parameter "--target-dir"

2016-11-21 Thread Ying Cao (JIRA)
Ying Cao created SQOOP-3054:
---

 Summary: Get FileSystem from parameter "--target-dir"
 Key: SQOOP-3054
 URL: https://issues.apache.org/jira/browse/SQOOP-3054
 Project: Sqoop
  Issue Type: Bug
  Components: connectors
Affects Versions: 1.4.6
 Environment: Redhat 6.6, Sqoop 1.4.6+Hadoop 2.7.2+Hive 1.2.1
Reporter: Ying Cao
 Fix For: 1.4.7


FileSystems gets from conf , update to get filesystem from parateter 
"--target-dir"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SQOOP-2349) Transaction isolation level for metadata queries should be mutable

2016-11-21 Thread Abraham Elmahrek (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684526#comment-15684526
 ] 

Abraham Elmahrek commented on SQOOP-2349:
-

[~maugli] Patch seems good except for some high level thoughts. Please see my 
reviewboard comment.

> Transaction isolation level for metadata queries should be mutable
> --
>
> Key: SQOOP-2349
> URL: https://issues.apache.org/jira/browse/SQOOP-2349
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.6
>Reporter: Abraham Elmahrek
>Assignee: Attila Szabo
> Fix For: 1.4.7
>
>
> Databases like PDW have don't accept READ COMMITTED isolation level:
> {code}
> com.microsoft.sqlserver.jdbc.SQLServerException: Setting IsolationLevel to 
> ReadCommitted is not supported.
> at 
> com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:197)
> at 
> com.microsoft.sqlserver.jdbc.TDSTokenHandler.onEOF(tdsparser.java:246)
> at com.microsoft.sqlserver.jdbc.TDSParser.parse(tdsparser.java:83)
> at com.microsoft.sqlserver.jdbc.TDSParser.parse(tdsparser.java:39)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection$1ConnectionCommand.doExecute(SQLServerConnection.java:1441)
> at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:4575)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:1400)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.connectionCommand(SQLServerConnection.java:1446)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.logon(SQLServerConnection.java:1907)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.access$000(SQLServerConnection.java:41)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection$LogonCommand.doExecute(SQLServerConnection.java:1893)
> at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:4575)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:1400)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.connectHelper(SQLServerConnection.java:1045)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.login(SQLServerConnection.java:817)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerConnection.connect(SQLServerConnection.java:700)
> at 
> com.microsoft.sqlserver.jdbc.SQLServerDriver.connect(SQLServerDriver.java:842)
> at java.sql.DriverManager.getConnection(DriverManager.java:571)
> at java.sql.DriverManager.getConnection(DriverManager.java:215)
> at 
> org.apache.sqoop.manager.SqlManager.makeConnection(SqlManager.java:880)
> at 
> org.apache.sqoop.manager.GenericJdbcManager.getConnection(GenericJdbcManager.java:52)
> at org.apache.sqoop.manager.SqlManager.execute(SqlManager.java:739)
> at org.apache.sqoop.manager.SqlManager.execute(SqlManager.java:762)
> at 
> org.apache.sqoop.manager.SqlManager.getColumnInfoForRawQuery(SqlManager.java:270)
> at 
> org.apache.sqoop.manager.SqlManager.getColumnTypesForRawQuery(SqlManager.java:241)
> at 
> org.apache.sqoop.manager.SqlManager.getColumnTypesForQuery(SqlManager.java:234)
> at 
> org.apache.sqoop.manager.ConnManager.getColumnTypes(ConnManager.java:304)
> at 
> org.apache.sqoop.orm.ClassWriter.getColumnTypes(ClassWriter.java:1833)
> at org.apache.sqoop.orm.ClassWriter.generate(ClassWriter.java:1645)
> at org.apache.sqoop.tool.CodeGenTool.generateORM(CodeGenTool.java:96)
> at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:478)
> at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
> at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
> at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
> 15/05/06 10:07:34 ERROR tool.ImportTool: Encountered IOException running 
> import job: java.io.IOException: No columns to generate for ClassWriter
> at org.apache.sqoop.orm.ClassWriter.generate(ClassWriter.java:1651)
> at org.apache.sqoop.tool.CodeGenTool.generateORM(CodeGenTool.java:96)
> at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:478)
> at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
> at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
> at 

Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable

2016-11-21 Thread Abraham Elmahrek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53423/#review156499
---


Ship it!




It seems good. A couple of high level comments:
- There is some mix of naming with regards to transaction isolation level. It 
seems "transaction level" and "isolation level" are used interchangeably in the 
patch. I'd choose on and go with it for consistency.
- Transaction isolation level is only an issue with certain databases (PDW and 
SQL Server for example). I haven't looked recently, but is this a problem with 
other databases other than SQL Server esque DBs? You could probably move 
forward with this patch and think about this later.

- Abraham Elmahrek


On Nov. 10, 2016, 2:13 p.m., Attila Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53423/
> ---
> 
> (Updated Nov. 10, 2016, 2:13 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Abraham Fine, Boglarka Egyed, 
> Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-2349
> https://issues.apache.org/jira/browse/SQOOP-2349
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I've introduced a cmd line parameter for being able to set the metadata 
> transaction levels (defined on java.sql.Connection) manually if necessary. 
> The change is backward compatible, so by default SQOOP gonna still use 
> READ_COMMITTED.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 30b4705 
>   src/java/org/apache/sqoop/manager/SqlManager.java 768507b 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 468bf34 
>   src/java/org/apache/sqoop/tool/JDBCTransactionLevels.java PRE-CREATION 
>   src/test/org/apache/sqoop/tool/TestImportTool.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>



Re: Review Request 53946: Include stack trace in the logging of exceptions in ExportTool

2016-11-21 Thread Anna Szonyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53946/#review156458
---


Ship it!




Thanks Bogi, would be great if this was the norm everywhere :)
/Anna

- Anna Szonyi


On Nov. 21, 2016, 2:18 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53946/
> ---
> 
> (Updated Nov. 21, 2016, 2:18 p.m.)
> 
> 
> Review request for Sqoop and Attila Szabo.
> 
> 
> Bugs: SQOOP-3028
> https://issues.apache.org/jira/browse/SQOOP-3028
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Include stack trace in the logging of exceptions in ExportTool
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/tool/ExportTool.java bd51c30 
> 
> Diff: https://reviews.apache.org/r/53946/diff/
> 
> 
> Testing
> ---
> 
> No specific test case needed
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>



[jira] [Updated] (SQOOP-3028) Include stack trace in the logging of exceptions in ExportTool

2016-11-21 Thread Boglarka Egyed (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boglarka Egyed updated SQOOP-3028:
--
Attachment: SQOOP-3028.patch

> Include stack trace in the logging of exceptions in ExportTool
> --
>
> Key: SQOOP-3028
> URL: https://issues.apache.org/jira/browse/SQOOP-3028
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Attila Szabo
>Assignee: Boglarka Egyed
>Priority: Trivial
> Fix For: 1.4.7
>
> Attachments: SQOOP-3028.patch
>
>
> Currently only the message of the IOException/Export is logged in runExport 
> method. Although it's possible to rethrow the root cause as a runtime 
> exception it would be nice to improve to add an option which makes possible 
> to have the improved logging details without an additional exception (as that 
> could be problematic on tooling side).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 53946: Include stack trace in the logging of exceptions in ExportTool

2016-11-21 Thread Boglarka Egyed

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53946/
---

Review request for Sqoop and Attila Szabo.


Bugs: SQOOP-3028
https://issues.apache.org/jira/browse/SQOOP-3028


Repository: sqoop-trunk


Description
---

Include stack trace in the logging of exceptions in ExportTool


Diffs
-

  src/java/org/apache/sqoop/tool/ExportTool.java bd51c30 

Diff: https://reviews.apache.org/r/53946/diff/


Testing
---

No specific test case needed


Thanks,

Boglarka Egyed



[jira] [Commented] (SQOOP-2973) Is sqoop version 1.4.6 is compatible with hbase version 1.2.1?

2016-11-21 Thread Szabolcs Vasas (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683363#comment-15683363
 ] 

Szabolcs Vasas commented on SQOOP-2973:
---

Hi [~m_rajib74], [~ericlin], 

I have checked the code and it seems that in HBase 1.0.0 the signature  of 
HTableDescriptor.addFamily has changed. Before 1.0.0 it was a void method and 
from 1.0.0 it returns an HTableDescriptor instance, so if the code was compiled 
with HBase version 0.94.2 (which is the default in Sqoop trunk now) and you 
want to run Sqoop with HBase 1.2.1 then the exception mentioned the description 
is expected because the JVM cannot find the void HTableDescriptor.addFamily 
method.

The solution is to use the same version of HBase runtime which was compile 
time. Which version of Sqoop do you guys use?

Regards,
Szabolcs

> Is  sqoop version 1.4.6 is compatible with hbase version 1.2.1?
> ---
>
> Key: SQOOP-2973
> URL: https://issues.apache.org/jira/browse/SQOOP-2973
> Project: Sqoop
>  Issue Type: Bug
> Environment: Haddop  version 2.7.2
>Reporter: Rajib Mandal
>
> We are getting below error while importing data from Oracle to Hbase
> error Exception in thread "main" java.lang.NoSuchMethodError: 
> org.apache.hadoop.hbase.HTableDescriptor.addFamily(Lorg/apache/hadoop/hbase/HColumnDescriptor;)V
>  
> The command executed
>  sqoop import --connect jdbc:oracle:thin:@//orcl. --username sysdba 
> --password  --table GENDER2 --columns "EMPLOYEE_ID,FIRST_NAME,GENDER" 
> --hbase-table employee --column-family GENDER2 --hbase-row-key EMPLOYEE_ID 
> --hbase-create-table
> Is there any way to resolve this?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)