[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163387#comment-15163387
 ] 

Hudson commented on SQOOP-2839:
---

FAILURE: Integrated in Sqoop-hadoop20 #1036 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1036/])
SQOOP-2839: Sqoop import failure due to data member conflict in ORM code 
(jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=cfa7927c2a3c129d140da7fa13ec9c97e17566dd])
* src/test/com/cloudera/sqoop/orm/TestClassWriter.java
* src/java/org/apache/sqoop/orm/ClassWriter.java


> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
>Assignee: VISHNU S NAIR
> Fix For: 1.4.7
>
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163379#comment-15163379
 ] 

Hudson commented on SQOOP-2839:
---

FAILURE: Integrated in Sqoop-hadoop200 #1042 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1042/])
SQOOP-2839: Sqoop import failure due to data member conflict in ORM code 
(jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=cfa7927c2a3c129d140da7fa13ec9c97e17566dd])
* src/test/com/cloudera/sqoop/orm/TestClassWriter.java
* src/java/org/apache/sqoop/orm/ClassWriter.java


> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
>Assignee: VISHNU S NAIR
> Fix For: 1.4.7
>
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163370#comment-15163370
 ] 

Hudson commented on SQOOP-2839:
---

FAILURE: Integrated in Sqoop-hadoop100 #1002 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/1002/])
SQOOP-2839: Sqoop import failure due to data member conflict in ORM code 
(jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=cfa7927c2a3c129d140da7fa13ec9c97e17566dd])
* src/test/com/cloudera/sqoop/orm/TestClassWriter.java
* src/java/org/apache/sqoop/orm/ClassWriter.java


> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
>Assignee: VISHNU S NAIR
> Fix For: 1.4.7
>
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163303#comment-15163303
 ] 

ASF subversion and git services commented on SQOOP-2839:


Commit cfa7927c2a3c129d140da7fa13ec9c97e17566dd in sqoop's branch 
refs/heads/trunk from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=cfa7927 ]

SQOOP-2839: Sqoop import failure due to data member conflict in ORM code for 
table

(VISHNU S NAIR  via Jarek Jarcec Cecho)


> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[Jarek Jarcec Cecho (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163302#comment-15163302
 ] 

Jarek Jarcec Cecho commented on SQOOP-2839:
---

+1

> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[VISHNU S NAIR (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160191#comment-15160191
 ] 

VISHNU S NAIR commented on SQOOP-2839:
--

Hi [~jarcec],

I have uploaded the new patch with test cases. Please verify the same and 
approve.

Thanks & regards
Vishnu S Nair.

> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[VISHNU S NAIR (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149993#comment-15149993
 ] 

VISHNU S NAIR commented on SQOOP-2839:
--

Hi [~jarcec],

Thanks for the suggestion. It seems a better option and we have implemented the 
same.

Please find the attached patch.

Thanks & Regards
Vishnu S Nair

> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
> Attachments: 0001-SQOOP-2839.patch
>
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149966#comment-15149966
 ] 

ASF GitHub Bot commented on SQOOP-2839:
---

GitHub user vishnusn opened a pull request:

https://github.com/apache/sqoop/pull/14

[SQOOP-2839]

On our investigation we found out this is related to Sqoop’s internal 
implementation. Sqoop internally creates a Java class corresponding to the 
table to be imported, which contains all the column names as data members. It 
also includes a constant named  "PROTOCOL_VERSION" and this leads to conflict 
between data members, if one of the column is named “PROTOCOL_VERSION”.

So in order to solve this issue , adding PROTOCOL_VERSION in reserved words 
list

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vishnusn/sqoop patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sqoop/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit e8887a418ee916546a2fb62475546e294a9a552e
Author: vishnusn 
Date:   2016-02-17T06:16:01Z

[SQOOP-2839]

On our investigation we found out this is related to Sqoop’s internal 
implementation. Sqoop internally creates a Java class corresponding to the 
table to be imported, which contains all the column names as data members. It 
also includes a constant named  "PROTOCOL_VERSION" and this leads to conflict 
between data members, if one of the column is named “PROTOCOL_VERSION”.

So in order to solve this issue , adding PROTOCOL_VERSION in reserved words 
list




> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[Jarek Jarcec Cecho (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149183#comment-15149183
 ] 

Jarek Jarcec Cecho commented on SQOOP-2839:
---

Hi [~vishnusn],
we're really not accepting a pull requests right now, would you mind uploading 
a patch to the JIRA itself?

I'm also wondering, rather then changing the variable name and thus just 
delaying the problem, wound't it make more sense to add that name to our 
[protected 
list|https://github.com/apache/sqoop/blob/trunk/src/java/org/apache/sqoop/orm/ClassWriter.java#L60]?

> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Affects Versions: 1.4.6
>Reporter: VISHNU S NAIR
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2839) Sqoop import failure due to data member conflict in ORM code for table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146988#comment-15146988
 ] 

ASF GitHub Bot commented on SQOOP-2839:
---

GitHub user vishnusn opened a pull request:

https://github.com/apache/sqoop/pull/13

[SQOOP-2839] : Sqoop import failure due to data member conflict in ORM code 
for table

[SQOOP-2839] : Sqoop creates a Java class corresponding to the table to be 
imported, which contains all the column names as data members. It also includes 
a constant named  "PROTOCOL_VERSION" and this leads to conflict between data 
members, if one of the column is named “PROTOCOL_VERSION”. So we updated the 
constant name to PROTOCOL_VERSION_SQOOP_.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vishnusn/sqoop patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sqoop/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 2a3d5e4027ff7118049c72190994c1c0900aa455
Author: vishnusn 
Date:   2016-02-15T06:58:07Z

Update ClassWriter.java

[SQOOP-2839] : Sqoop creates a Java class corresponding to the table to be 
imported, which contains all the column names as data members. It also includes 
a constant named  "PROTOCOL_VERSION" and this leads to conflict between data 
members, if one of the column is named “PROTOCOL_VERSION”. So we updated the 
constant name to PROTOCOL_VERSION_SQOOP_.




> Sqoop import failure due to data member conflict in ORM code for table
> --
>
> Key: SQOOP-2839
> URL: https://issues.apache.org/jira/browse/SQOOP-2839
> Project: Sqoop
>  Issue Type: Bug
>  Components: codegen
>Reporter: VISHNU S NAIR
>
> While importing data with Sqoop, if any of the table contains a column named 
> "PROTOCOL_VERSION", Sqoop will fail to import data.
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:173:
>  error: variable PROTOCOL_VERSION is already defined in class QueryResult
>   private String PROTOCOL_VERSION;
>  ^
> /tmp/sqoop-user/compile/fd570d817e8323d1135a7f2a6612e321/QueryResult.java:175:
>  error: incompatible types
> return PROTOCOL_VERSION;
>^
>   required: String
>   found:int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)