Re: Review Request: SQOOP-620: Introduce name to connection and job objects

2012-10-05 Thread Bilung Lee

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7456/#review12198
---

Ship it!


Ship It!

- Bilung Lee


On Oct. 5, 2012, 2:06 a.m., Jarek Cecho wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/7456/
 ---
 
 (Updated Oct. 5, 2012, 2:06 a.m.)
 
 
 Review request for Sqoop.
 
 
 Description
 ---
 
 I've added name to connection and job objects.
 
 
 This addresses bug SQOOP-620.
 https://issues.apache.org/jira/browse/SQOOP-620
 
 
 Diffs
 -
 
   client/src/main/java/org/apache/sqoop/client/core/Constants.java 
 PRE-CREATION 
   client/src/main/java/org/apache/sqoop/client/core/Environment.java 
 b496d43effa631d517deb54d36933f9ee389580d 
   
 client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
  9716de6ee540aa1af4f817e373ded17c9a0e710f 
   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 
 6c579d0965d52d29477a23e615099e2ec9093270 
   
 client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
  904624cf39496feaf28316fc5ed45ec5c1eb6cdf 
   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 
 1a8b901a531852fcb684afaaf0d71f1b18e3bfc6 
   
 client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
  1d642968555d41465b78824f536e1191dffa5be6 
   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 
 9924cf9a4f0e6c7a226a3237febf8aa200ff1f73 
   client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 
 24045878a4020ea994b4c0069f3bf9fd8e3b437a 
   client/src/main/resources/client-resource.properties PRE-CREATION 
   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 
 ea368da53d055579e772e944f56773390ff83389 
   
 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
  ef3d804588129dd14bf59c8e1693c95cf628f666 
   
 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
  8c0beeb60efbeaf65e89cc0e4d2f289c1ccd9c63 
   
 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
  d1897957c938b5f57436379701141802270c4451 
   
 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
  8ca7e462b61726dc6e7aba3c5d4f4930e9be8963 
 
 Diff: https://reviews.apache.org/r/7456/diff/
 
 
 Testing
 ---
 
 This patch do not include any new unit tests, I've tested it manually.
 
 
 Thanks,
 
 Jarek Cecho
 




Review Request: SQOOP-620: Introduce name to connection and job objects

2012-10-04 Thread Jarek Cecho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7456/
---

Review request for Sqoop.


Description
---

I've added name to connection and job objects.


This addresses bug SQOOP-620.
https://issues.apache.org/jira/browse/SQOOP-620


Diffs
-

  client/src/main/java/org/apache/sqoop/client/core/Constants.java PRE-CREATION 
  client/src/main/java/org/apache/sqoop/client/core/Environment.java 
b496d43effa631d517deb54d36933f9ee389580d 
  
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 
9716de6ee540aa1af4f817e373ded17c9a0e710f 
  client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 
6c579d0965d52d29477a23e615099e2ec9093270 
  
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
 904624cf39496feaf28316fc5ed45ec5c1eb6cdf 
  client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 
1a8b901a531852fcb684afaaf0d71f1b18e3bfc6 
  
client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
 1d642968555d41465b78824f536e1191dffa5be6 
  client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 
9924cf9a4f0e6c7a226a3237febf8aa200ff1f73 
  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 
24045878a4020ea994b4c0069f3bf9fd8e3b437a 
  client/src/main/resources/client-resource.properties PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 
ea368da53d055579e772e944f56773390ff83389 
  
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
 ef3d804588129dd14bf59c8e1693c95cf628f666 
  
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
 8c0beeb60efbeaf65e89cc0e4d2f289c1ccd9c63 
  
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
 d1897957c938b5f57436379701141802270c4451 
  
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
 8ca7e462b61726dc6e7aba3c5d4f4930e9be8963 

Diff: https://reviews.apache.org/r/7456/diff/


Testing
---

This patch do not include any new unit tests, I've tested it manually.


Thanks,

Jarek Cecho