Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2018-08-10 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/#review207078
---



Hi Shashank,

Other than the minor issue with the default value of the compression codec, 
this change looks ok to me. However, since these are new features in Sqoop, can 
you please add a few tests for them?

You can find similar tests to what you'll need in HCatalogImportTest.

The best way would be to add a new test class (it could be called 
HCatalogImportWithCompressionTest) and also utilize the ArgumentArrayBuilder 
class. You can find an example on how to use the builder in one of the more 
recent tests, such as the newly added S3 tests (TestS3AvroImport.java which 
calls into S3TestUtils.java). Anyway, please make sure to test both file 
formats. If you can think of multiple testcases that make sense, that's also 
welcome! 

I will be on vacation till the August 22, but hopefully other members of the 
community will help you out if you've any questions.

(Just for the record, I've also ran the unit and 3rd party tests, and didn't 
find any issues.)


src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java
Lines 900-904 (patched)


The default codec is gzip. However, if the codecName is not specified by 
the user, execution will never reach this point in the code. Please revise.



src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java
Lines 910 (patched)


nit: missing space before else



src/java/org/apache/sqoop/tool/ImportTool.java
Lines 1178-1179 (patched)


I think there is a mismatch between the validation and the setup logic. 

Here in the validation there is no default value, but an exception is 
thrown. In the setup logic, if codec is not specified GZIP is used as a 
default. 

I believe if the codec is not set, we should log a warning, and tell the 
user that the default will be used i.e. GZIP (or change it to SNAPPY if that's 
preferable).


- Fero Szabo


On Aug. 10, 2018, 7:29 a.m., Shashank Tandon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37353/
> ---
> 
> (Updated Aug. 10, 2018, 7:29 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Fero Szabo, Szabolcs Vasas, and 
> Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Apache Sqoop does not compress with --compress option with 
> --hcatalog-table.It also does not support option --compression-codec snappy. 
> Will add Snappy compression support in Apache Sqoop. When a user will try to 
> use --compress, then it will use the by default compression i.e. GZIP. 
> otherwise If user provide option --compress --compression-codec snappy then 
> it will compress into snappy format.
> 
> 
> Diffs
> -
> 
>   src/docs/user/hcatalog.txt 2ae1d54d 
>   src/java/org/apache/sqoop/config/ConfigurationConstants.java 3724f250 
>   src/java/org/apache/sqoop/io/CodecMap.java d5796188 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 784b5f2a 
>   src/java/org/apache/sqoop/tool/ImportTool.java ccded652 
>   src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java ba05cabb 
> 
> 
> Diff: https://reviews.apache.org/r/37353/diff/3/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> File Attachments
> 
> 
> SQOOP-2331_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/07/24/d474a04e-fe57-4c06-a066-0b70befcd29d__SQOOP-2331_2.patch
> SQOOP-2331_2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/10/c4004353-2230-4ef9-9ccc-c4934314f548__SQOOP-2331_3.patch
> SQOOP-2331_3.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/10/bf01aa4e-b9d2-43ac-bb5a-80a4787ad1a5__SQOOP-2331_3.patch
> 
> 
> Thanks,
> 
> Shashank Tandon
> 
>

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2018-08-10 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

(Updated Aug. 10, 2018, 7:29 a.m.)


Review request for Sqoop, Boglarka Egyed, Fero Szabo, Szabolcs Vasas, and 
Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs
-

  src/docs/user/hcatalog.txt 2ae1d54d 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java 3724f250 
  src/java/org/apache/sqoop/io/CodecMap.java d5796188 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 784b5f2a 
  src/java/org/apache/sqoop/tool/ImportTool.java ccded652 
  src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java ba05cabb 


Diff: https://reviews.apache.org/r/37353/diff/3/


Testing
---

yes


File Attachments (updated)


SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/07/24/d474a04e-fe57-4c06-a066-0b70befcd29d__SQOOP-2331_2.patch
SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/10/c4004353-2230-4ef9-9ccc-c4934314f548__SQOOP-2331_3.patch
SQOOP-2331_3.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/10/bf01aa4e-b9d2-43ac-bb5a-80a4787ad1a5__SQOOP-2331_3.patch


Thanks,

Shashank Tandon

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2018-08-10 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

(Updated Aug. 10, 2018, 7:28 a.m.)


Review request for Sqoop, Boglarka Egyed, Fero Szabo, Szabolcs Vasas, and 
Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs
-

  src/docs/user/hcatalog.txt 2ae1d54d 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java 3724f250 
  src/java/org/apache/sqoop/io/CodecMap.java d5796188 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 784b5f2a 
  src/java/org/apache/sqoop/tool/ImportTool.java ccded652 
  src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java ba05cabb 


Diff: https://reviews.apache.org/r/37353/diff/3/


Testing
---

yes


File Attachments (updated)


SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/07/24/d474a04e-fe57-4c06-a066-0b70befcd29d__SQOOP-2331_2.patch
SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/10/c4004353-2230-4ef9-9ccc-c4934314f548__SQOOP-2331_3.patch


Thanks,

Shashank Tandon

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2018-08-10 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

(Updated Aug. 10, 2018, 7:23 a.m.)


Review request for Sqoop, Boglarka Egyed, Fero Szabo, Szabolcs Vasas, and 
Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs (updated)
-

  src/docs/user/hcatalog.txt 2ae1d54d 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java 3724f250 
  src/java/org/apache/sqoop/io/CodecMap.java d5796188 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 784b5f2a 
  src/java/org/apache/sqoop/tool/ImportTool.java ccded652 
  src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java ba05cabb 


Diff: https://reviews.apache.org/r/37353/diff/3/

Changes: https://reviews.apache.org/r/37353/diff/2-3/


Testing
---

yes


File Attachments


SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/07/24/d474a04e-fe57-4c06-a066-0b70befcd29d__SQOOP-2331_2.patch


Thanks,

Shashank Tandon

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2018-07-24 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

(Updated July 24, 2018, 11:01 a.m.)


Review request for Sqoop, Fero Szabo and Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs
-

  src/docs/user/hcatalog.txt 99ae4f5 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
  src/java/org/apache/sqoop/io/CodecMap.java cec9358 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 9d5a9ee 
  src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 
  src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java d33d456 


Diff: https://reviews.apache.org/r/37353/diff/2/


Testing
---

yes


File Attachments (updated)


SQOOP-2331_2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/07/24/d474a04e-fe57-4c06-a066-0b70befcd29d__SQOOP-2331_2.patch


Thanks,

Shashank Tandon

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-11-04 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

(Updated Nov. 5, 2015, 6:34 a.m.)


Review request for Sqoop and Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs (updated)
-

  src/docs/user/hcatalog.txt 99ae4f5 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
  src/java/org/apache/sqoop/io/CodecMap.java cec9358 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 9d5a9ee 
  src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 
  src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java d33d456 

Diff: https://reviews.apache.org/r/37353/diff/


Testing
---

yes


Thanks,

Shashank Tandon

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-11-04 Thread Shashank Tandon 


> On Sept. 28, 2015, 6:30 p.m., Jarek Cecho wrote:
> > Thanks for taking a look Shashank and my apologies for late review on this 
> > one.
> > 
> > Would you mind adding tests for the newly added functionality?
> 
> Venkat Ranganathan wrote:
> Offline, Shashank asked for help regarding this 
> 
> ==
> 
> 
> I am getting the below error while running the snappy compression test 
> java.lang.RuntimeException: native snappy library not available
> at 
> org.apache.hadoop.io.compress.SnappyCodec.getCompressorType(SnappyCodec.java:123)
> at 
> org.apache.hadoop.hive.ql.io.CodecPool.getCompressor(CodecPool.java:101)
> at 
> org.apache.hadoop.hive.ql.io.RCFile$Writer.flushRecords(RCFile.java:1148)
> at 
> org.apache.hadoop.hive.ql.io.RCFile$Writer.close(RCFile.java:1259)
> at 
> org.apache.hadoop.hive.ql.io.RCFileOutputFormat$1.close(RCFileOutputFormat.java:92)
> at 
> org.apache.hive.hcatalog.mapreduce.FileRecordWriterContainer.close(FileRecordWriterContainer.java:150)
> at 
> org.apache.hadoop.mapred.MapTask$NewDirectOutputCollector.close(MapTask.java:651)
> at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:766)
> at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370)
> at 
> org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212)
> 
> I have also tried to copy native snappy library into the lib folder and 
> run the command like shown below :
> 
> ant clean test -Dhadoopversion=100 -Dtestcase=HCatalogImportTest 
> -Djava.library.path=lib/libsnappy.so
> 
> But still facing the same issue as I have spent lot of time but unable to 
> run snappy compression test from my local machine.
> 
> ==
> 
> I don't think we need to add unit tests for actual compression - except 
> that the command options did take effect, but integration tests (those that 
> don't with prefix Test) can be used with test this.   For example, we have 
> TestHCatalog* and *HCatalogTest test cases

A new method testHCatImportWithSnappyCompressionOptions will be added in the 
TestHCatalogBasic class as suggested by venkat.


> On Sept. 28, 2015, 6:30 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java, lines 
> > 845-849
> > 
> >
> > Shouldn't the FileOutputFormat be wrapped in else statement?

This is a common statement which needs to be set up independant of any file 
format.


> On Sept. 28, 2015, 6:30 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java, lines 
> > 843-845
> > 
> >
> > Can we also add similar case for parquet?

Hcatalog does not work with Parquet.  There is a hive jira for this 
https://issues.apache.org/jira/browse/HIVE-7502


> On Sept. 28, 2015, 6:30 p.m., Jarek Cecho wrote:
> > src/java/org/apache/sqoop/tool/ImportTool.java, lines 1157-1164
> > 
> >
> > I'm wondering if this is indeed that case - the code seems to be 
> > allowin any codec for text file and only limiting snappy for 
> > sequencefile/orc.

There is no limitation on file format.The only if condition is that the 
compression codec snappy is only supported rightnow in case oh hcatalog.If 
other compression codec needs to be added then this condtion will be taken care.


- Shashank


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/#review100838
---


On Aug. 11, 2015, 10:39 a.m., Shashank Tandon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37353/
> ---
> 
> (Updated Aug. 11, 2015, 10:39 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Apache Sqoop does not compress with --compress option with 
> --hcatalog-table.It also does not support option --compression-codec snappy. 
> Will add Snappy compression support in Apache Sqoop. When a user will try to 
> use --compress, then it will use the by default compression i.e. GZIP. 
> otherwise If user provide option --compress --compression-codec snappy then 
> it will compress into snappy format.
> 
> 
> Diffs
> -
> 
>   src/docs/user/hcatalog.txt 99ae4f5 
>   src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
>   src/java/org/apache/sqoop/io/CodecMap.java cec9358 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 
>

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-10-29 Thread Venkat Ranganathan 


> On Sept. 28, 2015, 11:30 a.m., Jarek Cecho wrote:
> > Thanks for taking a look Shashank and my apologies for late review on this 
> > one.
> > 
> > Would you mind adding tests for the newly added functionality?

Offline, Shashank asked for help regarding this 

==


I am getting the below error while running the snappy compression test 
java.lang.RuntimeException: native snappy library not available
at 
org.apache.hadoop.io.compress.SnappyCodec.getCompressorType(SnappyCodec.java:123)
at 
org.apache.hadoop.hive.ql.io.CodecPool.getCompressor(CodecPool.java:101)
at 
org.apache.hadoop.hive.ql.io.RCFile$Writer.flushRecords(RCFile.java:1148)
at org.apache.hadoop.hive.ql.io.RCFile$Writer.close(RCFile.java:1259)
at 
org.apache.hadoop.hive.ql.io.RCFileOutputFormat$1.close(RCFileOutputFormat.java:92)
at 
org.apache.hive.hcatalog.mapreduce.FileRecordWriterContainer.close(FileRecordWriterContainer.java:150)
at 
org.apache.hadoop.mapred.MapTask$NewDirectOutputCollector.close(MapTask.java:651)
at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:766)
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:370)
at 
org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:212)

I have also tried to copy native snappy library into the lib folder and run the 
command like shown below :

ant clean test -Dhadoopversion=100 -Dtestcase=HCatalogImportTest 
-Djava.library.path=lib/libsnappy.so

But still facing the same issue as I have spent lot of time but unable to run 
snappy compression test from my local machine.

==

I don't think we need to add unit tests for actual compression - except that 
the command options did take effect, but integration tests (those that don't 
with prefix Test) can be used with test this.   For example, we have 
TestHCatalog* and *HCatalogTest test cases


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/#review100838
---


On Aug. 11, 2015, 3:39 a.m., Shashank Tandon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37353/
> ---
> 
> (Updated Aug. 11, 2015, 3:39 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Apache Sqoop does not compress with --compress option with 
> --hcatalog-table.It also does not support option --compression-codec snappy. 
> Will add Snappy compression support in Apache Sqoop. When a user will try to 
> use --compress, then it will use the by default compression i.e. GZIP. 
> otherwise If user provide option --compress --compression-codec snappy then 
> it will compress into snappy format.
> 
> 
> Diffs
> -
> 
>   src/docs/user/hcatalog.txt 99ae4f5 
>   src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
>   src/java/org/apache/sqoop/io/CodecMap.java cec9358 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 
>   src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 
> 
> Diff: https://reviews.apache.org/r/37353/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Shashank Tandon
> 
>

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-09-28 Thread Jarek Cecho 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/#review100838
---


Thanks for taking a look Shashank and my apologies for late review on this one.

Would you mind adding tests for the newly added functionality?


src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (lines 843 - 
845)


Can we also add similar case for parquet?



src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (lines 845 - 
849)


Shouldn't the FileOutputFormat be wrapped in else statement?



src/java/org/apache/sqoop/tool/ImportTool.java (lines 1152 - 1159)


I'm wondering if this is indeed that case - the code seems to be allowin 
any codec for text file and only limiting snappy for sequencefile/orc.


Jarcec

- Jarek Cecho


On Aug. 11, 2015, 10:39 a.m., Shashank Tandon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37353/
> ---
> 
> (Updated Aug. 11, 2015, 10:39 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Apache Sqoop does not compress with --compress option with 
> --hcatalog-table.It also does not support option --compression-codec snappy. 
> Will add Snappy compression support in Apache Sqoop. When a user will try to 
> use --compress, then it will use the by default compression i.e. GZIP. 
> otherwise If user provide option --compress --compression-codec snappy then 
> it will compress into snappy format.
> 
> 
> Diffs
> -
> 
>   src/docs/user/hcatalog.txt 99ae4f5 
>   src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
>   src/java/org/apache/sqoop/io/CodecMap.java cec9358 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 
>   src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 
> 
> Diff: https://reviews.apache.org/r/37353/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Shashank Tandon
> 
>

Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-08-11 Thread Shashank Tandon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37353/
---

Review request for Sqoop and Venkat Ranganathan.


Repository: sqoop-trunk


Description
---

Apache Sqoop does not compress with --compress option with --hcatalog-table.It 
also does not support option --compression-codec snappy. Will add Snappy 
compression support in Apache Sqoop. When a user will try to use --compress, 
then it will use the by default compression i.e. GZIP. otherwise If user 
provide option --compress --compression-codec snappy then it will compress into 
snappy format.


Diffs
-

  src/docs/user/hcatalog.txt 99ae4f5 
  src/java/org/apache/sqoop/config/ConfigurationConstants.java e19c17b 
  src/java/org/apache/sqoop/io/CodecMap.java cec9358 
  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 
  src/java/org/apache/sqoop/tool/ImportTool.java 39af42c 

Diff: https://reviews.apache.org/r/37353/diff/


Testing
---

yes


Thanks,

Shashank Tandon