subject:"Review Request 68475\: SQOOP\-3363\: Test incremental import with S3"

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-28 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

(Updated Aug. 28, 2018, 12:04 p.m.)


Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Changes
---

Indentation fixed in S3TestUtils


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs (updated)
-

  src/java/org/apache/sqoop/util/AppendUtils.java 
20c0d13c391d312a943a147882cf85f86cb7e438 
  src/java/org/apache/sqoop/util/FileSystemUtil.java 
96ec21233d6378865195008f5ab67a74370fa2ed 
  src/test/org/apache/sqoop/TestAppendUtils.java 
3d66beca0226dd9eb8a14f4157444f24a247491a 
  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
ad2f10a071a0859c5b5e063c8cf5dda7c202124f 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/6/

Changes: https://reviews.apache.org/r/68475/diff/5-6/


Testing
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=
./gradlew test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-28 Thread Fero Szabo via Review Board



> On Aug. 28, 2018, 11:41 a.m., Fero Szabo wrote:
> >

All ant tests passed on my system. (unit, 3rd party and s3). Gradle unit tests 
passed as well.


- Fero


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review208030
---


On Aug. 28, 2018, 8:33 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 28, 2018, 8:33 a.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/AppendUtils.java 
> 20c0d13c391d312a943a147882cf85f86cb7e438 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/TestAppendUtils.java 
> 3d66beca0226dd9eb8a14f4157444f24a247491a 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> ad2f10a071a0859c5b5e063c8cf5dda7c202124f 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/5/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-28 Thread Fero Szabo via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review208030
---


Fix it, then Ship it!





src/test/org/apache/sqoop/testutil/S3TestUtils.java
Lines 181-185 (patched)


nit: indentation missing.


- Fero Szabo


On Aug. 28, 2018, 8:33 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 28, 2018, 8:33 a.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/AppendUtils.java 
> 20c0d13c391d312a943a147882cf85f86cb7e438 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/TestAppendUtils.java 
> 3d66beca0226dd9eb8a14f4157444f24a247491a 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> ad2f10a071a0859c5b5e063c8cf5dda7c202124f 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/5/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-28 Thread Szabolcs Vasas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review208029
---


Ship it!




Hi Bogi,

Thanks for fixing the findings, I have reran the tests again, all green.

- Szabolcs Vasas


On Aug. 28, 2018, 8:33 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 28, 2018, 8:33 a.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/AppendUtils.java 
> 20c0d13c391d312a943a147882cf85f86cb7e438 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/TestAppendUtils.java 
> 3d66beca0226dd9eb8a14f4157444f24a247491a 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> ad2f10a071a0859c5b5e063c8cf5dda7c202124f 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/5/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-28 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

(Updated Aug. 28, 2018, 8:33 a.m.)


Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Changes
---

Bigger refactor based on latest reviews: simplified test case responsibilities, 
eliminated code duplications, rationalized constant usage.


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs (updated)
-

  src/java/org/apache/sqoop/util/AppendUtils.java 
20c0d13c391d312a943a147882cf85f86cb7e438 
  src/java/org/apache/sqoop/util/FileSystemUtil.java 
96ec21233d6378865195008f5ab67a74370fa2ed 
  src/test/org/apache/sqoop/TestAppendUtils.java 
3d66beca0226dd9eb8a14f4157444f24a247491a 
  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
ad2f10a071a0859c5b5e063c8cf5dda7c202124f 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/5/

Changes: https://reviews.apache.org/r/68475/diff/4-5/


Testing
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=
./gradlew test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-27 Thread Fero Szabo via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review207962
---




src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java
Lines 120-121 (patched)


These two constants are defined 6 times in the patch. Why not move them 
outside of these methods and make them static?



src/test/org/apache/sqoop/s3/TestS3ParquetImport.java
Lines 77 (patched)


Why is this protected (as opposed to private)?



src/test/org/apache/sqoop/s3/TestS3ParquetImport.java
Lines 85-88 (patched)


I see that there are some duplications in the code. For example, you could 
extract these 4 lines into a new method.


- Fero Szabo


On Aug. 24, 2018, 2:41 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 24, 2018, 2:41 p.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> 1730698e80cc77395f8a296b7bf01c104533e10b 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/4/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-27 Thread Szabolcs Vasas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review207957
---


Fix it, then Ship it!




Hi Bogi,

Thank you for submitting the fix so quickly!
I have ran the tests successfully, and have one more finding, after that we can 
ship this!


src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java
Lines 144 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?



src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java
Lines 97 (patched)


nit: we could initialize the ParquetReader in a before method.



src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java
Lines 146 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?



src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java
Lines 144 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?



src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java
Lines 141 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?



src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java
Lines 152 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?



src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java
Lines 141 (patched)


Can we put this line in a method annotated with @After to make sure the the 
property is cleared even if the test case is failed?


- Szabolcs Vasas


On Aug. 24, 2018, 2:41 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 24, 2018, 2:41 p.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> 1730698e80cc77395f8a296b7bf01c104533e10b 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/4/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-24 Thread Boglarka Egyed



> On Aug. 24, 2018, 7:49 a.m., Szabolcs Vasas wrote:
> > src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java
> > Lines 33 (patched)
> > 
> >
> > I think you could use org.apache.sqoop.util.ParquetReader instead of 
> > this new class in your tests. ParquetReader already has the capability to 
> > read the content of a directory and you don't need to specify the file 
> > name, so your test cases would get simpler.

Good catch, thank you! I have created SQOOP-3372 for introducing similar reader 
util classes for other file formats too as it is oiut of the scope of this 
change and would require a bigger refactor.


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review207854
---


On Aug. 24, 2018, 2:41 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 24, 2018, 2:41 p.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/util/FileSystemUtil.java 
> 96ec21233d6378865195008f5ab67a74370fa2ed 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> 1730698e80cc77395f8a296b7bf01c104533e10b 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/4/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> ./gradlew test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-24 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

(Updated Aug. 24, 2018, 2:41 p.m.)


Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Changes
---

Review finding correction


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs (updated)
-

  src/java/org/apache/sqoop/util/FileSystemUtil.java 
96ec21233d6378865195008f5ab67a74370fa2ed 
  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
1730698e80cc77395f8a296b7bf01c104533e10b 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/4/

Changes: https://reviews.apache.org/r/68475/diff/3-4/


Testing (updated)
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=
./gradlew test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-24 Thread Szabolcs Vasas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/#review207854
---




src/test/org/apache/sqoop/s3/TestS3AvroImport.java
Line 46 (original), 46 (patched)


Do the s3Client field in the test classes need to be static?



src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java
Lines 33 (patched)


I think you could use org.apache.sqoop.util.ParquetReader instead of this 
new class in your tests. ParquetReader already has the capability to read the 
content of a directory and you don't need to specify the file name, so your 
test cases would get simpler.


- Szabolcs Vasas


On Aug. 23, 2018, 6:18 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68475/
> ---
> 
> (Updated Aug. 23, 2018, 6:18 p.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and 
> Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3363
> https://issues.apache.org/jira/browse/SQOOP-3363
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added new test cases for Parquet import into S3 as it was still missing
> * Added new test cases for incremental append import into S3 in Text, Avro, 
> Sequence and Parquet file format
> * Added new test cases for incremental merge import into S3 in Text and 
> Parquet file format
> * Updated some previously added logic in S3 util and test classes
> 
> 
> Diffs
> -
> 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
> e130c42104b86e854d45babc009a5f1409a74a48 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
> c17c1c54918df0b4d1ecbaef4e381975d72756ae 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java 
> 60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
>   src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
> 04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
> 1730698e80cc77395f8a296b7bf01c104533e10b 
>   src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java 
> ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
> ad7576dbb2447423c677429f24163031a9d39b5f 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
> df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 
> 
> 
> Diff: https://reviews.apache.org/r/68475/diff/3/
> 
> 
> Testing
> ---
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-23 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

(Updated Aug. 23, 2018, 6:18 p.m.)


Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Changes
---

Added temporary rootdir clean-up logic at the end of every test case


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs (updated)
-

  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
1730698e80cc77395f8a296b7bf01c104533e10b 
  src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/3/

Changes: https://reviews.apache.org/r/68475/diff/2-3/


Testing
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-23 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

(Updated Aug. 23, 2018, 3:56 p.m.)


Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Changes
---

Eliminated issues with parallel test execution


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs (updated)
-

  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
1730698e80cc77395f8a296b7bf01c104533e10b 
  src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/2/

Changes: https://reviews.apache.org/r/68475/diff/1-2/


Testing
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Review Request 68475: SQOOP-3363: Test incremental import with S3

2018-08-22 Thread Boglarka Egyed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68475/
---

Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs 
Vasas.


Bugs: SQOOP-3363
https://issues.apache.org/jira/browse/SQOOP-3363


Repository: sqoop-trunk


Description
---

* Added new test cases for Parquet import into S3 as it was still missing
* Added new test cases for incremental append import into S3 in Text, Avro, 
Sequence and Parquet file format
* Added new test cases for incremental merge import into S3 in Text and Parquet 
file format
* Updated some previously added logic in S3 util and test classes


Diffs
-

  src/test/org/apache/sqoop/s3/TestS3AvroImport.java 
e130c42104b86e854d45babc009a5f1409a74a48 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendAvroImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendSequenceFileImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalAppendTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeParquetImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3IncrementalMergeTextImport.java 
PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3ParquetImport.java PRE-CREATION 
  src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java 
c17c1c54918df0b4d1ecbaef4e381975d72756ae 
  src/test/org/apache/sqoop/s3/TestS3TextImport.java 
60e2cd3025e67ecd43bdfb6b30d1b8d69a50da86 
  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 
04a8494a5d1d8a5020d5a3b629bbab62d3c09ffd 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 
1730698e80cc77395f8a296b7bf01c104533e10b 
  src/test/org/apache/sqoop/testutil/ParquetFileTestUtils.java PRE-CREATION 
  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
ceaff3b3a2bfd031b9772c9b43afdfa670c23718 
  src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java 
ad7576dbb2447423c677429f24163031a9d39b5f 
  src/test/org/apache/sqoop/testutil/TextFileTestUtils.java 
df19cb8be7a633a6f1e1e3f9bc7d0dbc268aa90a 


Diff: https://reviews.apache.org/r/68475/diff/1/


Testing
---

ant clean test -Ds3.bucket.url= 
-Ds3.generator.command=


Thanks,

Boglarka Egyed

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

Review Request 68475: SQOOP-3363: Test incremental import with S3

13 matches

Site Navigation

Mail list logo

Footer information