Re: Review Request 68607: Sqoop import with Netezza --direct fails properly but also produces NPE

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68607/#review208304
---


Fix it, then Ship it!




Hi Daniel,

Thank you for picking this up, I have ran the unit and third party tests, and 
all of them are successful.
I have left one minor suggestion.


src/test/org/apache/sqoop/mapreduce/netezza/TestNetezzaExternalTableExportJob.java
Lines 60 (patched)


Can we use ExpectedException rule here? That would make the test a bit 
cleaner, you can use it to expect the message of the exception too.


- Szabolcs Vasas


On Sept. 3, 2018, 12:32 p.m., daniel voros wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68607/
> ---
> 
> (Updated Sept. 3, 2018, 12:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3058
> https://issues.apache.org/jira/browse/SQOOP-3058
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> We're not interrupting the import if we were unable to get column names, that 
> leads to NPE later. We should check for null instead and throw some more 
> meaningful exception.
> 
> 
> Diffs
> -
> 
>   
> src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableExportJob.java
>  11ac95df 
>   
> src/test/org/apache/sqoop/mapreduce/netezza/TestNetezzaExternalTableExportJob.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68607/diff/1/
> 
> 
> Testing
> ---
> 
> added UT
> 
> 
> Thanks,
> 
> daniel voros
> 
>

Review Request 68607: Sqoop import with Netezza --direct fails properly but also produces NPE

[daniel voros]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68607/
---

Review request for Sqoop.


Bugs: SQOOP-3058
https://issues.apache.org/jira/browse/SQOOP-3058


Repository: sqoop-trunk


Description
---

We're not interrupting the import if we were unable to get column names, that 
leads to NPE later. We should check for null instead and throw some more 
meaningful exception.


Diffs
-

  
src/java/org/apache/sqoop/mapreduce/netezza/NetezzaExternalTableExportJob.java 
11ac95df 
  
src/test/org/apache/sqoop/mapreduce/netezza/TestNetezzaExternalTableExportJob.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/68607/diff/1/


Testing
---

added UT


Thanks,

daniel voros