Re: Review Request 69139: TestS3ImportWithHadoopCredProvider fails if credential generator command is not provided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69139/#review209969 --- Ship it! Lgtm. I've only run this one test though. - Fero Szabo On Oct. 24, 2018, 10:58 a.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69139/ > --- > > (Updated Oct. 24, 2018, 10:58 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3399 > https://issues.apache.org/jira/browse/SQOOP-3399 > > > Repository: sqoop-trunk > > > Description > --- > > BeforeClass method of TestS3ImportWithHadoopCredProvider should not throw > NullPointerException when the credential generator command is not provided > since it fails the test with Gradle. > > > Diffs > - > > src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java > e03eb64ef > > > Diff: https://reviews.apache.org/r/69139/diff/1/ > > > Testing > --- > > Executed the test with both and and gradle, with and without S3 credential > generator provided. > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 69139: TestS3ImportWithHadoopCredProvider fails if credential generator command is not provided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69139/#review209961 --- Ship it! Good catch, thanks for the fix! I tested both with and without the AWS credentials, seems good to me. - Boglarka Egyed On Oct. 24, 2018, 10:58 a.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69139/ > --- > > (Updated Oct. 24, 2018, 10:58 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3399 > https://issues.apache.org/jira/browse/SQOOP-3399 > > > Repository: sqoop-trunk > > > Description > --- > > BeforeClass method of TestS3ImportWithHadoopCredProvider should not throw > NullPointerException when the credential generator command is not provided > since it fails the test with Gradle. > > > Diffs > - > > src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java > e03eb64ef > > > Diff: https://reviews.apache.org/r/69139/diff/1/ > > > Testing > --- > > Executed the test with both and and gradle, with and without S3 credential > generator provided. > > > Thanks, > > Szabolcs Vasas > >
Review Request 69139: TestS3ImportWithHadoopCredProvider fails if credential generator command is not provided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69139/ --- Review request for Sqoop. Bugs: SQOOP-3399 https://issues.apache.org/jira/browse/SQOOP-3399 Repository: sqoop-trunk Description --- BeforeClass method of TestS3ImportWithHadoopCredProvider should not throw NullPointerException when the credential generator command is not provided since it fails the test with Gradle. Diffs - src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java e03eb64ef Diff: https://reviews.apache.org/r/69139/diff/1/ Testing --- Executed the test with both and and gradle, with and without S3 credential generator provided. Thanks, Szabolcs Vasas
