Re: Review Request 69141: Tests using HiveMiniCluster can be unstable on some platforms

2018-10-24 Thread Fero Szabo via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69141/#review209963
---


Ship it!




gradlew test and thirdpartytest are successful on my computer.

- Fero Szabo


On Oct. 24, 2018, 12:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69141/
> ---
> 
> (Updated Oct. 24, 2018, 12:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3398
> https://issues.apache.org/jira/browse/SQOOP-3398
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Since the last Hive upgrade TestHiveMiniCluster fails on some platforms 
> because and older version of the ASM library is picked up.
> 
> The task is to exclude the older ASM library in ivy and gradle to make sure 
> the test passes on all platforms.
> 
> 
> Diffs
> -
> 
>   build.gradle 2340bce7519a46b203a287a4b5160c62e0c09509 
>   ivy.xml 6805fc329d44bcc0707e7cab67f3749a42e6f769 
> 
> 
> Diff: https://reviews.apache.org/r/69141/diff/1/
> 
> 
> Testing
> ---
> 
> Executed unit and third party tests with both ant and gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>



Re: Review Request 69141: Tests using HiveMiniCluster can be unstable on some platforms

2018-10-24 Thread Boglarka Egyed

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69141/#review209958
---


Ship it!




Thanks for the fix! Ran unit and 3rd party tests successfully with your patch.

- Boglarka Egyed


On Oct. 24, 2018, 12:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69141/
> ---
> 
> (Updated Oct. 24, 2018, 12:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3398
> https://issues.apache.org/jira/browse/SQOOP-3398
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Since the last Hive upgrade TestHiveMiniCluster fails on some platforms 
> because and older version of the ASM library is picked up.
> 
> The task is to exclude the older ASM library in ivy and gradle to make sure 
> the test passes on all platforms.
> 
> 
> Diffs
> -
> 
>   build.gradle 2340bce7519a46b203a287a4b5160c62e0c09509 
>   ivy.xml 6805fc329d44bcc0707e7cab67f3749a42e6f769 
> 
> 
> Diff: https://reviews.apache.org/r/69141/diff/1/
> 
> 
> Testing
> ---
> 
> Executed unit and third party tests with both ant and gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>



Review Request 69141: Tests using HiveMiniCluster can be unstable on some platforms

2018-10-24 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69141/
---

Review request for Sqoop.


Bugs: SQOOP-3398
https://issues.apache.org/jira/browse/SQOOP-3398


Repository: sqoop-trunk


Description
---

Since the last Hive upgrade TestHiveMiniCluster fails on some platforms because 
and older version of the ASM library is picked up.

The task is to exclude the older ASM library in ivy and gradle to make sure the 
test passes on all platforms.


Diffs
-

  build.gradle 2340bce7519a46b203a287a4b5160c62e0c09509 
  ivy.xml 6805fc329d44bcc0707e7cab67f3749a42e6f769 


Diff: https://reviews.apache.org/r/69141/diff/1/


Testing
---

Executed unit and third party tests with both ant and gradle.


Thanks,

Szabolcs Vasas