Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

2018-11-21 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69414/#review210763
---


Ship it!




Ship It!

- Fero Szabo


On Nov. 21, 2018, 12:22 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69414/
> ---
> 
> (Updated Nov. 21, 2018, 12:22 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3406
> https://issues.apache.org/jira/browse/SQOOP-3406
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> When Ant third party test suite is being run Ant tries to execute the test 
> category interfaces too because they end with the 'Test' postfix.
> 
> These "tests" obviously fail so we need to make sure that Ant does not 
> execute them.
> 
> 
> Diffs
> -
> 
>   build.xml 995a513040f85b6c2043a977a09e93b56913bbed 
> 
> 
> Diff: https://reviews.apache.org/r/69414/diff/2/
> 
> 
> Testing
> ---
> 
> ant unit and third party test
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

2018-11-21 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69414/#review210757
---


Ship it!




Ship It!

- Boglarka Egyed


On Nov. 21, 2018, 12:22 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69414/
> ---
> 
> (Updated Nov. 21, 2018, 12:22 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3406
> https://issues.apache.org/jira/browse/SQOOP-3406
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> When Ant third party test suite is being run Ant tries to execute the test 
> category interfaces too because they end with the 'Test' postfix.
> 
> These "tests" obviously fail so we need to make sure that Ant does not 
> execute them.
> 
> 
> Diffs
> -
> 
>   build.xml 995a513040f85b6c2043a977a09e93b56913bbed 
> 
> 
> Diff: https://reviews.apache.org/r/69414/diff/2/
> 
> 
> Testing
> ---
> 
> ant unit and third party test
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

2018-11-21 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69414/
---

(Updated Nov. 21, 2018, 12:22 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3406
https://issues.apache.org/jira/browse/SQOOP-3406


Repository: sqoop-trunk


Description
---

When Ant third party test suite is being run Ant tries to execute the test 
category interfaces too because they end with the 'Test' postfix.

These "tests" obviously fail so we need to make sure that Ant does not execute 
them.


Diffs (updated)
-

  build.xml 995a513040f85b6c2043a977a09e93b56913bbed 


Diff: https://reviews.apache.org/r/69414/diff/2/

Changes: https://reviews.apache.org/r/69414/diff/1-2/


Testing
---

ant unit and third party test


Thanks,

Szabolcs Vasas

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

2018-11-21 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69414/#review210753
---




build.xml
Lines 950 (patched)


CubridTest.java is excluded twice?


- Fero Szabo


On Nov. 20, 2018, 5:32 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69414/
> ---
> 
> (Updated Nov. 20, 2018, 5:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3406
> https://issues.apache.org/jira/browse/SQOOP-3406
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> When Ant third party test suite is being run Ant tries to execute the test 
> category interfaces too because they end with the 'Test' postfix.
> 
> These "tests" obviously fail so we need to make sure that Ant does not 
> execute them.
> 
> 
> Diffs
> -
> 
>   build.xml 995a513040f85b6c2043a977a09e93b56913bbed 
> 
> 
> Diff: https://reviews.apache.org/r/69414/diff/1/
> 
> 
> Testing
> ---
> 
> ant unit and third party test
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

2018-11-20 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69414/
---

Review request for Sqoop.


Bugs: SQOOP-3406
https://issues.apache.org/jira/browse/SQOOP-3406


Repository: sqoop-trunk


Description
---

When Ant third party test suite is being run Ant tries to execute the test 
category interfaces too because they end with the 'Test' postfix.

These "tests" obviously fail so we need to make sure that Ant does not execute 
them.


Diffs
-

  build.xml 995a513040f85b6c2043a977a09e93b56913bbed 


Diff: https://reviews.apache.org/r/69414/diff/1/


Testing
---

ant unit and third party test


Thanks,

Szabolcs Vasas