On Mon, Jun 11, 2012 at 12:35 PM, Martin Sebor <mse...@gmail.com> wrote: > ... > >> OK I attached a new test case - 27.basic_ios.copyfmt.stdcxx-1058.cpp. >> >> But, using a simple derived class from std::basic_ios doesn't trigger >> the bug. It's only triggered when using std::fstream or >> std::stringstream. > > > Here's what I meant: > > struct A: std::streambuf { }; > struct B: std::ios { > A sb; > B () { init (&sb); } > } f0, f1; > > Btw., in your new test, either the TEST_ASSERT() macro should abort > or the test should when before returning ret is non-zero. > > I.e., every regression test should report failure by calling abort > (via the assert() macro). > > Returning a non-zero exit status (in addition to making use of > assert()) is fine but it shouldn't be the sole mechanism for > reporting an error. > > Also, please avoid #including <iostream> in tests unless > exercising the standard streams (std::cout et al.) The header > runs complicated code and can lead to unrelated failures. > > Attached is a slightly modified test to show what I mean. (Also > fixes formatting -- please use 4 space indents and a space before > each open paren; curly brace goes on the same line as the statement > except for namespace scope declarations). > > Martin
Done - new attachment 27.basic_ios.copyfmt.stdcxx-1058.cpp --Stefan -- Stefan Teleman KDE e.V. stefan.tele...@gmail.com