RE: svn commit: r678483 - /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp

2008-07-21 Thread Eric Lemings
 

> -Original Message-
> From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor
> Sent: Monday, July 21, 2008 12:54 PM
> To: dev@stdcxx.apache.org
> Subject: Re: svn commit: r678483 - 
> /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcx
> x-808.cpp
> 
> Eric Lemings wrote:
> >  
> > 
> >> -Original Message-
> >> From: Travis Vitek [mailto:[EMAIL PROTECTED] 
> >> Sent: Monday, July 21, 2008 11:11 AM
> >> To: dev@stdcxx.apache.org
> >> Subject: RE: svn commit: r678483 - 
> >> /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcx
> >> x-808.cpp
> >>
> >>
> >>  
> >>
> >>> Author: elemings
> >>> Date: Mon Jul 21 09:59:24 2008
> >>> New Revision: 678483
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=678483&view=rev
> >>> Log:
> >>> 2008-07-21  Eric Lemings <[EMAIL PROTECTED]>
> >> Nit picking... :) There is supposed to be two spaces between your
> >> username and e-mail address.
> > 
> > Actually I prefer only one space to stress that the name and address
> > are one component as treated by most email clients.
> 
> The GNU Coding Standards that we follow for ChangeLog format show
> two spaces:
> http://www.gnu.org/prep/standards/html_node/Style-of-Change-Lo
> gs.html#Style-of-Change-Logs

It shows two spaces but it doesn't specify two spaces.  There is a
difference.

Either way, it's really inconsequential so I'll update it.

Brad.


Re: svn commit: r678483 - /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp

2008-07-21 Thread Martin Sebor

Eric Lemings wrote:
 


-Original Message-
From: Travis Vitek [mailto:[EMAIL PROTECTED] 
Sent: Monday, July 21, 2008 11:11 AM

To: dev@stdcxx.apache.org
Subject: RE: svn commit: r678483 - 
/stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcx

x-808.cpp


 


Author: elemings
Date: Mon Jul 21 09:59:24 2008
New Revision: 678483

URL: http://svn.apache.org/viewvc?rev=678483&view=rev
Log:
2008-07-21  Eric Lemings <[EMAIL PROTECTED]>

Nit picking... :) There is supposed to be two spaces between your
username and e-mail address.


Actually I prefer only one space to stress that the name and address
are one component as treated by most email clients.


The GNU Coding Standards that we follow for ChangeLog format show
two spaces:
http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

Emacs' add-change-log-entry function will format the ChangeLog in
the expected format for you.

If you're using vim, the NewChangelogEntry command will do the
same thing (you need the ft-changelog-plugin installed).

Martin



Brad.




RE: svn commit: r678483 - /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp

2008-07-21 Thread Eric Lemings
 

> -Original Message-
> From: Travis Vitek [mailto:[EMAIL PROTECTED] 
> Sent: Monday, July 21, 2008 11:11 AM
> To: dev@stdcxx.apache.org
> Subject: RE: svn commit: r678483 - 
> /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcx
> x-808.cpp
> 
> 
...
> 
> It seems that you're missing the comment that describes what 
> revision(s)
> you are merging. You might have a look at the following change for
> reference.
> 
>   http://svn.apache.org/viewvc?view=rev&revision=676093
> 

I was going to add that and then, second-guessing myself, removed it.

Guess my gut instinct was right the first time.  :P

Brad.


RE: svn commit: r678483 - /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp

2008-07-21 Thread Eric Lemings
 

> -Original Message-
> From: Travis Vitek [mailto:[EMAIL PROTECTED] 
> Sent: Monday, July 21, 2008 11:11 AM
> To: dev@stdcxx.apache.org
> Subject: RE: svn commit: r678483 - 
> /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcx
> x-808.cpp
> 
> 
>  
> 
> >Author: elemings
> >Date: Mon Jul 21 09:59:24 2008
> >New Revision: 678483
> >
> >URL: http://svn.apache.org/viewvc?rev=678483&view=rev
> >Log:
> >2008-07-21  Eric Lemings <[EMAIL PROTECTED]>
> 
> Nit picking... :) There is supposed to be two spaces between your
> username and e-mail address.

Actually I prefer only one space to stress that the name and address
are one component as treated by most email clients.

Brad.


RE: svn commit: r678483 - /stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp

2008-07-21 Thread Travis Vitek

 

>Author: elemings
>Date: Mon Jul 21 09:59:24 2008
>New Revision: 678483
>
>URL: http://svn.apache.org/viewvc?rev=678483&view=rev
>Log:
>2008-07-21  Eric Lemings <[EMAIL PROTECTED]>

Nit picking... :) There is supposed to be two spaces between your
username and e-mail address.

>

It seems that you're missing the comment that describes what revision(s)
you are merging. You might have a look at the following change for
reference.

  http://svn.apache.org/viewvc?view=rev&revision=676093

Travis


>   STDCXX-808
>   * tests/regress/27.streambuf.buffer.stdcxx-808.cpp: Add
>   regression test case that has failed in previous releases.
>
>
>Added:
>
>stdcxx/branches/4.2.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp
>  - copied unchanged from r678475, 
>stdcxx/branches/4.3.x/tests/regress/27.streambuf.buffer.stdcxx-808.cpp
>
>