[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-14 Thread abhishekagarwal87 
Github user abhishekagarwal87 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1104#discussion_r52861770
  
--- Diff: bin/storm.py ---
@@ -278,7 +278,7 @@ def kill(*args):
 print_usage(command="kill")
 sys.exit(2)
 exec_storm_class(
-"org.apache.storm.command.kill_topology",
+"org.apache.storm.command.KillTopology",
--- End diff --

My bad. --wait was already there but not documented in command syntax. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-14 Thread abhishekagarwal87 
Github user abhishekagarwal87 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1104#discussion_r52861665
  
--- Diff: bin/storm.py ---
@@ -278,7 +278,7 @@ def kill(*args):
 print_usage(command="kill")
 sys.exit(2)
 exec_storm_class(
-"org.apache.storm.command.kill_topology",
+"org.apache.storm.command.KillTopology",
--- End diff --

you have also added wait as alternative argument name. should it be added 
in the command doc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-14 Thread abhishekagarwal87 
Github user abhishekagarwal87 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1104#discussion_r52860563
  
--- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.command;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.List;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.DefaultParser;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CLI {
+private static final Logger LOG = LoggerFactory.getLogger(CLI.class);
+private static class Opt {
+final String s;
--- End diff --

can we rename s and l to shortName, longName respectively or something of 
the sort? or may be let's just put up a comment here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-14 Thread jerrypeng 
Github user jerrypeng commented on the pull request:

https://github.com/apache/storm/pull/1053#issuecomment-183998783
  
@d2r thanks for your review I have addressed your comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146583#comment-15146583
 ] 

ASF GitHub Bot commented on STORM-1549:
---

GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/1107

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector

See https://issues.apache.org/jira/browse/STORM-1549.

Other than implementing tuple timeout reset, I made a minor change to 
assert-loop in integration_test.clj so it doesn't hang on failing tests. It 
should now fail the test after 10 seconds. I hope that's okay.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1107


commit 406052cdc7138046a79104fc5c6f72212415f7f2
Author: Stig Rohde Døssing 
Date:   2016-02-14T01:39:42Z

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector




> Add support for extending tuple tree timeout
> 
>
> Key: STORM-1549
> URL: https://issues.apache.org/jira/browse/STORM-1549
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Reporter: Stig Rohde Døssing
>Assignee: Stig Rohde Døssing
>Priority: Minor
>
> During the discussion of https://github.com/apache/storm/pull/700 the issue 
> of allowing timeout extension in case of unavailable external components 
> (such as a web service) came up.
> The current implementation makes tuples fail at a set interval, regardless of 
> whether or not replaying them is necessary. This can be irritating in 
> topologies that emit to multiple services, since one hanging service will 
> cause replays to hit all the working services as well.
> I suggest adding a resetTimeout function to IOutputCollector, which will make 
> the relevant ackers and spouts reinsert the tuple tree information in their 
> pending maps. 
> The intended usage is that a bolt can call this function on an interval if it 
> needs to delay expiration, for example if it needs to retry calling a web 
> server a few times. It may also be useful for slow topologies that want Storm 
> to detect hanging/dropped tuples faster than the max expected complete 
> latency of the topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

2016-02-14 Thread srdo 
GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/1107

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector

See https://issues.apache.org/jira/browse/STORM-1549.

Other than implementing tuple timeout reset, I made a minor change to 
assert-loop in integration_test.clj so it doesn't hang on failing tests. It 
should now fail the test after 10 seconds. I hope that's okay.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1107


commit 406052cdc7138046a79104fc5c6f72212415f7f2
Author: Stig Rohde Døssing 
Date:   2016-02-14T01:39:42Z

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (STORM-1549) Add support for extending tuple tree timeout

2016-02-14 Thread JIRA 
Stig Rohde Døssing created STORM-1549:
-

 Summary: Add support for extending tuple tree timeout
 Key: STORM-1549
 URL: https://issues.apache.org/jira/browse/STORM-1549
 Project: Apache Storm
  Issue Type: New Feature
  Components: storm-core
Reporter: Stig Rohde Døssing
Assignee: Stig Rohde Døssing
Priority: Minor


During the discussion of https://github.com/apache/storm/pull/700 the issue of 
allowing timeout extension in case of unavailable external components (such as 
a web service) came up.

The current implementation makes tuples fail at a set interval, regardless of 
whether or not replaying them is necessary. This can be irritating in 
topologies that emit to multiple services, since one hanging service will cause 
replays to hit all the working services as well.

I suggest adding a resetTimeout function to IOutputCollector, which will make 
the relevant ackers and spouts reinsert the tuple tree information in their 
pending maps. 

The intended usage is that a bolt can call this function on an interval if it 
needs to delay expiration, for example if it needs to retry calling a web 
server a few times. It may also be useful for slow topologies that want Storm 
to detect hanging/dropped tuples faster than the max expected complete latency 
of the topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-14 Thread redsanket 
Github user redsanket commented on a diff in the pull request:

https://github.com/apache/storm/pull/1055#discussion_r52844340
  
--- Diff: storm-clojure/pom.xml ---
@@ -0,0 +1,83 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+storm
+org.apache.storm
+2.0.0-SNAPSHOT
+
+
+storm-clojure
+
+
+
+org.apache.storm
+storm-core
+${project.version}
+
+
+org.apache.storm
+storm-core
+${project.version}
+test-jar
+test
+
+
+org.apache.thrift
+libthrift
+compile
+
+
+org.slf4j
+slf4j-api
+
+
+javax.servlet
+servlet-api
+
+
+
+
+
+
+
+
+com.theoryinpractise
+clojure-maven-plugin
+true
+
+
+src/clj
+
+
+
+
+compile
+compile
+
+compile
+
+
+
+
+
+
+
--- End diff --

added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-14 Thread redsanket 
Github user redsanket commented on the pull request:

https://github.com/apache/storm/pull/1055#issuecomment-183929785
  
@revans2 addressed comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (STORM-1246) port backtype.storm.local-state to java

2016-02-14 Thread Abhishek Agarwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/STORM-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Agarwal updated STORM-1246:

Assignee: Abhishek Agarwal

> port backtype.storm.local-state to java
> ---
>
> Key: STORM-1246
> URL: https://issues.apache.org/jira/browse/STORM-1246
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Reporter: Robert Joseph Evans
>Assignee: Abhishek Agarwal
>  Labels: java-migration, jstorm-merger
>
> Wrapper around LocalState, with some helper functions for converting between 
> storm and thrift.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (STORM-1271) port backtype.storm.daemon.task to java

2016-02-14 Thread Abhishek Agarwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Agarwal updated STORM-1271:

Assignee: Abhishek Agarwal

> port backtype.storm.daemon.task to java
> ---
>
> Key: STORM-1271
> URL: https://issues.apache.org/jira/browse/STORM-1271
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Reporter: Robert Joseph Evans
>Assignee: Abhishek Agarwal
>  Labels: java-migration, jstorm-merger
>
> helper functions for task data and sending tuples



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-14 Thread vesense 
Github user vesense commented on the pull request:

https://github.com/apache/storm/pull/1104#issuecomment-183847386
  
Since the PR include STORM-1260 STORM-1261 STORM-1263 STORM-1264, I suggest 
changing the title of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---