[GitHub] storm issue #1812: Updating Trident RAS Documentation.

2016-12-02 Thread ptgoetz
Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/1812
  
+1 Thanks for the update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1812: Updating Trident RAS Documentation.

2016-12-02 Thread jerrypeng
Github user jerrypeng commented on the issue:

https://github.com/apache/storm/pull/1812
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread jerrypeng
Github user jerrypeng commented on the issue:

https://github.com/apache/storm/pull/1764
  
LGTM +1 @revans2  thanks for making the optimizations


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1764
  
+1. Please apply the optimization to #1765 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1795


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1802: STORM-2209: 1.x-branch Update documents adding new...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1802


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1776: STORM-2200 [Storm SQL] Drop Aggregate & Join support on T...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1776
  
I'd like to get this merged before releasing 1.1.0 so that users don't 
experience existing features are dropped. If someone can take a look I'd really 
appreciate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1795
  
+1 Thanks for the work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1742: STORM-2170 [Storm SQL] Add built-in socket datasou...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1742


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

2016-12-02 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1800
  
Shading Jersey is becoming rather difficult (lots of dependencies including 
aop and dependency injection.  Splitting the DPRC server off into it's own 
location seems much simpler and less error prone, so I will spend some time on 
that instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread ptgoetz
Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/1764
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1764
  
@ptgoetz @jerrypeng 

I made a few changes to thing.  I fixed the race condition and I addressed 
the review comments, but I also put in some optimizations to storm submitter.  
We were literally calling getClusterInfo 3+ times for each topology submission, 
and because the ultimate goal of STORM-2190 is to make it more scalable this 
helps a lot.  There is still some lock contention, but it is much better then 
it was before.

If things look good here I will backport the changes to my other pull 
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #913: Fix typo in get_jars_full

2016-12-02 Thread erikdw
Github user erikdw commented on the issue:

https://github.com/apache/storm/pull/913
  
Pointer to the new PR referenced above: 
https://github.com/apache/storm/pull/924


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1812: Updating Trident RAS Documentation.

2016-12-02 Thread knusbaum
GitHub user knusbaum opened a pull request:

https://github.com/apache/storm/pull/1812

Updating Trident RAS Documentation.

Adding documentation for defaults, clarifying other parts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/knusbaum/incubator-storm Trident_RAS_Doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1812


commit 32b42758b4dd8ba54e4201f2918405cc520ff7da
Author: Kyle Nusbaum 
Date:   2016-12-02T19:46:21Z

Updating Trident RAS Documentation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [BROKEN BUILD] - FIXED with Latest JDK 8

2016-12-02 Thread Hugo Da Cruz Louro
It compiles upgrading to latest JDK 8

java version "1.8.0_112"
Java(TM) SE Runtime Environment (build 1.8.0_112-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.112-b16, mixed mode)


On Dec 2, 2016, at 11:26 AM, P. Taylor Goetz 
> wrote:

My guess is this bug:

http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8080645 


I’m on Java(TM) SE Runtime Environment (build 1.8.0_112-b16) and it compiles 
for me.

-Taylor

On Dec 2, 2016, at 2:07 PM, Hugo Da Cruz Louro 
> wrote:

java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

On Dec 2, 2016, at 11:01 AM, P. Taylor Goetz 
> wrote:

I’m able to build the master branch just fine. What JDK version are you using?

-Taylor

On Dec 2, 2016, at 1:54 PM, Hugo Da Cruz Louro 
>
 wrote:

[ERROR] 
/Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23]
 incompatible types: inferred type does not conform to upper bound(s)
 inferred: java.util.Map
 upper bound(s): 
java.util.Map>,java.lang.Object

I believe this is the commit causing the problem: 
725003cc5f488191dda011dda738e41d57eca474

I compiled my code with the following head: 
80846773d9104fa565cf118d32b94796fc7507cf

8084677 Added STORM-2226 to CHANGELOG.md
4cec3bd STORM-2226: Fix kafka spout offset lag ui for kerberized kafka
2832aeb Added STORM-1276 to changelog.
b910466 Merge branch 'STORM-1276' of https://github.com/revans2/incubator-storm 
 into STORM-1276
725003c STORM-1276: line for line translation of nimbus to java
872d0a1 Added STORM-2224 to CHANGELOG.md
3c309fc STORM-2224 Exposed a method to override in computing the field from 
given tuple in FieldSelector
8048cfa Added STORM-2220 to CHANGELOG.md
adee4aa STORM-2220 Added config support for each bolt in Cassandra bolts, fixed 
the bolts to be used also as sinks.
2856687 Added STORM-1886 to CHANGELOG.md








Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread P. Taylor Goetz
My guess is this bug:

http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8080645 


I’m on Java(TM) SE Runtime Environment (build 1.8.0_112-b16) and it compiles 
for me.

-Taylor

> On Dec 2, 2016, at 2:07 PM, Hugo Da Cruz Louro  wrote:
> 
> java version "1.8.0_45"
> Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
> Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)
> 
> On Dec 2, 2016, at 11:01 AM, P. Taylor Goetz 
> > wrote:
> 
> I’m able to build the master branch just fine. What JDK version are you using?
> 
> -Taylor
> 
> On Dec 2, 2016, at 1:54 PM, Hugo Da Cruz Louro 
> > wrote:
> 
> [ERROR] 
> /Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23]
>  incompatible types: inferred type does not conform to upper bound(s)
>   inferred: java.util.Map java.lang.Object>
>   upper bound(s): 
> java.util.Map>,java.lang.Object
> 
> I believe this is the commit causing the problem: 
> 725003cc5f488191dda011dda738e41d57eca474
> 
> I compiled my code with the following head: 
> 80846773d9104fa565cf118d32b94796fc7507cf
> 
> 8084677 Added STORM-2226 to CHANGELOG.md
> 4cec3bd STORM-2226: Fix kafka spout offset lag ui for kerberized kafka
> 2832aeb Added STORM-1276 to changelog.
> b910466 Merge branch 'STORM-1276' of 
> https://github.com/revans2/incubator-storm 
>  into STORM-1276
> 725003c STORM-1276: line for line translation of nimbus to java
> 872d0a1 Added STORM-2224 to CHANGELOG.md
> 3c309fc STORM-2224 Exposed a method to override in computing the field from 
> given tuple in FieldSelector
> 8048cfa Added STORM-2220 to CHANGELOG.md
> adee4aa STORM-2220 Added config support for each bolt in Cassandra bolts, 
> fixed the bolts to be used also as sinks.
> 2856687 Added STORM-1886 to CHANGELOG.md
> 
> 
> 
> 



Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread Hugo Da Cruz Louro
java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

On Dec 2, 2016, at 11:01 AM, P. Taylor Goetz 
> wrote:

I’m able to build the master branch just fine. What JDK version are you using?

-Taylor

On Dec 2, 2016, at 1:54 PM, Hugo Da Cruz Louro 
> wrote:

[ERROR] 
/Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23]
 incompatible types: inferred type does not conform to upper bound(s)
   inferred: java.util.Map
   upper bound(s): 
java.util.Map>,java.lang.Object

I believe this is the commit causing the problem: 
725003cc5f488191dda011dda738e41d57eca474

I compiled my code with the following head: 
80846773d9104fa565cf118d32b94796fc7507cf

8084677 Added STORM-2226 to CHANGELOG.md
4cec3bd STORM-2226: Fix kafka spout offset lag ui for kerberized kafka
2832aeb Added STORM-1276 to changelog.
b910466 Merge branch 'STORM-1276' of https://github.com/revans2/incubator-storm 
 into STORM-1276
725003c STORM-1276: line for line translation of nimbus to java
872d0a1 Added STORM-2224 to CHANGELOG.md
3c309fc STORM-2224 Exposed a method to override in computing the field from 
given tuple in FieldSelector
8048cfa Added STORM-2220 to CHANGELOG.md
adee4aa STORM-2220 Added config support for each bolt in Cassandra bolts, fixed 
the bolts to be used also as sinks.
2856687 Added STORM-1886 to CHANGELOG.md






Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread P. Taylor Goetz
I’m able to build the master branch just fine. What JDK version are you using?

-Taylor

> On Dec 2, 2016, at 1:54 PM, Hugo Da Cruz Louro  wrote:
> 
> [ERROR] 
> /Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23]
>  incompatible types: inferred type does not conform to upper bound(s)
> inferred: java.util.Map java.lang.Object>
> upper bound(s): 
> java.util.Map>,java.lang.Object
> 
> I believe this is the commit causing the problem: 
> 725003cc5f488191dda011dda738e41d57eca474
> 
> I compiled my code with the following head: 
> 80846773d9104fa565cf118d32b94796fc7507cf
> 
> 8084677 Added STORM-2226 to CHANGELOG.md
> 4cec3bd STORM-2226: Fix kafka spout offset lag ui for kerberized kafka
> 2832aeb Added STORM-1276 to changelog.
> b910466 Merge branch 'STORM-1276' of 
> https://github.com/revans2/incubator-storm 
>  into STORM-1276
> 725003c STORM-1276: line for line translation of nimbus to java
> 872d0a1 Added STORM-2224 to CHANGELOG.md
> 3c309fc STORM-2224 Exposed a method to override in computing the field from 
> given tuple in FieldSelector
> 8048cfa Added STORM-2220 to CHANGELOG.md
> adee4aa STORM-2220 Added config support for each bolt in Cassandra bolts, 
> fixed the bolts to be used also as sinks.
> 2856687 Added STORM-1886 to CHANGELOG.md
> 
> 



[BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread Hugo Da Cruz Louro
[ERROR] 
/Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23]
 incompatible types: inferred type does not conform to upper bound(s)
inferred: java.util.Map
upper bound(s): 
java.util.Map>,java.lang.Object

I believe this is the commit causing the problem: 
725003cc5f488191dda011dda738e41d57eca474

I compiled my code with the following head: 
80846773d9104fa565cf118d32b94796fc7507cf

8084677 Added STORM-2226 to CHANGELOG.md
4cec3bd STORM-2226: Fix kafka spout offset lag ui for kerberized kafka
2832aeb Added STORM-1276 to changelog.
b910466 Merge branch 'STORM-1276' of https://github.com/revans2/incubator-storm 
into STORM-1276
725003c STORM-1276: line for line translation of nimbus to java
872d0a1 Added STORM-2224 to CHANGELOG.md
3c309fc STORM-2224 Exposed a method to override in computing the field from 
given tuple in FieldSelector
8048cfa Added STORM-2220 to CHANGELOG.md
adee4aa STORM-2220 Added config support for each bolt in Cassandra bolts, fixed 
the bolts to be used also as sinks.
2856687 Added STORM-1886 to CHANGELOG.md

[cid:7B5198C3-5567-446F-B12C-9A1070AB9805@hsd1.ca.comcast.net]


[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1767
  
We should be able to fix this with code like.

```
(if (or
   (exception-cause? InterruptedException error)
   (and
   (exception-cause? java.io.InterruptedIOException error)
   (not (exception-cause? java.net.SocketTimeoutException
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/1767
  
@chawco 

Okay so I understand the issue better now. SocketTimeoutException is a 
subclass of InterruptedIOException.


https://docs.oracle.com/javase/7/docs/api/java/net/SocketTimeoutException.html

I could argue that it is a mistake on the part of java and that it is 
wrong, but that is already set in stone so we have to deal with it.

I see two options. 

1) We can treat a SocketTimeoutException differently from other 
InterruptedIOExceptions, 
2) or we can just treat all InterruptedIOExceptions as fatal.

We started ignoring InterruptedIOExceptions because we would occasionally 
run into them in the supervisor or nimbus local cluster tests and that would 
fail everything.  Having proper behavior is more important than having super 
stable unit tests, but if we can have both (option 1) I think that would be 
best.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1810#discussion_r90638449
  
--- Diff: 
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
 ---
@@ -56,6 +66,30 @@ public HBaseLookupBolt withConfigKey(String configKey){
 this.configKey = configKey;
 return this;
 }
+
+@SuppressWarnings({ "unchecked", "rawtypes" })
+   @Override
+public void prepare(Map map, TopologyContext topologyContext, 
OutputCollector collector) {
+   super.prepare(map, topologyContext, collector);
+   cacheEnabled = 
Boolean.parseBoolean(map.getOrDefault("hbase.cache.enable", 
"false").toString());
--- End diff --

@ambud 
As I said from #1783 getOrDefault() is not compiled with JDK7. Please build 
with JDK7 before submitting pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

2016-12-02 Thread kosii
Github user kosii commented on the issue:

https://github.com/apache/storm/pull/1470
  
@arunmahadevan yes, check #1811 please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1810
  
@ambud Code looks good, but indentation is really off. Could you take care 
of it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request #1811: STORM-1886 Extend KeyValueState iface with delete

2016-12-02 Thread kosii
GitHub user kosii opened a pull request:

https://github.com/apache/storm/pull/1811

STORM-1886 Extend KeyValueState iface with delete

The same as #1470, just against the  
[1.x-branch](https://github.com/apache/storm/tree/1.x-branch) 

This pull request incorporates #1606 and #1160, because my patch depends on 
#1606, and #1606 depends on #1160.

Compared to #1470, I had to add a new commit f115162 , because 
[1.x-branch](https://github.com/apache/storm/tree/1.x-branch) uses Java 1.7.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/s4mDev/storm keyvaluestate-with-delete-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1811


commit f6f35dd98d2492a38aa4d61da7f6caee4ec2f31a
Author: Alessandro Bellina 
Date:   2016-02-27T04:42:59Z

STORM-1228: port fields_test to java

commit e5ae496e78aaf7a20a05bcff9139e2a6fd1ad551
Author: Alessandro Bellina 
Date:   2016-02-29T23:55:29Z

STORM-1228: code review comments

commit cdf80153009db83527bfbf0e5f3ab61126c5475e
Author: Alessandro Bellina 
Date:   2016-03-02T06:32:37Z

STORM-1228: instantiate fields in each test

commit 6d3a90d53ea425881b8b3c20a52932c7977bbccc
Author: Robert (Bobby) Evans 
Date:   2016-08-04T15:43:02Z

STORM-2020: Stop using sun internal classes.

commit 3d92358ef5a4e1be5dd86d32c960279d5f824f91
Author: Robert (Bobby) Evans 
Date:   2016-08-04T16:24:08Z

Addressed some review comments

commit 44f0beb18fe4b4c304fa73339df02a6abee99445
Author: Robert (Bobby) Evans 
Date:   2016-08-04T16:29:24Z

STORM-2022: update Fields test to match new behavior

commit d55ddffbe6c5bc2c7f022b530e5acfc0bb50c07f
Author: Balazs Kossovics 
Date:   2016-06-02T12:32:06Z

STORM-1886 Extend KeyValueState iface with delete

The patch also provides implementation for delete in
RedisKeyValueState and InMemoryKeyValueState.

commit 2eb308a6d36463b758d1f571cfeb6c9098176d40
Author: Balazs Kossovics 
Date:   2016-06-24T15:51:32Z

Use a Map with tombstones to represent deletions

commit 69068706fd43406a1a8eba63ebbc66932c174cef
Author: Balazs Kossovics 
Date:   2016-11-28T16:24:16Z

STORM-1886 Address last comments

* make tombstone static
* hide the use of Optional from the users
* fix race condition
* make encode and decode methods static

commit f115162f7ae65257d574a729426c845486a057ed
Author: Balazs Kossovics 
Date:   2016-12-02T12:39:06Z

STORM-1886 Make patch compatible with Java 1.7




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: topology.debug always true

2016-12-02 Thread Ohad Edelstein
I am embarrassed to say that you are right... thanks!
But what is the difference between the two?
Thanks

From: Mostafa Gomaa >
Reply-To: "u...@storm.apache.org" 
>
Date: Friday, 2 December 2016 at 13:03
To: "u...@storm.apache.org" 
>
Cc: "dev@storm.apache.org" 
>
Subject: Re: topology.debug always true

Are you sure you're not overriding this configuration in code when building the 
topology?

On Dec 1, 2016 10:07 PM, "Ohad Edelstein" 
> wrote:
We see that the topology.debug set to two different values:
[cid:57BDBB53-DB37-4DF8-8B26-D9BD1874CB9D]

And:
[cid:C121FA48-8020-4B00-A6B2-0652B1EF82BE]
We set the topology.debug to false ( we know its set that way to default but we 
thought that, this was the problem ).
Is there a different meaning to the param in this two screens?




[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...

2016-12-02 Thread mkoch1
Github user mkoch1 commented on the issue:

https://github.com/apache/storm/pull/1781
  
Did not notice that, sorry. Replaced now with an external resource 
implementation. The code is not all that complex so it's not a big deal. 

One thing I should point out: I borrowed the base implementation from a 
different project, also under Apache 2.0 license. I've included their copyright 
line in the file: 
https://github.com/apache/storm/pull/1781/commits/e46496337af84a610ef742c8cf5988d8dab19e47#diff-a8ce0c2f5e3ce0193d3ebc49f54301fa

Original code: 
https://github.com/spring-projects/spring-insight-plugins/blob/master/collection-plugins/cassandra12/src/test/java/com/springsource/insight/plugin/cassandra/embeded/EmbeddedCassandraService.java

Please let me know if there are any issues with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1806: STORM-2226: Fix kafka spout offset lag ui for kerberized ...

2016-12-02 Thread satishd
Github user satishd commented on the issue:

https://github.com/apache/storm/pull/1806
  
Thanks @priyank5485, merged into master and 1.x-branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---