[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...

2018-02-28 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2300
  
Thanks for the reviews.

@HeartSaVioR Sorry, @hmcl and I talked offline a while ago. It's my 
impression that we're good.

I'm not planning to port this to 1.x, since it requires breaking changes. I 
can't think of a way to fix this without replacing the Subscription interface.


---

[GitHub] storm pull request #2575: STORM-2971: Replace storm-kafka with storm-kafka-c...

2018-02-28 Thread srdo 
Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2575#discussion_r171478166
  
--- Diff: flux/README.md ---
@@ -354,19 +354,20 @@ storm jar myTopology-0.1.0-SNAPSHOT.jar 
org.apache.storm.flux.Flux --local my_co
 With the following `dev.properties` file:
 
 ```properties
-kafka.zookeeper.hosts: localhost:2181
+kafka.bootstrap.hosts: localhost:9092
 ```
 
 You would then be able to reference those properties by key in your 
`.yaml` file using `${}` syntax:
 
 ```yaml
-  - id: "zkHosts"
-className: "org.apache.storm.kafka.ZkHosts"
+  - id: "spoutConfigBuilder"
+className: "org.apache.storm.kafka.spout.KafkaSpoutConfig$Builder"
 constructorArgs:
-  - "${kafka.zookeeper.hosts}"
+  - "${kafka.bootstrap.hosts}"
+  - "[myKafkaTopic"]
--- End diff --

Nice catch


---

[GitHub] storm pull request #2576: [STORM-2976] Fix Supervisor HealthCheck validation...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2576


---

[GitHub] storm pull request #2579: STORM-2978 1.x: Fix Zookeeper transitive dependenc...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2579


---

[GitHub] storm pull request #2578: STORM-2978: Fix Zookeeper transitive dependency ve...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2578


---

[GitHub] storm pull request #2580: STORM-2980: Update storm-starter docs concerning l...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2580


---

[GitHub] storm issue #2580: STORM-2980: Update storm-starter docs concerning local mo...

2018-02-28 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2580
  
Only integration-test failed.


---

[GitHub] storm pull request #2581: STORM-2981: Upgrade Curator to 4.0.1

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2581


---

[GitHub] storm pull request #2570: STORM-2968: Exclude avro and commons-beanutils dep...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2570


---

[GitHub] storm pull request #2569: STORM-2968: Exclude avro and commons-beanutils dep...

2018-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2569


---

[GitHub] storm issue #2569: STORM-2968: Exclude avro and commons-beanutils dependency...

2018-02-28 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2569
  
Only integration-test failed.


---

[GitHub] storm pull request #2575: STORM-2971: Replace storm-kafka with storm-kafka-c...

2018-02-28 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2575#discussion_r171405779
  
--- Diff: flux/README.md ---
@@ -354,19 +354,20 @@ storm jar myTopology-0.1.0-SNAPSHOT.jar 
org.apache.storm.flux.Flux --local my_co
 With the following `dev.properties` file:
 
 ```properties
-kafka.zookeeper.hosts: localhost:2181
+kafka.bootstrap.hosts: localhost:9092
 ```
 
 You would then be able to reference those properties by key in your 
`.yaml` file using `${}` syntax:
 
 ```yaml
-  - id: "zkHosts"
-className: "org.apache.storm.kafka.ZkHosts"
+  - id: "spoutConfigBuilder"
+className: "org.apache.storm.kafka.spout.KafkaSpoutConfig$Builder"
 constructorArgs:
-  - "${kafka.zookeeper.hosts}"
+  - "${kafka.bootstrap.hosts}"
+  - "[myKafkaTopic"]
--- End diff --

nit: position of `"` is a bit off


---

Re: New Committer/PMC Member: Erik Weathers

2018-02-28 Thread Bobby Evans 
Sorry for the late reply.  Congrats and thanks for all of your great work
for the community Erik.

Thanks again,

Bobby

On Sun, Feb 25, 2018 at 10:45 PM Aaron Niskodé-Dossett 
wrote:

> Congrats, Erik, well deserved!
> On Sun, Feb 25, 2018 at 10:27 PM Satish Duggana 
> wrote:
>
> > Congrats and Welcome Erik!
> >
> >
> >
> > On Sat, Feb 24, 2018 at 9:25 PM, Harsha  wrote:
> >
> > > Congrats Erik.
> > > -Harsha
> > >
> > > On Fri, Feb 23, 2018, at 11:15 AM, Karthick Duraisamy Soundararaj
> wrote:
> > > > Whoa! Congratulations, Erik. Well deserved!
> > > >
> > > > On Fri, Feb 23, 2018 at 10:37 AM, Erik Weathers <
> > > > eweath...@groupon.com.invalid> wrote:
> > > >
> > > > > Thanks everyone!  And yes Alexandre, the relation of my surname to
> > the
> > > > > project name was not lost on me. ;-)(Also, my Grandpa went by
> > > "Stormy"
> > > > > too!)
> > > > >
> > > > > Also, I must thank my work teammates Srishty Agrawal and Jessica
> > > Hartog who
> > > > > have contributed greatly to any of the work that I've pushed.
> > > > >
> > > > > - Erik
> > > > >
> > > > > On Fri, Feb 23, 2018 at 8:28 AM, Ethan Li <
> ethanopensou...@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Congratulations! Erik
> > > > > >
> > > > > > - Ethan
> > > > > >
> > > > > > > On Feb 22, 2018, at 7:42 PM, Xin Wang 
> > > wrote:
> > > > > > >
> > > > > > > Congrats!
> > > > > > >
> > > > > > > 2018-02-23 9:41 GMT+08:00 Hugo Da Cruz Louro <
> > > hlo...@hortonworks.com>:
> > > > > > >
> > > > > > >> Congrats & Welcome!
> > > > > > >>
> > > > > > >>> On Feb 22, 2018, at 2:45 PM, Jungtaek Lim  >
> > > wrote:
> > > > > > >>>
> > > > > > >>> Welcome Erik! Congrats!
> > > > > > >>>
> > > > > > >>> -Jungtaek Lim (HeartSaVioR)
> > > > > > >>>
> > > > > > >>> 2018년 2월 23일 (금) 오전 7:05, Stig Rohde Døssing <
> > > stigdoess...@gmail.com
> > > > > > >님이
> > > > > > >> 작성:
> > > > > > >>>
> > > > > >  Congratulations Erik. Happy to see you join.
> > > > > > 
> > > > > >  2018-02-22 20:53 GMT+01:00 Alexandre Vermeerbergen <
> > > > > >  avermeerber...@gmail.com
> > > > > > > :
> > > > > > 
> > > > > > > Hi,
> > > > > > >
> > > > > > > Welcome to Erik...
> > > > > > > ... a Stormy Weather(s) sounds like a fantastic match
> indeed!
> > > > > > >
> > > > > > > Alexandre Vermeerbergen (Storm addict)
> > > > > > >
> > > > > > > 2018-02-22 20:49 GMT+01:00 P. Taylor Goetz <
> > ptgo...@apache.org
> > > >:
> > > > > > >> The Apache Storm PMC has voted to add Erik Weathers as a
> > > Committer
> > > > > > and
> > > > > > > PMC Member.
> > > > > > >>
> > > > > > >> Please join me in congratulating Erik on his new role!
> > > > > > >>
> > > > > > >> -Taylor
> > > > > > >
> > > > > > 
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Thanks,
> > > > > > > Xin
> > > > > >
> > > > > >
> > > > >
> > >
> >
>

Re: [DISCUSS] Handling dependencies for Storm 2.0.0 (STORM-2882)

2018-02-28 Thread Bobby Evans 
Sorry for the late reply.

I am 100% in favor of shading again for very common dependencies.  The big
issue is around how do we do this cleanly?  I like the way flink does it.
That can help with some of the issues we see with IDEs, but we just need to
be very careful with transitive dependencies when we do this.  I am not
aware of any issues like this, but if we have something like storm-client
depends on A and B, and B also depends on A.  If we shade A by itself, the
original A would still be needed on the classpath for B to work properly,
or we would have to do some kind of shading for B too, which if we don't do
it carefully might result in two separate copies of a shaded A on the
classpath.

Thanks,

Bobby

On Wed, Feb 21, 2018 at 1:20 AM Jungtaek Lim  wrote:

> Hi devs,
>
> I'm initiating this one for part of Storm 2.0.0. Actually we had some
> discussion from earlier thread [1] but it was originated for IDE
> complaining and we completely remove shading/relocating in Storm 2.0.0 at
> that time, ends up with exposing all the transitive dependencies in
> 'storm-client' to user topology code. We've reduced lots of dependencies
> while breaking down storm-core, but troublesome dependencies (for example,
> Guava, Jackson, Netty, and so on) are still left.
>
> There're two questions we should address:
>
> 1. Do we want to (and need to) shade/relocate the dependencies?
> (We may also want to see it as regression issue, since end users should
> tackle with dependencies if we don't shade/relocate.)
>
> 2. If we want to relocate the dependencies, how?
>
> If we would want to relocate them, there's a good reference on Flink: Flink
> creates separate repository [2] which contains pom for relocation for each
> target artifact. Links for related discussion [3] and issue [4] are
> available, so if you are interested on Flink's approach, please refer the
> links. I guess it may require considerable efforts, so if someone finds
> simpler and easier way that should be great.
>
> Please share your voices regarding two questions, and idea/knowledge of
> how. Thanks in advance.
>
> Jungtaek Lim (HeartSaVioR)
>
> 1.
>
> https://mail-archives.apache.org/mod_mbox/incubator-storm-dev/201703.mbox/%3ccaf5108gjjqzsyywcp99bgpgec7tufe-tbt9fi0m78ah8rkm...@mail.gmail.com%3E
> 2. https://github.com/apache/flink-shaded
> 3.
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Changing-Flink-s-shading-model-td17419.html
> 4. https://issues.apache.org/jira/browse/FLINK-6529
>

[GitHub] storm issue #2502: new PR for STORM-2306 : Messaging subsystem redesign

2018-02-28 Thread Ethanlm 
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2502
  
@roshannaik Yes sure. https://issues.apache.org/jira/browse/STORM-2983 This 
blocks my current work and I would really appreciate it if it can be solved 
soon. Thanks


---