[GitHub] storm issue #2760: STORM-3123: Storm Kafka Monitor cannot connect to Kafka o...

2018-08-21 Thread VipinRathor
Github user VipinRathor commented on the issue:

https://github.com/apache/storm/pull/2760
  
yes, I cherry-picked my 3 commits into another branch and currently testing 
with Kafka & two-way SSL.


---


[GitHub] storm issue #2760: STORM-3123: Storm Kafka Monitor cannot connect to Kafka o...

2018-08-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2760
  
@VipinRathor Any updates? It is completely OK for you to just close an 
create a new PR.


---


[GitHub] storm issue #2811: STORM-3184: Replace the usage of redact-value with Config...

2018-08-21 Thread arunmahadevan
Github user arunmahadevan commented on the issue:

https://github.com/apache/storm/pull/2811
  
cc @HeartSaVioR 


---


[GitHub] storm pull request #2811: STORM-3184: Replace the usage of redact-value with...

2018-08-21 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request:

https://github.com/apache/storm/pull/2811

STORM-3184: Replace the usage of redact-value with ConfigUtils.maskPasswords

The topology submission can fail since redact-value expects a clojure map. 
We don't need redact-value, it can be replaced with ConfigUtils.maskPasswords. 
This is already done in master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunmahadevan/storm STORM-3184-followup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2811


commit 43faecc870468a00d5f1b2d5ba1c5c4274ae77b0
Author: Arun Mahadevan 
Date:   2018-08-20T23:31:32Z

STORM-3184: Replace the usage of redact-value with ConfigUtils.maskPasswords

The topology submission can fail since redact-value
expects a clojure map. We dont need redact-value, it can be replaced
with just ConfigUtils.maskPasswords. This is already done in master.




---


[GitHub] storm pull request #2810: STORM-3200 improve keytab error message

2018-08-21 Thread agresch
GitHub user agresch opened a pull request:

https://github.com/apache/storm/pull/2810

STORM-3200 improve keytab error message



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agresch/storm agresch_blobstore_debug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2810


commit 04f75bfad131ac2be4450433231814f3eba25717
Author: Aaron Gresch 
Date:   2018-08-21T19:32:16Z

STORM-3200 improve keytab error message




---