Re: Site updates

[Ethan Li]

It looks good to me. Thanks for the work.

> On Jul 18, 2019, at 3:37 PM, Stig Rohde Døssing  
> wrote:
> 
> Just so it doesn't come as a surprise to anyone: I've done a bit of cleanup
> on the site. The downloads page was linking to a bunch of old releases,
> which we've been asked to remove from the mirroring system
> https://issues.apache.org/jira/browse/STORM-2956.
> 
> As the downloads page already links to the archival system, I don't think
> there's a reason to list out old release files explicitly, people can just
> click the link to the archive.
> 
> I've removed documentation for outdated releases, so we now only have the
> documentation for the newest release branches. Let me know if this was too
> aggressive, and we need to restore some of the old docs.
> 
> There was a https://storm.apache.org/releases.html page, that was listing
> releases, but nothing linked to it. I've deleted it, as equivalent
> information can be found on the downloads page.

[GitHub] [storm] srdo commented on a change in pull request #3089: MINOR: Add release process document

[GitBox]

srdo commented on a change in pull request #3089: MINOR: Add release process 
document
URL: https://github.com/apache/storm/pull/3089#discussion_r305123781
 
 

 ##
 File path: RELEASING.md
 ##
 @@ -0,0 +1,58 @@
+# Developer documentation
+
+This document summarizes information relevant to Storm committers.  It 
includes information about
+the Storm release process.
+
+---
+
+# Release process
+
+## Preparation
+
+Ensure you can log in to http://repository.apache.org. You should use your 
Apache ID username and password.
+
+Install an svn client, and ensure you can access the 
https://dist.apache.org/repos/dist/dev/storm/ and 
https://dist.apache.org/repos/dist/release/storm/ repositories. You should be 
able to access these with your Apache ID username and password.
+
+Ensure you have a signed GPG key, and that the GPG key is listed in the Storm 
KEYS file at https://dist.apache.org/repos/dist/release/storm/KEYS. The key 
should be hooked into the Apache web of trust. You should read the [Apache 
release signing page](http://www.apache.org/dev/release-signing.html), the 
[release distribution 
page](http://www.apache.org/dev/release-distribution.html#sigs-and-sums), as 
well as the [release publishing](http://www.apache.org/dev/release-publishing) 
and [release policy](http://www.apache.org/legal/release-policy.html) pages.
+
+## Setting up a vote
+
+1. Run `mvn release:prepare` followed `mvn release:perform` on the branch to 
be released. This will create all the artifacts that will eventually be 
available in maven central. This step may seem simple, but a lot can go wrong 
(mainly flaky tests).
+
+2. Once you get a successful maven release, a “staging repository” will be 
created at http://repository.apache.org in the “open” state, meaning it is 
still writable. You will need to close it, making it read-only. You can find 
more information on this step 
[here]{www.apache.org/dev/publishing-maven-artifacts.html}.
 
 Review comment:
   Good eyes, fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] srdo commented on a change in pull request #3089: MINOR: Add release process document

[GitBox]

srdo commented on a change in pull request #3089: MINOR: Add release process 
document
URL: https://github.com/apache/storm/pull/3089#discussion_r305123743
 
 

 ##
 File path: RELEASING.md
 ##
 @@ -0,0 +1,58 @@
+# Developer documentation
 
 Review comment:
   Nice catch, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on a change in pull request #3089: MINOR: Add release process document

[GitBox]

Ethanlm commented on a change in pull request #3089: MINOR: Add release process 
document
URL: https://github.com/apache/storm/pull/3089#discussion_r305122051
 
 

 ##
 File path: RELEASING.md
 ##
 @@ -0,0 +1,58 @@
+# Developer documentation
+
+This document summarizes information relevant to Storm committers.  It 
includes information about
+the Storm release process.
+
+---
+
+# Release process
+
+## Preparation
+
+Ensure you can log in to http://repository.apache.org. You should use your 
Apache ID username and password.
+
+Install an svn client, and ensure you can access the 
https://dist.apache.org/repos/dist/dev/storm/ and 
https://dist.apache.org/repos/dist/release/storm/ repositories. You should be 
able to access these with your Apache ID username and password.
+
+Ensure you have a signed GPG key, and that the GPG key is listed in the Storm 
KEYS file at https://dist.apache.org/repos/dist/release/storm/KEYS. The key 
should be hooked into the Apache web of trust. You should read the [Apache 
release signing page](http://www.apache.org/dev/release-signing.html), the 
[release distribution 
page](http://www.apache.org/dev/release-distribution.html#sigs-and-sums), as 
well as the [release publishing](http://www.apache.org/dev/release-publishing) 
and [release policy](http://www.apache.org/legal/release-policy.html) pages.
+
+## Setting up a vote
+
+1. Run `mvn release:prepare` followed `mvn release:perform` on the branch to 
be released. This will create all the artifacts that will eventually be 
available in maven central. This step may seem simple, but a lot can go wrong 
(mainly flaky tests).
+
+2. Once you get a successful maven release, a “staging repository” will be 
created at http://repository.apache.org in the “open” state, meaning it is 
still writable. You will need to close it, making it read-only. You can find 
more information on this step 
[here]{www.apache.org/dev/publishing-maven-artifacts.html}.
 
 Review comment:
   [here]{www.apache.org/dev/publishing-maven-artifacts.html}. seems wrong. It 
needs to be  "()" instead of "{}"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on a change in pull request #3089: MINOR: Add release process document

[GitBox]

Ethanlm commented on a change in pull request #3089: MINOR: Add release process 
document
URL: https://github.com/apache/storm/pull/3089#discussion_r305120226
 
 

 ##
 File path: RELEASING.md
 ##
 @@ -0,0 +1,58 @@
+# Developer documentation
 
 Review comment:
   This can be "Committer documentation" or something similar


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on issue #3088: MINOR: fix null dereference in SimpleSaslServer authentication

[GitBox]

Ethanlm commented on issue #3088: MINOR: fix null dereference in 
SimpleSaslServer authentication
URL: https://github.com/apache/storm/pull/3088#issuecomment-512991276
 
 
   Nice catch. Thanks for contribution 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] nescohen commented on issue #3088: MINOR: fix null dereference in SimpleSaslServer authentication

[GitBox]

nescohen commented on issue #3088: MINOR: fix null dereference in 
SimpleSaslServer authentication
URL: https://github.com/apache/storm/pull/3088#issuecomment-512990792
 
 
   @srdo, sounds good. I can create a jira issue and update the pr accordingly. 
Thanks! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] srdo commented on issue #3088: MINOR: fix null dereference in SimpleSaslServer authentication

[GitBox]

srdo commented on issue #3088: MINOR: fix null dereference in SimpleSaslServer 
authentication
URL: https://github.com/apache/storm/pull/3088#issuecomment-512980717
 
 
   Thanks for the contribution @nescohen. I think we should create an issue to 
track this, as it's fixing a bug. Otherwise it won't show up in release notes, 
and it won't be obvious which Storm releases have this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] srdo opened a new pull request #3089: MINOR: Add release process document

[GitBox]

srdo opened a new pull request #3089: MINOR: Add release process document
URL: https://github.com/apache/storm/pull/3089
 
 
   This is adapted from Taylor's description of how to release. I think we 
should have a document like this in the repo. Suggestions are welcome.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [ANNOUNCE] Apache Storm 1.2.3 Released

[Stig Rohde Døssing]

This should now be fixed, thanks Sebb

Den tor. 18. jul. 2019 kl. 20.59 skrev Stig Rohde Døssing <
stigdoess...@gmail.com>:

> Thanks for letting me know, I'll fix it.
>
> Den tor. 18. jul. 2019 kl. 20.48 skrev sebbaz :
>
>>
>>
>> On 2019/07/18 17:49:55, Stig Rohde Døssing  wrote:
>> >  The Apache Storm community is pleased to announce the release of Apache
>> > Storm version 1.2.3.
>> >
>> > Storm is a distributed, fault-tolerant, and high-performance realtime
>> > computation system that provides strong guarantees on the processing of
>> > data. You can read more about Storm on the project website:
>> >
>> > http://storm.apache.org
>> >
>> > Downloads of source and binary distributions are listed in our download
>> > section:
>> >
>> > http://storm.apache.org/downloads.html
>>
>> The download page does *not* currently have links to 1.2.3
>>
>> > You can read more about this release in the following blog post:
>> >
>> > http://storm.apache.org/2019/07/18/storm123-released.html
>> > 
>> >
>> > Distribution artifacts are available in Maven Central at the following
>> > coordinates:
>> >
>> > groupId: org.apache.storm
>> > artifactId: storm-core
>> > version: 1.2.3
>> >
>> > The full list of changes is available here[1]. Please let us know [2] if
>> > you encounter any problems.
>> >
>> > Regards,
>> >
>> > The Apache Storm Team
>> >
>> > [1]:
>> >
>> http://www.us.apache.org/dist/storm/apache-storm-1.2.3/RELEASE_NOTES.html
>> > <
>> http://www.us.apache.org/dist/storm/apache-storm-2.0.0/RELEASE_NOTES.html
>> >
>> > [2]: https://issues.apache.org/jira/browse/STORM
>> >
>>
>

Site updates

[Stig Rohde Døssing]

Just so it doesn't come as a surprise to anyone: I've done a bit of cleanup
on the site. The downloads page was linking to a bunch of old releases,
which we've been asked to remove from the mirroring system
https://issues.apache.org/jira/browse/STORM-2956.

As the downloads page already links to the archival system, I don't think
there's a reason to list out old release files explicitly, people can just
click the link to the archive.

I've removed documentation for outdated releases, so we now only have the
documentation for the newest release branches. Let me know if this was too
aggressive, and we need to restore some of the old docs.

There was a https://storm.apache.org/releases.html page, that was listing
releases, but nothing linked to it. I've deleted it, as equivalent
information can be found on the downloads page.

Re: [ANNOUNCE] Apache Storm 1.2.3 Released

[Stig Rohde Døssing]

Thanks for letting me know, I'll fix it.

Den tor. 18. jul. 2019 kl. 20.48 skrev sebbaz :

>
>
> On 2019/07/18 17:49:55, Stig Rohde Døssing  wrote:
> >  The Apache Storm community is pleased to announce the release of Apache
> > Storm version 1.2.3.
> >
> > Storm is a distributed, fault-tolerant, and high-performance realtime
> > computation system that provides strong guarantees on the processing of
> > data. You can read more about Storm on the project website:
> >
> > http://storm.apache.org
> >
> > Downloads of source and binary distributions are listed in our download
> > section:
> >
> > http://storm.apache.org/downloads.html
>
> The download page does *not* currently have links to 1.2.3
>
> > You can read more about this release in the following blog post:
> >
> > http://storm.apache.org/2019/07/18/storm123-released.html
> > 
> >
> > Distribution artifacts are available in Maven Central at the following
> > coordinates:
> >
> > groupId: org.apache.storm
> > artifactId: storm-core
> > version: 1.2.3
> >
> > The full list of changes is available here[1]. Please let us know [2] if
> > you encounter any problems.
> >
> > Regards,
> >
> > The Apache Storm Team
> >
> > [1]:
> >
> http://www.us.apache.org/dist/storm/apache-storm-1.2.3/RELEASE_NOTES.html
> > <
> http://www.us.apache.org/dist/storm/apache-storm-2.0.0/RELEASE_NOTES.html>
> > [2]: https://issues.apache.org/jira/browse/STORM
> >
>

Re: [ANNOUNCE] Apache Storm 1.2.3 Released

[sebbaz]

On 2019/07/18 17:49:55, Stig Rohde Døssing  wrote: 
>  The Apache Storm community is pleased to announce the release of Apache
> Storm version 1.2.3.
> 
> Storm is a distributed, fault-tolerant, and high-performance realtime
> computation system that provides strong guarantees on the processing of
> data. You can read more about Storm on the project website:
> 
> http://storm.apache.org
> 
> Downloads of source and binary distributions are listed in our download
> section:
> 
> http://storm.apache.org/downloads.html

The download page does *not* currently have links to 1.2.3

> You can read more about this release in the following blog post:
> 
> http://storm.apache.org/2019/07/18/storm123-released.html
> 
> 
> Distribution artifacts are available in Maven Central at the following
> coordinates:
> 
> groupId: org.apache.storm
> artifactId: storm-core
> version: 1.2.3
> 
> The full list of changes is available here[1]. Please let us know [2] if
> you encounter any problems.
> 
> Regards,
> 
> The Apache Storm Team
> 
> [1]:
> http://www.us.apache.org/dist/storm/apache-storm-1.2.3/RELEASE_NOTES.html
> 
> [2]: https://issues.apache.org/jira/browse/STORM
> 

[GitHub] [storm] nescohen opened a new pull request #3088: MINOR: fix null dereference in SimpleSaslServer authentication

[GitBox]

nescohen opened a new pull request #3088: MINOR: fix null dereference in 
SimpleSaslServer authentication
URL: https://github.com/apache/storm/pull/3088
 
 
   Fixes a possible null dereference in the case that nid is null on line 183. 
Switch to using a more flexible method of comparison (Objects.compare()) which 
will correctly compare one null on one non-null or two null values.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[ANNOUNCE] Apache Storm 1.2.3 Released

[Stig Rohde Døssing]

 The Apache Storm community is pleased to announce the release of Apache
Storm version 1.2.3.

Storm is a distributed, fault-tolerant, and high-performance realtime
computation system that provides strong guarantees on the processing of
data. You can read more about Storm on the project website:

http://storm.apache.org

Downloads of source and binary distributions are listed in our download
section:

http://storm.apache.org/downloads.html

You can read more about this release in the following blog post:

http://storm.apache.org/2019/07/18/storm123-released.html


Distribution artifacts are available in Maven Central at the following
coordinates:

groupId: org.apache.storm
artifactId: storm-core
version: 1.2.3

The full list of changes is available here[1]. Please let us know [2] if
you encounter any problems.

Regards,

The Apache Storm Team

[1]:
http://www.us.apache.org/dist/storm/apache-storm-1.2.3/RELEASE_NOTES.html

[2]: https://issues.apache.org/jira/browse/STORM